Channels
#android
- l
leosan
10/12/2017, 12:00 PM@menegatti it's because its inside an
not anobjectabstract class - a
anstaendig
10/12/2017, 12:01 PMJust tested with memory dump, and even after killing activity and totally removing it from heap I still have my object AModule inside memory, not exactly what we would want to.. - a
anstaendig
10/12/2017, 12:01 PMThat’s what has me worrying - l
leosan
10/12/2017, 12:04 PMI haven't test this for myself to be honest 😕 - l
leosan
10/12/2017, 12:04 PMalso try to annotate your companion object with
@anstaendig@module - a
anstaendig
10/12/2017, 12:04 PMThat works - a
anstaendig
10/12/2017, 12:05 PMJust somewhat confusing - u
user
11/30/2017, 4:00 PM@dave08 commented on @louiscad’s file https://kotlinlang.slack.com/files/U3ZLHBTLG/F876LKX0R/view_kt.kt: You could use null for the GONE state... - r
rkeazor
11/30/2017, 4:02 PMooo yea thats true , how your going to represent 3 states with a boolean lol - r
rkeazor
11/30/2017, 4:03 PMlol magical - u
user
11/30/2017, 4:19 PM@louiscad commented on @louiscad’s file https://kotlinlang.slack.com/files/U3ZLHBTLG/F876LKX0R/view_kt.kt: But it involves autoboxing and a
in Kotlin has 3 states making boolean expressions more complexBoolean? - p
Paul Woitaschek
11/30/2017, 4:28 PMI rarely use invisible - p
Paul Woitaschek
11/30/2017, 4:29 PMAnd it's not infix, it's just an extension - p
Paul Woitaschek
11/30/2017, 4:29 PMDoes not look too fancy to me - a
adam-mcneilly
11/30/2017, 4:30 PMI have always just done stuff like this:Copy codefun View.show() { this.visiblity = View.VISIBLE } fun View.hide() { this.visibility = View.GONE } - a
adam-mcneilly
11/30/2017, 4:31 PMUnless I'm misunderstanding the real objective here. - j
jw
11/30/2017, 4:32 PMthere is no objective😂 1 - j
jw
11/30/2017, 4:33 PMthis is a discussion of minutia that has no bearing on readability or writability and mostly boils down to people wanting to be cute with the language👏 3 - d
dave08
11/30/2017, 4:46 PMespecially dealing with cleaning up other peoples code in the company ... 😜 - j
jw
11/30/2017, 4:46 PMit's entirely a non-problem - d
dave08
11/30/2017, 4:47 PMIf you have time to do it, I agree totally! - d
dave08
11/30/2017, 4:47 PMOtherwise it boils down to a search/replace to clean up... - a
adam-mcneilly
11/30/2017, 4:51 PM^That's why I like just making extension functions for them. It's simple, cuts out some of my boilerplate, but still makes my activity code readable to anyone new. I don't know if I can say the same about that delegate stuff. - l
louiscad
11/30/2017, 4:56 PM@jw Maybe you could publish a top mid-length list of what can be improved in the apps you have seen? - d
dave08
11/30/2017, 4:58 PMAnyone has a clean way to do MVP w/ RecyclerView in Kotlin, I found this for java: https://android.jlelse.eu/recyclerview-in-mvp-passive-views-approach-8dd74633158, but I'm sure in Kotlin it could be more generic and clean...😮 1 - a
adam-mcneilly
11/30/2017, 5:00 PMI don't know how much different it would be in Kotlin? 🤔 - a
adam-mcneilly
11/30/2017, 5:00 PMLooks a little cleaner than what I'm currently doing, bookmarked for sure. - d
dave08
11/30/2017, 5:01 PMThis is too boilerplate... - b
burak.eregar
11/30/2017, 5:02 PMI have developed a library to reduce boilerplate. - b
burak.eregar
11/30/2017, 5:03 PMAnd used it in this sample Kotlin project; https://github.com/burakeregar/KotlinRxMvpArchitecture