Channels
#announcements
- n
natpryce
12/08/2015, 7:13 PMWhy do that in the compiler instead of in a build tool? - v
vmironov
12/08/2015, 7:18 PMandroid gradle plugin has a transformation api for exactly that purpose - c
cedric
12/08/2015, 7:19 PM1) The compiler is the only one that knows which files need to be recompiled. 2) If you leave it up to the build tool, all build tools need to reimplement their own thing. Much more logical to do it in the compiler and offer listener interfaces to build tools. - v
vmironov
12/08/2015, 7:27 PMbytecode weaving is a language agnostic thing - v
vmironov
12/08/2015, 7:27 PMyou shouldn't care if bytecode was generated by
orjavackotlinc - v
vmironov
12/08/2015, 7:27 PMso you shouldn’t rely on compiler api - m
mikehearn
12/08/2015, 7:28 PMthe weaver is language agnostic. however i want to ensure it's always triggered including when people are building with intellij - m
mikehearn
12/08/2015, 7:28 PMor rather, triggered for the right classes - m
mikehearn
12/08/2015, 7:28 PMit'd also be nice if the person reading the code could see at the declaration site that the bytecode was being modified - c
cedric
12/08/2015, 7:38 PMNot sure why we jumped from incremental compilation to bytecode weaving - v
vmironov
12/08/2015, 7:43 PMprobably because the original question was about “bytecode rewriting” and “bytecode enhancement” which has not so much to do with incremental compilation simple smile - m
michaelrocks
12/08/2015, 8:06 PM@mikehearn: I’ve already implemented a Gradle plugin that does bytecode processing for pure Java and Android projects. You can take a look at the source code here: https://github.com/MichaelRocks/lightsaber/tree/develop/gradle-plugin/src/main/groovy/io/michaelrocks/lightsaber/plugin - m
mikehearn
12/08/2015, 8:09 PMthanks - m
mikehearn
12/08/2015, 8:09 PMthe lightsaber README is not very informative simple smile - m
michaelrocks
12/08/2015, 8:10 PMYep simple smile I’m working on it - m
michaelrocks
12/08/2015, 8:10 PMBut the plugin is quite small and easy to understand - m
mikehearn
12/08/2015, 8:10 PMbtw there's a typo on line 94 of JavaPlugin.groovy - m
michaelrocks
12/08/2015, 8:11 PMOne of my most popular typos in the project simple smile - m
michaelrocks
12/08/2015, 8:11 PMThanks - m
mikehearn
12/08/2015, 8:15 PMboggle. is discuss.kotlinlang.org hosting private forums too? i just got a notification that said - m
mikehearn
12/08/2015, 8:16 PM - m
mikehearn
12/08/2015, 8:16 PMby "CRAX" - m
mikehearn
12/08/2015, 8:16 PMno clue where that came from - m
mikehearn
12/08/2015, 8:16 PMthe link the notification goes to is a 404 of course - m
mikehearn
12/08/2015, 8:33 PM@michaelrocks: it's cool, thanks, i'll think about playing with it later. for now i'm using a special classloader to do the rewrite at runtime, but of course, that has some pretty severe disadvantages. - m
mikehearn
12/08/2015, 8:34 PMwhat I really want is still a @CompilerRewrite() annotation on classes ... - m
michaelrocks
12/08/2015, 8:50 PM@mikehearn: In this case you may be interested in other parts of the project such as
. What it does is looking for classes marked with some annotations and patching them and/or generating new classes.processor - m
melonstorm
12/08/2015, 8:52 PM@mikehearn: Look at the URL. The topic title indicates that this was just spam that was promptly deleted by staff. - m
mikehearn
12/08/2015, 8:53 PMoh, i see. I saw the notification and it was immediately dead because I had only just approved the web app for notifications. I assumed I'd only see notifications that were triggered after I approved it. - l
lakedaemon
12/08/2015, 9:59 PMwhy does val s : Short = -1.toShort() produce an error in Kotlin ?