pakoito
01/20/2018, 8:07 PMmkobit
01/20/2018, 8:16 PMpablisco
01/23/2018, 1:12 AMinstances
in the arrow-instances
module contains types related to the arrow-data
. Should those be moved there?pakoito
01/23/2018, 1:20 AMpakoito
01/23/2018, 1:20 AMpakoito
01/23/2018, 1:21 AMpablisco
01/23/2018, 1:23 AMraulraja
01/23/2018, 9:35 AMpablisco
01/23/2018, 9:37 AMpguardiola
01/23/2018, 11:12 AMpguardiola
01/23/2018, 11:17 AMEditor > Code Style > Kotlin
) and then Reformat Code
Cmd + Alt + L (Mac)pablisco
01/23/2018, 12:32 PMfun <B> foldLeft(b: B, f: (B, A) -> B): B
Should the body be:
ev().fold({ b }, { f(b, it) })
or just
fold({ b }, { f(b, it) })
My understanding is that ev()
is just a safe down cast , right?simon.vergauwen
01/23/2018, 12:34 PMev()
is redundant.pablisco
01/23/2018, 12:34 PMpablisco
01/23/2018, 12:34 PMWeakKind
right?simon.vergauwen
01/23/2018, 12:35 PMfoldLeft
on WeakKind
and fold
is defined on Weak
then you would need to downcast.pablisco
01/23/2018, 12:35 PMTry
is doing this:
fun <A, B> Try<A>.foldLeft(b: B, f: (B, A) -> B): B = this.ev().fold({ b }, { f(b, it) })
I think that's what confused mesimon.vergauwen
01/23/2018, 12:36 PMthis.ev()
is also redundant I think.pakoito
01/23/2018, 12:49 PMev()
for the library userpakoito
01/23/2018, 12:50 PMpakoito
01/23/2018, 12:50 PMpakoito
01/23/2018, 12:51 PMpakoito
01/23/2018, 12:51 PMchristophsturm
01/23/2018, 12:52 PMjulian
02/12/2023, 6:43 PMYoussef Shoaib [MOD]
02/25/2023, 8:01 PMvalue class Option
and I think it's ready for me to benchmark and present the results in a PR.Youssef Shoaib [MOD]
02/27/2023, 7:34 AMvalue class Option
. From the benchmarks (included in the PRs), it seems as though there is marginal benefits of turning Option into a value class, but tangible benefits were seen when taking the more intrusive approach (in #2950) of optimizing nested Options. All the data and extensive commentary about upsides and downsides is available in the PRs.
Perhaps my benchmarks are flawed as well, so if you have any suggestions for more representative benchmarks please let me know. All feedback is welcome!simon.vergauwen
02/28/2023, 8:35 PMparTupled
and it couldn't be resolved without providing CoroutineContext
🤔 Did you encounter something like this while you were working on the PR?Slackbot
04/09/2023, 3:55 PMRon S
04/27/2023, 9:15 AM