https://kotlinlang.org logo
Channels
Powered by
#arrow-contributors
  • s

    simon.vergauwen

    02/06/2018, 1:32 PM
  • s

    simon.vergauwen

    02/06/2018, 1:33 PM
    DSL syntax is identical only the machinery to enable it is slightly different.
    ❤️ 2
  • r

    raulraja

    02/06/2018, 1:34 PM
    Once this is more concrete and final you guys may consider porting this to scala's monocle or companion lib for the DSL. This is way too cool.
    👍 2
  • s

    simon.vergauwen

    02/06/2018, 1:36 PM
    I want to experiment with 
    Traversal
    as we probably want 
    IndexFilter
    and 
    Each
    (not in yet) typeclasses for better support for 
    Traversal
    operations.
  • j

    jereksel

    02/06/2018, 1:48 PM
    I'll start working on at traversal annotation and listToTraversal.
  • s

    simon.vergauwen

    02/06/2018, 1:50 PM
    No need for that.
  • s

    simon.vergauwen

    02/06/2018, 1:50 PM
    If a 
    Traverse
    instance is available then you can get a 
    Traversal
    .
  • s

    simon.vergauwen

    02/06/2018, 1:53 PM
    And you can use 
    Each
    typeclass to retrieve them. https://hackage.haskell.org/package/lens-4.16/docs/Control-Lens-Each.html
  • j

    jereksel

    02/06/2018, 1:54 PM
    I was talking about including this: https://github.com/arrow-kt/arrow/pull/621/files#diff-7a2223010f4680f5325500c00e543e3cR85 to optics like I did with A? -> Optional<A>
  • j

    jereksel

    02/06/2018, 1:54 PM
    OK, I'll check it out
  • s

    simon.vergauwen

    02/06/2018, 1:55 PM
    Copy code
    inline fun <reified T, reified F, reified S> BoundOptic<T, HK<F, S>>.each(EA: Each<F, S, A> = arrow.optics.typeclasses.each())
    inline get() = compose(EA.each())
  • s

    simon.vergauwen

    02/06/2018, 1:56 PM
    Would look something like that.
  • s

    simon.vergauwen

    02/06/2018, 1:56 PM
    Yeah that instance is indeed missing @jereksel and it would be very useful to add it to the std. 👍
  • j

    jereksel

    02/06/2018, 1:57 PM
    Frankly, optics should work fine without converting lists to HK ones (I'm not against them, but I can't imagine people are going to replace Lists with ListsHK just to use Optics).
    🔝 3
  • j

    jereksel

    02/06/2018, 1:57 PM
    Cool, I'll add that then
  • s

    simon.vergauwen

    02/06/2018, 1:57 PM
  • j

    jereksel

    02/06/2018, 2:00 PM
    If we want to add very friendly Optics dsl it should be also available for people who doesn't use HK containers. And I think the last thing that isn't generated are traversables for data class.
  • s

    simon.vergauwen

    02/06/2018, 2:02 PM
    Problem is that you don’t know what container the user is using.
  • j

    jereksel

    02/06/2018, 2:02 PM
    I'm going to generate it only for lists for now
  • s

    simon.vergauwen

    02/06/2018, 2:02 PM
    Each
    will allow us to create a dsl that works for any container that has an instance.
  • s

    simon.vergauwen

    02/06/2018, 2:03 PM
    Which will be transparent to the user.
  • s

    simon.vergauwen

    02/06/2018, 2:03 PM
    I’ll try to expand the POC tonight to showcase what I mean.
  • s

    simon.vergauwen

    02/06/2018, 2:05 PM
    Ah you meant 
    List
    vs 
    ListKW
    ?
  • j

    jereksel

    02/06/2018, 2:06 PM
    I'm saying that optics shouldn't expose HK - at least in my opinion
  • j

    jereksel

    02/06/2018, 2:07 PM
    At least generated ones
  • r

    radimir.sorokin

    02/06/2018, 2:30 PM
    How about this implementation of 
    BoundSetter
    ? I think this more consise then originally proposed.
  • r

    radimir.sorokin

    02/06/2018, 2:31 PM
    @radimir.sorokin uploaded a file: Untitled
    Untitled.kt
  • j

    jereksel

    02/06/2018, 2:46 PM
    I like it - it's nice combination of both ideas.
  • j

    jereksel

    02/06/2018, 2:47 PM
    I'm still on the fence about it being setter only to be honest.
  • r

    radimir.sorokin

    02/06/2018, 3:07 PM
    I think that proposed syntax won't be used for getting values at any. Standalone kotlin facilities is enough for doing this. I lean toward staying this syntax simple. Handling getters require some complications and has no signifant benefit.
    👍 2
1...171819...115Latest