Channels
#arrow-contributors
- s
simon.vergauwen
04/08/2018, 5:55 PMyes,
returns whatever it was called onalso - p
pakoito
04/08/2018, 5:57 PM-.- - p
pakoito
04/08/2018, 5:57 PMnone is useful - p
pakoito
04/08/2018, 5:58 PMokay, fixed it to “I recommend”👍 1 - p
pakoito
04/08/2018, 6:00 PMokay, I’m done for at least the next couple of hours - p
pakoito
04/08/2018, 6:00 PMleave the comments here, I’ll pick them up later - p
pakoito
04/08/2018, 6:01 PMand can we have the release today or does it have to be tomorrow? - p
pakoito
04/08/2018, 6:01 PMonce those are fixed, I’m good to go - p
pakoito
04/08/2018, 6:02 PMif anyone could please double check
for the typeclasses before mergingAll existing KDocs match their method signature - p
pakoito
04/08/2018, 6:02 PMit’d be great - p
pakoito
04/08/2018, 6:02 PMI’m gonna go take a shower and watch a show or something - p
pakoito
04/08/2018, 6:02 PMrest - p
pguardiola
04/08/2018, 6:38 PMGreat job folks 🙇 - p
pguardiola
04/08/2018, 6:38 PMKudos to you all - p
pakoito
04/08/2018, 7:51 PMCool, I’ve fixed everything in the code review - p
pakoito
04/08/2018, 7:51 PMUpdated the README - p
pakoito
04/08/2018, 7:51 PMI’ll review the KDocs in the typeclasses I guess - p
pakoito
04/08/2018, 7:51 PMand once that’s done - p
pakoito
04/08/2018, 7:51 PMwe’re ready for release - p
pakoito
04/08/2018, 7:52 PMwho here knows how to do it? - p
pakoito
04/08/2018, 7:52 PMis it just a tag in the branch? a release in github? - r
raulraja
04/08/2018, 9:51 PMtaking care of the release here, please everyone wait for tweets, etc. until the oficial Arrow Twitter account tweets out the announcement on Monday or Tuesday - j
jereksel
04/12/2018, 11:06 AMCould you please reenable codecov integration? - p
pakoito
04/12/2018, 12:05 PMhow do you do that? Maybe I can - p
pakoito
04/12/2018, 12:06 PMokay, I just checked - p
pakoito
04/12/2018, 12:06 PMI don't have permissions - p
pakoito
04/12/2018, 12:06 PMmaybe @pablisco has them, or @raulraja? - p
pablisco
04/12/2018, 12:16 PMJust checked and I don't have access - r
raulraja
04/12/2018, 12:20 PMI don't either, we may have to git blame and see who set up code coverage originally - p
pakoito
04/12/2018, 12:23 PMcan't find it here