https://kotlinlang.org logo
Channels
Powered by
#arrow-contributors
  • p

    pakoito

    06/07/2018, 10:07 AM
    yeah someone complained on gitter
  • p

    pakoito

    06/07/2018, 10:07 AM
    that’s why I know 😄
  • s

    simon.vergauwen

    06/07/2018, 10:14 AM
    Ugh I keep missing Gitter notifications ><
  • s

    simon.vergauwen

    06/07/2018, 10:15 AM
    I just caught up. With the proposal for codegen it will make sure there are not package conflicts by generated code.
  • s

    simon.vergauwen

    06/07/2018, 10:15 AM
    But we should still go trough the code and fix all package conflicts we currently have.
  • s

    simon.vergauwen

    06/07/2018, 10:16 AM
    i.e. 
    arrow-instances-core
    & 
    arrow-instances-data
    are in conflict with eachother
  • p

    pakoito

    06/07/2018, 11:03 AM
    👍
  • s

    simon.vergauwen

    06/09/2018, 10:07 AM
    It seems we can quite easily remove 
    arrow-data
    & 
    arrow-instances-data
    dependency from 
    arrow-optics
    and replace it with 
    arrow-core
    & 
    arrow-instances-core
    .
  • s

    simon.vergauwen

    06/09/2018, 10:08 AM
    Only difference is that 
    getAll
    will return 
    kotlin.List
    instead of 
    arrow.data.ListK
    + we’ll have to create additional modules in Optics.
  • s

    simon.vergauwen

    06/09/2018, 10:09 AM
    Such as 
    optics-data-std
    (or 
    optics-instances-data
    ).
  • s

    simon.vergauwen

    06/09/2018, 10:09 AM
    Thoughts?
  • s

    simon.vergauwen

    06/09/2018, 10:10 AM
    I just tried this and noticed 
    Const
    is in 
    arrow-typeclasses
    . How come it’s there?
  • p

    pakoito

    06/09/2018, 11:04 AM
    Const is used by a typeclass somewhere IIRC, and it uses a typeclass itself so it couldn’t go on core
  • p

    pakoito

    06/09/2018, 11:04 AM
    wait, no
  • p

    pakoito

    06/09/2018, 11:04 AM
    it’s because some other module like Free depended on it, and if it was in data you’d have to bring core instances or something lik that
  • p

    pakoito

    06/09/2018, 11:05 AM
    so instead we moved it to typeclasses to slim down free
  • s

    simon.vergauwen

    06/09/2018, 11:05 AM
    Alright sounds good
  • s

    simon.vergauwen

    06/09/2018, 11:06 AM
    I was expecting it in 
    data
    but this suits me perfectly. Otherwise we needed to introduce 
    internal data class Tagged<A, B>
    to remove data dependency.
  • a

    Aedan Smith

    06/10/2018, 10:31 AM
    Just finished the rough draft for recursion schemes' docs at https://github.com/arrow-kt/arrow/tree/aedans-recursion-docs/modules/docs/arrow-docs/docs/docs/recursion. I'd especially like comments on the intro, namely what I should add/remove, as it's a lot more free-form than the rest of the docs.
  • p

    pakoito

    06/10/2018, 2:29 PM
    wow, lots of good work here
  • p

    pakoito

    06/10/2018, 2:29 PM
    I’ll get to reviewing immediately 😄
  • p

    pakoito

    06/12/2018, 10:45 PM
  • p

    pakoito

    06/12/2018, 10:45 PM
    quick doc PR review, please
  • p

    pakoito

    06/13/2018, 10:05 AM
  • p

    pakoito

    06/13/2018, 10:05 AM
    another quick review!
  • s

    simon.vergauwen

    06/13/2018, 10:23 AM
    @pakoito done :)
    🎉 1
  • p

    pakoito

    06/14/2018, 8:59 PM
  • p

    pakoito

    06/14/2018, 8:59 PM
    slides a day early 🙂
  • j

    jacob

    06/15/2018, 12:52 AM
    Good luck 👍
  • p

    pakoito

    06/16/2018, 12:56 AM
    It went well, it was a lot like always, but it went well
1...383940...115Latest