Why? I wouldn’t change the fact that they’re interfaces, however we need to proper factory methods for them.

Ok, I thought anonymous classes in this context is antipattern.

What we should do is optimise the generated optics to not create a new instance on every call.

^^^ same for all typeclasses

Just adding this as a WIP for now: https://github.com/arrow-kt/arrow/pull/942 Is there anything I should add to Try/Either for it to be done? want to make sure I'm on the right track before I try add any other instances

Also, I'm not sure what the .txt file was or why it changed. I can remove that change if needed

^^^ a couple of suggestions

the txt is supposed to change, so we're good there

fixed!

Boolean now has a companion object, starting on 1.3

noob friendly ^^^

@pakoito re: https://github.com/arrow-kt/arrow/pull/942/files/07ea46c688b51b228284fda9652ded42ac60831d#r202997240

do you mean make a function called combine on the either datatyoe and then call it in the interface?

yes

same as map and flatMap

👍 shall do

@pakoito I'm not 100% how to move the function to the Either datatype, given it needs access to a typeclass interface definition to provide the SG for the inner types

I think https://github.com/arrow-kt/arrow/pull/942/files is now in a good place to discuss. I changed the Either impl to match the scalaz impl on requireing that for Either<L, R> Semigroup both L and R must be Semigroups. I can walk that requirement back and have L either overwrite or something if that's desired

add it as an extension function from the instances file

I believe we’ve done that before for things like Sequence

@pakoito ok, so the same way traverse is defined. I'll do that now

ok, I think that's done it.

yo arrowees! anybody online for a quick question? ping @pakoito @raulraja

the question is: why are type class instances

interface

and not

object

?

since you still need to create an instance at some point

some can have a single instance, some require parameters

we kept all of them as interfaces because it was easier for consistency purposes

codegen etc