https://kotlinlang.org logo
Channels
Powered by
#chucker
  • v

    Vova Buberenko

    01/24/2020, 6:53 AM
    We still don’t have a final decision here, since we actually didn’t discuss it properly.
  • g

    gammax

    01/24/2020, 11:33 AM
    ☝️ this. Ideally we would love to offer some sort of configuration to the user. At the same time we don't want to over engineer the thing + do not completely change the API. So the discussion is still opened.
  • c

    Colton Idle

    01/24/2020, 8:39 PM
    Agreed. Hopefully my points my sense. 1. I don't want to use chucker for errors 2. I don't want to mislead my qa and show them an error tab
  • c

    Colton Idle

    01/24/2020, 8:40 PM
    It seems like chucker does mainly http logging and error logging was just kind of tacked on.
  • v

    Vova Buberenko

    01/24/2020, 9:10 PM
    UPD: added a big warning on Github releases about 
    3.1.0
    being broken.
    👍 1
  • g

    gammax

    01/24/2020, 9:45 PM
    Are you around @Vova Buberenko?
  • g

    gammax

    01/24/2020, 9:48 PM
    Maybe you can take a look at my branch as I have a proposed solution for the response body handling? https://github.com/ChuckerTeam/chucker/tree/fix/cortinico/response_body
  • v

    Vova Buberenko

    01/24/2020, 9:49 PM
    Yep, I am here. I also just finished my solution and tested.
  • g

    gammax

    01/24/2020, 9:51 PM
    great 😄 I still haven't managed to see a 
    null
    in the body anywhere, but still. I've basically copied over `HttpLoggingInterceptor`'s implementation.
  • v

    Vova Buberenko

    01/24/2020, 9:51 PM
  • v

    Vova Buberenko

    01/24/2020, 9:52 PM
    I have to use one of apps, which I support to see 
    null
    as reported. For this fix I propose - everything seems fine there.
  • g

    gammax

    01/24/2020, 9:55 PM
    I have to use one of apps, which I support to see 
    null
    as reported
    Like you need to do a release APK?
  • g

    gammax

    01/24/2020, 9:55 PM
    or just running a debug build?
  • v

    Vova Buberenko

    01/24/2020, 9:57 PM
    No-no 
    debug
    works fine. I just add Chucker as dependency there, but from snapshot from branch to test if I don’t see 
    null
    anymore. This was the only way to see this issue for me.
  • g

    gammax

    01/24/2020, 9:57 PM
    Ok so looks like the problem might be in the compiled artifact coming from the maven repo.
  • g

    gammax

    01/24/2020, 9:58 PM
    side note: we also have the README not up to date
  • g

    gammax

    01/24/2020, 9:58 PM
    Copy code
    dependencies {
  debugImplementation "com.github.ChuckerTeam.Chucker:library:3.0.1"
  releaseImplementation "com.github.ChuckerTeam.Chucker:library-no-op:3.0.1"
}
  • v

    Vova Buberenko

    01/24/2020, 9:59 PM
    Yep and 
    TODO
    there as well needs to be updated. Anyway, I would like to release a hot-fix first) The main idea behind my fix is to create a complete copy of the whole 
    Response
    and is it for processing, not original response from the chain.
  • g

    gammax

    01/24/2020, 10:01 PM
    yeah seems to work for the sizes. I'm still unable to get a 
    null
    response body, so it's unable for me to replicate 😐
  • v

    Vova Buberenko

    01/24/2020, 10:02 PM
    This is how I test the fix - just add a dependency there. I am not sure the issue is in the artifact, because otherwise I would still see the issue.
  • v

    Vova Buberenko

    01/24/2020, 10:02 PM
    I will ping the original reported if he is still online to confirm if it works.
  • g

    gammax

    01/24/2020, 10:03 PM
    Yeah I go that 👍 The point is that I'm not able to replicate the bug at all. Like I never saw a 
    null
  • g

    gammax

    01/24/2020, 10:03 PM
    So yeah, you solution works for me. Also 
    3.1.0
    works for me 😅
    😄 1
  • g

    gammax

    01/24/2020, 10:03 PM
    I'll load another app, let's see if I manage to get it somewhere
  • v

    Vova Buberenko

    01/24/2020, 10:05 PM
    Yeah, I understand your point of not getting 
    null
    . Same thing for me and that app I used - if you check the screenshot I attached in the issue (with greyed endpoints) you will see that only 2 requests showed 0 size (and `null inside), while other 3 worked perfectly fine.
  • g

    gammax

    01/24/2020, 10:13 PM
    Ok so I was able to reproduce. I had to take a 1 year old project xD
    😂 1
  • v

    Vova Buberenko

    01/24/2020, 10:14 PM
    On 
    3.1.0
    or with my fix?
  • g

    gammax

    01/24/2020, 10:15 PM
    Screenshot 2020-01-24 at 23.15.38.png
  • g

    gammax

    01/24/2020, 10:15 PM
    let's give this guy some time 😅
  • g

    gammax

    01/24/2020, 10:17 PM
    Anyway, from the code looks like your implementation will suffer the same 
    IllegalStateException: closed
    no?
12345...8Latest