kotlinlang #codereview

fun createVKVertexInputAttributeDescriptionUpdater(binding: Int, location: Int, format: VkFormat, offset: Int): (VkVertexInputAttributeDescription) -> Unit = {
    it.location = location
    it.binding = binding
    it.format = format
    it.offset = offset
}

inline fun VertexInputAttributeDescription(vararg updaters: (VkVertexInputAttributeDescription) -> Unit): VkVertexInputAttributeDescription.Buffer {
    val res = VertexInputAttributeDescription(updaters.size)

    updaters.forEachIndexed { idx, updater -> updater(res[idx]) }

    return res
}

elect

04/26/2018, 5:00 PM

yeah, I also thought something similar but this mean that in the core code I'd have to call

createVKVertexInputAttributeDescriptionUpdater

for each line..

elect

04/26/2018, 5:00 PM

at the moment, it's so clean as

elect

04/26/2018, 5:00 PM

Copy code

// Attribute descriptions
        val vertexInputAttributes = vk.VertexInputAttributeDescription(
                VERTEX_BUFFER_BIND_ID, 0, VkFormat.R32G32B32_SFLOAT, 0,                         // Location 0: Position
                VERTEX_BUFFER_BIND_ID, 1, VkFormat.R32G32B32_SFLOAT, Vec3.size,                         // Location 1: Color
                VERTEX_BUFFER_BIND_ID, 2, VkFormat.R32G32_SFLOAT, Vec3.size * 2,                // Location 2 : Texture coordinates
                VERTEX_BUFFER_BIND_ID, 3, VkFormat.R32G32B32_SFLOAT, Vec3.size * 2 + Vec2.size) // Location 3 : Normal

elect

04/26/2018, 5:01 PM

between the two, I prefer to blow the wrapper call

Andreas Sinz

04/26/2018, 5:02 PM

that means your

VertexInputAttributeDescription()

will be huge

elect

04/26/2018, 5:03 PM

yep

elect

04/26/2018, 5:03 PM

less worst scenario for me

tipsy

05/02/2018, 4:42 PM

i'm working on creating a configurable json-plugin for my library, would appreciate some feedback on the approach: https://github.com/tipsy/javalin/pull/205/files

tipsy

05/02/2018, 4:43 PM

in short i have created two interfaces with implementations that can be overridden:

Copy code

@FunctionalInterface
interface JsonToObjectMapper {
    fun <T> map(json: String, targetClass: Class<T>): T
}

@FunctionalInterface
interface ObjectToJsonMapper {
    fun map(obj: Any): String
}

elect

05/04/2018, 1:39 PM

I'm not sure if I shown this exactly snippet of code. Anyway, I recall I was suggested, for something similar, to use the

tailrec

function.

elect

05/04/2018, 1:39 PM

Copy code

var scrollWindow = window
                while (scrollWindow.flags has Wf.ChildWindow && scrollWindow.flags has Wf.NoScrollWithMouse &&
                        scrollWindow.flags hasnt Wf.NoScrollbar && scrollWindow.flags hasnt Wf.NoInputs && scrollWindow.parentWindow != null)
                scrollWindow = scrollWindow.parentWindow!!

elect

05/04/2018, 1:39 PM

is this still the case?

christophsturm

05/07/2018, 2:29 PM

whats the best way to return the last element of a list or null if the list is empty?

Shawn

05/07/2018, 2:29 PM

list.lastOrNull()

probably

christophsturm

05/07/2018, 2:31 PM

sounds good 🙂

christophsturm

05/07/2018, 2:37 PM

is that a a good way to add optional info to an error message:

Copy code

"Body is valid JSON but with the wrong parameters."
                        + (e.path.lastOrNull()?.fieldName?.let { " This field could not be read: $it"  } ?: "")

Shawn

05/07/2018, 2:38 PM

it’s a little esoteric-looking.

christophsturm

05/07/2018, 2:39 PM

yeah definately

Shawn

05/07/2018, 2:39 PM

I’d at least extract the null-checking to a separate line, or at the very least use a string interpolation if it makes sense in context