kotlinlang #codingconventions

apparently Go can also recompile unit tests in seconds, one of the worst if not the worst shortcomings of VM languages.. it’s insane how much focus has been given to shortening the amount of typing that developers have to do, when compile times for a simple test rerun vary by orders of magnitude...

👍 1

codeslubber

03/26/2017, 4:43 PM

but compilation still took a while

mg6maciej

04/01/2017, 4:18 PM

@redrield Why did you tell her to get out? That wasn't nice.

mg6maciej

04/01/2017, 9:10 PM

I guess I'm somewhere in the middle. I would want this useless-to-compiler information not to be encoded in the model we are using to store code and let each and every user define their own view with their own preference. So Marketa could use tabs, 2 spaces width and you could use 4 spaces.

👍 1

cedric

04/02/2017, 5:18 AM

One of the main reasons why I dislike ASCII art in the code (such as aligning on the parameters above) is that if I decide to rename the function name and change its length, then the whole parameter list is going to appear as a diff, while it's not really a diff

👍 8

bachhuberdesign

04/08/2017, 5:26 PM

Quick question.

lateinit private var

private lateinit var

1️⃣ 1

2️⃣ 17

bamdmux

04/27/2017, 5:26 AM

For example if you have

MyClass.()-> Unit

have a typealias

MyClassExtension

or if you have

Generic<T>

typealiases would be

IntGeneric

StringGeneric

miha-x64

05/04/2017, 8:01 AM

Wow, you’ve created a new channel 🙂

yole

05/24/2017, 5:53 PM

I'm now working on a full style guide for Kotlin based on notes at https://github.com/yole/kotlin-style-guide/issues, and I'd appreciate your feedback. here's the current draft: https://github.com/JetBrains/kotlin-web-site/blob/e562c56615b4ba6c51a8b2251eb3e201860b15e4/pages/docs/reference/coding-conventions.md

👍 1

mg6maciej

05/24/2017, 5:55 PM

@yole camel humps with an uppercase first letter = PascalCase 😉

👍 1

kirillrakhman

05/24/2017, 6:05 PM

Avoid using multiple labeled returns in a lambda. Consider restructuring the lambda so that it will have a single exit point. If that's not possible or not clear enough, convert the lambda into an anonymous function.

if the lambda doesn't close over any locals, why not a proper method?

mg6maciej

05/24/2017, 6:22 PM

If default formatter is changed to that and you try to do in on Kotlin codebase itself, you would get tens of thousands of lines changed.

kevinmost

05/24/2017, 8:25 PM

1️⃣ might look weird in your Slack snippet, but with IDE highlighting I don't think you're frequently going to get mixed up looking at it. I don't know about others, but I also like to put an empty line after my class header, usually

kevinmost

05/25/2017, 6:02 PM

anyone have a particularly clean way to ensure that a

when

whose result you don't care about is exhaustive? I could store it into a variable (and explicitly suppress the unused lint warning), or chain an empty, unused

.run {}

on it, presumably. Anyone have any less weird ways?

yole

05/26/2017, 2:58 PM

Second draft of the style guide, feedback still welcome: https://github.com/JetBrains/kotlin-web-site/blob/636fe9e9d799eaa1e5c9d02b838f45aab1a13af2/pages/docs/reference/coding-conventions.md

reggar

05/26/2017, 3:49 PM

Perhaps its in the doc and I’ve missed it but I’d like to see a rule around uses of curly brackets (https://github.com/yole/kotlin-style-guide/issues/20). My personal preference is cypressious’s suggestion.

cedric

05/26/2017, 3:52 PM

What's that suggestion?

kevinmost

05/26/2017, 8:37 PM

I usually place it at the start, probably just a holdover from

static

stuff usually going at the top in Java though Where does everyone usually put it? ⬆️ or ⬇️

⬇️ 13

⬆️ 7

mg6maciej

05/27/2017, 7:25 PM

I like to put private functions next to their use. But it gets pretty hard to do that in 1-dimentional space which is file.

🤔 2

elect

06/02/2017, 7:56 AM

is there a way to have a variable assignment with

if - else

with the code indented based on the position of the

if

val list = if(student != null && student.passing)
              getListForStudent(student)
           else 
              getStandardList()

feniix

06/12/2017, 11:06 PM

fun get_currency_value(currency: String): String {
    val r = khttp.get("<https://api.coinbase.com/v2/exchange-rates?currency=$currency>")
    when (r.statusCode) {
        200 -> return r.jsonObject.getJSONObject("data").getJSONObject("rates").getString("USD")
        else -> return ""
    }
}

mg6maciej

06/14/2017, 12:55 PM

I usually put a single public (extension) function per file and name it the same as function except PascalCase, e.g.

fun assertAll

would go into

AssertAll.kt

kevmoturi

07/06/2017, 2:34 PM

Where should companion objects go in the file? Top or the bottom? Also coming from java... how are we supposed to treat files? should i just keep all related classes in one file?

bachhuberdesign

07/10/2017, 3:11 PM

Makes sense, I almost wish there was a parameter folding feature so that you could fold to _ for unused parameters in the IDE but keep explicit naming in the actual code… but that’s way beyond scope