Can we add

consumeEach

for channels with

CoroutineContext

parameter? Now:

launch(CommonPool) {
    channel.consumeEach { ... }
}

Propose:

channel.consumeEach(CommonPool) { ... }

Can be done via extension function, but would be great to have this.

@Dmytro Danylyk

withContext(CommonPool) { channel.consumeEach { ... } }

. Do you really use it often?

It would be very confusing IMHO if we have suspending function (that waits until work done) named

consumeEach

and non-suspending function (that forks a new coroutine) with the same name.

Do you really use it often?

that’s how I usually consume data from channels 🙂

It would be very confusing IMHO if we have suspending function (that waits until work done) named

consumeEach

and non-suspending function (that forks a new coroutine) with the same name.

Name is not my point here, we can name it differently 🙂

.observeOn() ☺️

🧌

Can

withTimeout

be used with

SubscriptionReceiveChannel.consumeEach

? Perhaps I'm just using it incorrectly? It never breaks out of the `consumeEach`:

@travis uploaded a file: Untitled

If I wrap the

withTimeout

in a

try

and in the

catch

I re-throw using

throw IllegalStateException(e)

then I get the

IllegalStateException

as expected. Is that the intended behavior? It was a bit confusing for me not to see the

TimeoutCancellationException

using the above code snippet.

Android Studio 3.1 report following:

Redundant 'suspend' modifier less... (⌘F1) 
This inspection reports 'suspend' modifier as redundant if no other suspend functions are called inside

Is this a desired behavior? I thought I can use

suspend

modifier to mark functions which perform ‘heavy’ operations.

well I think if your function does not suspend inside the only suspension point would be created in the calling method

so no benefit from suspend

so if your heavy operation starts there is nothing that can stop it in the middle

Well let’s say I have a data source class -

UserDataSource#getUserById(id: Long)

How can I indicate to caller side that

getUserById

is a ’heavy` operation and you need to launch coroutine to deal with it?

well I am not at all expert on coroutines but ...

marking it suspends is ok

but you need to enable suspensions inside

you need to suspend

i.e. call delay (which probably does not make sense)

or call https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.coroutines.experimental/suspend-coroutine.html

otherwise it would be just regular call

no mechanism to unblock waiting for the result

there is many log(s) inside

sorry for that

but I am using suspendCoroutine there