Hey @Nanchen. Some rules do allow to change behavior depending on the class or depending on Annotations added to certain objects. But in general most projects (also Android) would use one configuration for the entire codebase.

If I understand correctly you’re only adding detekt to the top-level

build.gradle

file and then executing tasks for different gradle modules gives different results? And you also only define the config in the root project? If that’s the case it sounds weird. I agree, it makes sense only picking up the defined sourceSets and recursing in them to find all

.kt

files. However that will mean that the Gradle Plugin would have to automatically add detekt tasks to all submodules if the plugin is defined in the top-level. Otherwise we would never have any sourcesets to access.

@seb yep currently the detekt does not care about sourcesets and just parses from

project.projectDir

. In the rework I will make the gradle plugin sourceset aware ^^

@Artur Bosch I started to look at Detekt and the current plugin to get a better idea, but I find hard to wrap my head around the idea of profiles

we can still move it to its own repo later

is not generating reports I'm missing something?

hey guys what you mean by

optionally configure detekt for each sub module by using profiles (gradle-plugin)

I have a modular project

Yeah, I’ll make sure to mention all the changes in the notes and also updated all documentation already in the branch

@sachin4203 please take a look at our build.gradle.kt file

gradle
	idea(Action {
		path = "$userHome/.idea"
		codeStyleScheme = "$userHome/.idea/idea-code-style.xml"
		inspectionsProfile = "$userHome/.idea/inspect.xml"
		report = "${rootProject.projectDir}/reports"
		mask = "*.kt,"
	})

Hey, we’re currently relying on

1.0.0.RC6-3

due to a breaking api change in

1.0.0.RC6-4

of the plugin. Since a couple of days we can’t resolve

RC6-3

anymore through the gradle plugins repo. Is this known?

Is it possible to get a new version?

Are you team members using something else than AS or IDEA?

@sachin4203 I don't know about android studio, but detekt expects the idea folder to have a subfolder bin which has inspect.sh and format.sh can you confirm that your Android Studio.app/Contents folder has them?

checkstyle is the same, I believe. But there I understand why, because it's bundled with gradle it has to provide a way to utilize older rules configuration with newer checkstyle to avoid breaking the checks when gradle is upgraded. With detekt I do not see the rationale, maybe one of the authors would like to comment.

Oh I thought you meant changed from the previous run/commit

a-ha, found it!

ruleSets

is now gone, the right property is

plugins

. the docs here https://arturbosch.github.io/detekt/groovydsl.html#options-for-detekt-configuration-closure are outdated

right now something like this:

subprojects {
    apply plugin: "io.gitlab.arturbosch.detekt"

    detekt {
        version = "1.0.0.RC7-2"
        defaultProfile {
            input = file("src/main/kotlin")
            filters = ".*/resources/.*,.*/build/.*"
        }
    }
}

results :detektCheck running for each module… but analyzing the same module each time

a gradle plugin rework will solve this sooner or later ...

@Jukka Siivonen I answered in the issue, hope that helps, also I pushed a PR which documents how to add custom (or the formatting-jar) to the detekt tasks

There's a ticket for snapshots but noone has tackled it yet

Cool, I need to submit a formal request for someone's time, hopefully to get both the Gradle plugin done/checked and to integrate it with our static analysis plugin

Currently what I have is

expression.getCallNameExpression()?.textMatches("forEach")

where

expression

is a

KtCallExpression

and I would like to also check that the class of the caller is a

Map

or something implementing a

Map

. This is the part though where I am getting it wrong, because it does not seem to be like UAST, where you can check the

qualifiedName

of elements.

Screenshot 2018-08-03 at 15.35.19.png

image.png

is there a way prioritize a rule so it prints a warning but doesn't count in the issues calculation? I'm getting some pushback on leaving Detekt enabled for the LargeClass and TooManyFunctions rules because some of the older Java code is a bit monolithic and no one wants to refactor as part of the Kotlin conversion 😞

hey everyone, we get the following exception when running Detekt.

Running detekt 'unknown' on Java '1.8.0_144-b01' on OS 'Mac OS X'.
▸ Please create an issue and report this exception.
▸ java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
▸ java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
▸ java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1592)
▸ java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1582)
▸ java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
▸ java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
▸ java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
▸ java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

I am not sure where to look for the cause. Does anyone have any idea?

I can't find any documentation how to set up Detekt in multi module Gradle project, any tips?

Hey! I'm trying to implement custom detekt rules: - I added a new module for the rules - Added the new rule and tests (and it's working) - Added the META-INFO/services/... to point to the custom rule set provider. - Integrate the new ruleset with my project. My problem is that I just can't get the rule to be flagged (although the new ruleset appears in the output). Even if call

report

without any condition. Has anyone faced this?

only the register from configuration is still in incubating in 4.10

the gradle rework is merged - thanks to @mauin and @marschwar for the work! 🙂