Are the indentation rules for multi-line round brackets weird, or am I doing something wrong in my configuration? Code formats like this:

return (
 foo
  ) as Something

which looks ugly compared to:

return (
 foo
) as Something

This is a bit meta but... is there, or could there be, a detekt rule for reporting on unnecessary rule suppressions? The use case is that a rule was suppressed for some reason, but then the underlying problem is fixed. Detekt would then report on the now-unnecessary suppression so that the rule is not unintentionally broken again later.

What's the status of KMP support in rules? I'm getting a

UtilityClassWithPublicConstructor

violation for:

expect abstract class PlatformComponent {
  companion object
}

But with KMP it makes sense to have it.

do the detekt formatting rules use ktlint under the hood, or just attempt to reproduce ktlint’s behavior? I’m asking because I’m getting different indentation behavior between running detekt w/ auto correct enabled and manually running ktlint. Example:

fun FooEntity.toWire(): Foo =
    Foo.newBuilder()
       .setLastSeenYearMonth(
            PartialDate.newBuilder()
                .setMonth(this.lastSeenMonth)
                .setYear(this.lastSeenYear)
                .build()
        )
        .build()

ktlint leaves that block as-is. detekt formats it like this:

fun FooEntity.toWire(): Foo =
    Foo.newBuilder()
        .setLastSeenYearMonth(
        PartialDate.newBuilder()
            .setMonth(this.lastSeenMonth)
            .setYear(this.lastSeenYear)
            .build()
        )
        .build()

and then flags the indentation as wrong and increases the debt score.

formatting is completely mangling a few files, seems to be related to Mockk lambdas, maybe. Is there a way to just turn off formatting completely for a file? I tried

// ktlint-disable

just after the package declaration, but that didn’t work

Question. How to set report destination path in build.gradle on detekt 1.19.0 ?

Is there an option to not fail the build when all the issues are autocorrected? Or not print fixed issues in the terminal? Sometimes, I just want to run the autocorrect mid-development and see if there are other issues, but I have to run the task twice to see what was not fixed

is there a way to globally exclude a directory? we have some generated code checked in (yes… we know). And want to exclude that directory from contributing to score and from being formatted automatically.

I'm not sure what I'm doing wrong but I cannot get baselines to work with gradle. I ran the

detektBaseline

task. It generated a

detekt-baseline.xml

file, but when I run

detekt

again, all the errors are reported. The warnings are from a custom Rule I created, so it is possible that there is something wrong with how I reported it. It is suppressing some of the warnings but not all. I'm triggering warnings for all

@property

tags in class documentation. The baseline includes all the ones found, but it is only suppressing the last one in a given class documentation block. This seems to be a bug.

Yo talk about the errors than appear with type solving enabled, right?

Hi! Do you have a KMM project with detekt configured on github? (I mean, open source) I'm starting with KMM and I'm not sure if I'm failing on the gradle part, on the detekt configuration or it is just that the experimental support of detekt for KMM is not working in this case.

Trying to write a custom rules module for an android app. • It’s in a separate, kotlin only gradle module. • Depending on it in the app with

detektPlugins project(":carters-detekt")

and assembling my module before running detekt • My META-INF seems to be set correctly

src/main/resources/META-INF/services/io.gitlab.arturbosch.detekt.api.RuleSetProvider

But I’m getting this error

io.gitlab.arturbosch.detekt.api.RuleSetProvider: Provider com.carters.retail.detekt.CartersRuleSetProvider not found

which is the exact The package matches, the folder structure matches, the group matches. What other weirdness should I check that could be wrong?

Any plans on releasing an RC2? I'd like to test my projects against https://github.com/detekt/detekt/issues/4604

do we have a sample project where we could test detekt for Android native application?

https://twitter.com/mrmans0n/status/1507390768796909571 really good ideas for create a custom and open-source rule set for

Compose

if someone is looking for a side project 😛. They have them wrote for

ktlint

but they can't open source it now.

Enabled

UnnecessaryParentheses

rule and it reported this code

offset.y.toInt() in item.offset..(item.offset + item.size)

Sure, technically those can be removed, but wouldn't it look less readable? Do you think this might be an exception or config option? If yes, I can create issue and occasionally a PR.

Fairly new to the PSI api, I’ve only used the IR api so far. With type resolution enabled I’m having a pretty hard time getting a function’s return type. I’m resorting to a mishmash of mutliple different BindingContext slices to determine the type, but it seems like there must be a better way. May be a #compiler question, but there they seem to have success with just

bindingContext.get(BindingContext.EXPRESSION_TYPE_INFO, expression)

So I’m wondering if it may be something specific to how Detekt acquires the BindingContext?

Were there changes made to

UnnecessaryLet

for 1.20? I got a lot of violations in my project after updating to RC2. Most of them are related to using an "out" parameter, but I'm not sure if there's anything detekt can do there, and removing the

let

isn't terrible. There are some others, and I got one like this, and I'm not sure why it's unnecessary:

fun View.postHideKeyboard(shouldClearFocus: Boolean = false) {
  if(shouldClearFocus) {
    clearFocus()
  }
  val imm = context.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager

  rootView.windowToken.let { token -> <http://rootView.post|rootView.post> { imm.hideSoftInputFromWindow(token, 0) } }
}

Are there any plans in the future to have an indicator of whether a file or project follows all of detekt’s rules in the IDE, so I could see tech debt as it happens? I love how detekt keeps my code clean, but I also see a lot of messages in my commit history saying “make detekt happy”.

Was there an issue with the 1.13.0 artifacts? They don't seem to be in mavenCentral, but the compiler plugin is expecting them. I'm working around it now by explicitly depending on 1.13.1 artifacts. Also, is there a snapshot of the compiler plugin anywhere?

Is there anyway to change the default severity to error for every check, without needing to explicitly set it for every ruleset?

has anyone noticed issues with

jvmTarget

when attempting to upgrade to

1.20.0

? when I upgrade the version, now all my detekt tasks fail with

Invalid value passed to --jvm-target

I've tried adding

tasks.withType(Detekt).configureEach {
    jvmTarget = "1.8"
}

and that fails with

Could not get unknown property 'Detekt'

Anyone successfully using Kotlin's Explicit API Mode with Detekt in an Android project? Did you have to disable the

RedundantVisibilityModifierRule

rule?

Have you had any conversations with anyone at Google or Jetbrains about helping with that? I could contribute towards it, but I only have very basic experience with compiler plugins.

Just spotted that entries in my baseline seem to be different (extra whitespace) depending on whether the function has a doc comment or not. Before I go digging in changelogs and/or file an issue, is this something that's already been spotted/fixed? I think I'm on a slightly old version of detekt.

Just saw question about "running detekt on a single file" on my notifications. I came here to answer, but the message is gone 😅 Anyway, you can use the

--input

arg. More on this here https://detekt.dev/docs/gettingstarted/git-pre-commit-hook

Any plans for a 1.20.1 release for https://github.com/detekt/detekt/pull/4723? It (hopefully) fixes what is blocking me from 1.20.0

Hello guys, do you know why this url is broken: https://detekt.dev/compose.html

Not sure if this is a detekt or ksp issue, but when I run

detektJvmMain

I get the following warning:

Execution optimizations have been disabled for task ':samples:kotlin-inject:detektJvmMain' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/eli/workspace/portal/samples/kotlin-inject/build/generated/ksp/jvm/jvmMain/kotlin'. Reason: Task ':samples:kotlin-inject:detektJvmMain' uses this output of task ':samples:kotlin-inject:kspKotlinJvm' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to <https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implicit_dependency> for more details about this problem.
warning: classpath entry points to a non-existent location: /home/eli/workspace/portal/samples/kotlin-inject/build/generated/ksp/metadata/jvmMain/kotlin

I exclude generated ksp files from detekt using:

tasks.withType<Detekt>().configureEach {
  exclude {
    "/build/generated/ksp" in it.file.absolutePath
  }
}