I'm having a bit of a hard time replacing the deprecated "failFast" flag for the gradle alternative

I'm not savvy on Groovy/Gradle, so I don't know where the new flag is supposed to go

Hello people. Is it possible to have a master config file + another file for custom rules only? Use case More teams share the same config, which is fetched from a shared repo and ensures every team follows the same rule-set. But each team should be able to extend Detekt to create additional rules. What is the right way to define a configuration for additional rules only? Additional extra info I noticed that

detekt.config

accepts multiple files, but I’m unsure how it works. Do they have a particular priority? How could we add more than 1 config file to the Detekt plugin?

Hi any idea about this error when upgrade kotlin version from 1.6.20 to 1.7.10 and upgrade Android Gradle plugin AGP to 7.2.0 then run task call detektDebug task at the gradle i used detekt version 1.19.0 then i faced this error when run task incompatible classes were found in dependencies. Remove them from the classpath or use ‘-Xskip-metadata-version-check’ to suppress errors

Someone is sharing a detekt configuration via dependencies on multiple projects instead of copy/paste the yaml file?

Is there a more reliable way to check if a parameter is a lambda, besides this horror?

private fun isLambda(parameter: KtParameter) = ") -> " in parameter.text

Note that

isLambdaParameter

and

isFunctionTypeParameter

evaluate the

KtParameter

as a parameter of a lambda block

Hey hey :android-wave: Happy to share that 1.21.0 stable is out 🎉 https://github.com/detekt/detekt/releases/tag/v1.21.0

Hey detekt team, I have a question that is not about detekt functionality but about the functional tests for your plugin. I have a sample plugin that uses androids

BaseExtension

to access some information and it works fine on the my sample app project since I can find the extension via

extensions.findByType(BaseExtension::class.java) // returns null in functional test but works fine on the actual app project

but when I use

GradleRunner

for my plugin’s functional test, the expression above returns

null

even though I can find it via:

extensions.findByName("android") // not null in both cases

I was looking for a possible problem and found detekt project that has functional tests for android scenario and was wondering if you can suggest something. In my functional test I use this setup:

File(projectRoot, "settings.gradle")
            .apply {
                writeText(
                    """
                    include ':app'
                    """
                )
            }
        File(projectRoot, "build.gradle")
            .apply {
                writeText(
                    """
                    buildscript {
                        repositories {
                            google()
                            mavenCentral()
                        }
                        dependencies {
                            classpath "com.android.tools.build:gradle:7.0.1"
                            classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.32"
                        }
                    }
                    """
                )
            }
        val appModule = File(projectRoot, "app").apply { mkdir() }
        File(appModule, "build.gradle")
            .apply {
                writeText(
                    """
                    plugins {
                        id("com.android.application")
                        id("org.jetbrains.kotlin.android")
                        id("my.custom.plugin") // plugin under test
                    }
                    
                    android {
                        compileSdkVersion 30
                        defaultConfig {
                            applicationId "<http://my.custom.plugin.app|my.custom.plugin.app>"
                            
                            minSdkVersion 23
                            targetSdkVersion 30
                            
                            versionCode 1
                            versionName "1.0"
                        }
                    }
                    """
                )
            }

what's the ETA to have a detekt release with kotlin 1.7 ?

Hey @Peter Mandeljc I’m running into the same issue. Did you find a solution?

Hi everyone! We are updating our base config rules and for a lot of the former rule sets we were using

excludes: &generatedCode

to exclude generated code from each of the rules that apply. I thought there might be a way nowadays to exclude generated code from all rules so after looking into it, I found a closed issue about the topic: https://github.com/detekt/detekt/issues/4743 so I went with:

detekt {
    source = files("src/main/kotlin", "src/test/kotlin", "src/androidTest/kotlin")
}

but that didn’t make it. I saw another dev asking about this about two months ago but I’m not sure it got resolved: https://kotlinlang.slack.com/archives/C88E12QH4/p1654877805110359 I also landed on another thread where Nicola brought up:

Yeah I believe the

exclude

has no effect because we changed how we collect the source sets.

You’ll have to exclude using a like a package path or so. What happens is that excluded are computed for relative paths that are provided by the sourcesset from AGP

I’m not sure I completely follow the implications of the changes. I could assume this is a generic issue for most of us. Any chance you could share how you deal with this, if that’s the case? Thanks in advance 🙏

maybe something to ask #ktlint since detekt-formatting delegates to ktlint

Let's say I want to forbid

androidx.paging.compose.items

using

ForbiddenMethodCall

instead of

ForbiddenImport

, what pattern would I have to use given the following signature:

public fun <T : Any> LazyListScope.items(
    items: LazyPagingItems<T>,
    key: ((item: T) -> Any)? = null,
    itemContent: @Composable LazyItemScope.(value: T?) -> Unit
)

does the detekt IJ plugin track android studio generally? Or only stable releases? I noticed 1.21.1 still isn’t available for EE

question about the

InjectDispatcher

rule, should the following violate it:

class MyRepository(val dispatcher: CoroutineDispatcher) {
    @Inject // mark this constructor as the one used by guice at runtime, tests can still inject a TestDispatcher using the primary constructor
    constructor() : this(<http://Dispatchers.IO|Dispatchers.IO>)
}

This is basically equivalent to

class MyRepository(dispatcher: CoroutineDispatcher = <http://Dispatchers.IO|Dispatchers.IO>)

but still triggers the detekt rule. Or am I missing a difference?

Hello, I want someone can give me example for magic number warning or wildcard import and remove it with @Suppress annotation as intelliJ not support this for kotlin

When I run detekt in type resolution mode, it also check generated sources (for example I use an "sqldelight" library and it generates stuff in

build/generated/sqldelight/code.../SomeFile.kt

and Detekt analyzes it and prints errors. How should I instruct it to ignore

build/generated

? I recall there was some config option in gradle plugin, but cannot find it in the manual, maybe it got deprecated/removed.

Another question. I have a lot of

NamedArguments

violation for stuff like this

combine(myFlow, otherFlow, anotherFlow, ::Triple)

I don't want to turn this into

combine(flow = myFlow, flow2 = otherFlow, flow3 = anotherFlow, transform = ::Triple)

Luckily I've found

ignoreFunction

is a thing. But when I do

NamedArguments:
  ignoreFunction:
    - kotlinx.coroutines.flow.combine

errors don't go away. Tried wrapping it in single quotes, tried doing

ignoreFunction: [ 'kotlinx...combine' ]

instead, still nothing. Is this a bug? this function is not part of some class, it's a top-level one

Perhaps a silly question, but what is the criteria for

TooGenericExceptionCaught

? It's flagging this as being too generic, but

IndexOutOfBoundsException

seems pretty appropriate. https://github.com/rgmz/NewPipe/blob/75917c7f61cde0537075b3e1c5442cdf27755026/app/src/main/java/org/schabi/newpipe/info_list/StreamSegmentAdapter.kt#L54

I’ve written a custom rule as follows:

class LayoutModifierRequiredRule: Rule() {
  ..

  override fun visitNamedFunction(function: KtFunction) {
    super.visitNamedFunction(function)

    // ignore non-@Composable functions
    if (!function.hasAnnotation("Composable")) { return }
    
    val doesModifierParameterExist = function.valueParameters.any { it.name == "Modifier" }

    if (!doesModifierParameterExist) {
      report(..)
    }
  }
}

and in detekt.yml I’ve added the rule as following

LayoutModifierRequiredRule:
  active: true
  ignoreAnnotated: ['Preview']

Even though I mention to ignore @Preview annotation, it still highlights the @Preview functions. Am I doing anything wrong here ?

@Preview
@Composable
fun PreviewScreen() {
  MaterialTheme { .. }
}

Hello, we get a lot of security warnings because of a DoS vulnerability detected in snakeyaml 1.30 (see https://security.snyk.io/vuln/SNYK-JAVA-ORGYAML-2806360), in use by detekt 1.21.0. I can see that this is fixed in https://github.com/detekt/detekt/pull/5250. How is the procedure to release a new version of detekt? Could that be done soon?

I need to handle multiple exceptions (in this case, IllegalStateException and a custom exception class) in a catch block. As far as I can tell, Kotlin does not currently support multi catch, so I have to catch Exception and check the types. Detekt sees this and gives me a TooGenericExceptionCaught error. This would be fine if I could use multi catch to check for both types, but that’s not part of the language yet. Should I just disable the detekt error, or is there a good workaround?

is there any way to include detekt via spotless or is it just better to install detekt as a typical gradle plugin?

For some reason showing SARIF report results stopped working for me, although the report seems to be uploaded correctly. Any idea why might go wrong in this test PR? The GitHub action is configured like so: https://github.com/oss-review-toolkit/ort/blob/26392e163d2dd63dd9937f5369e458315c39cd08/.github/workflows/static-analysis.yml#L24-L32

Am I missing something or default Gradle

detekt

task does not verify Android project modules (Gradle subprojects. including the

app

default one)?

Just saw a changelog of the new release, I'm impressed as always, great work! (time to spice up some of my rules with type resolution)

Just a heads up that 1.22.0 is likely going to cause a lot of issues for people again because of

continuation_indent_size

https://kotlinlang.slack.com/archives/CKS3XG0LS/p1663735640538999

Not sure if this is a known problem or not, but the

KDocReferencesNonPublicProperty

is generating false positives when I use the ability to set the text for a code link to the name of a private property. This is a bad example but it shows that the property

workItem

is being accessed in KDoc.

We need a Detekt custom reaction for this slack btw 🙂