kotlinlang #detekt

Hi Everyone, Could you please help me on how Detekt is different from Android lint. would be helpful for me to a deeper knowledge .. I mean what kind of issues Detekt uniquely reports compared to AndroidLint

gabrielfv

09/16/2020, 11:22 PM

Hello, how do I find out if a method call stands for an extension for nullable type. If i have the method

Type?.extForNullable()

I want to identify in a rule if this method is called, and not a version of it exclusive for a non-null instance of

Type

, or a more specialized version of it, like

SpecificType?.extForNullable()

, even if

SpecificType : Type

. I’m trying to visit dot-qualified expressions, since if I go for a safe expression I’m not calling a nullable version any way, but idk how to follow from here

Daniel Svensson

09/22/2020, 8:26 AM

As kotlin doesn't have any granular

-Werror=...

etc I was hoping to convince detekt to error out if there are any: unused variables, unused methods, useless

foo?.bar

etc, but I can't seem to find it in the configuration. Am I missing something?

Marcelo Hernandez

09/24/2020, 6:47 PM

Hello. I am trying to resolve the return type of a function that returns a

Flow<T>

(including subclasses) in

visitNamedFunction

. I am new to the APIs in

kotlin-compiler-embeddable

. I am trying to use:

bindingContext[BindingContext.FUNCTION, function].returnType

but that seems to resolve to an

UnresolvedType

. I have also tried

function.getResolvedCall(bindingContext)

but that always returns

null

. Is there any way to resolve types that are not considered built-in?

karandeep singh

09/25/2020, 8:32 AM

Also, is anyone aware of any issues adding detekt with novoda plugin? (https://github.com/novoda/gradle-static-analysis-plugin)

themishkun

09/26/2020, 10:00 AM

Hi everyone, I wonder if detekt can export rules as part of the library (like android lint does). So, If I maintain a kotlin lib and want to highlight common errors, can I provide detekt rules that would be automagically included in consumer's detekt suite after she adds lib dependency (without explicitly declaring rule)?

robstoll

10/01/2020, 5:19 AM

updating to detekt 1.14.1 fails for me with:

Could not find io.gitlab.arturbosch.detekt:detekt-bom:1.14.1.
              Searched in the following locations:
                - <https://plugins.gradle.org/m2/io/gitlab/arturbosch/detekt/detekt-bom/1.14.1/detekt-bom-1.14.1.pom>
                - <https://repo.maven.apache.org/maven2/io/gitlab/arturbosch/detekt/detekt-bom/1.14.1/detekt-bom-1.14.1.pom>
                - <https://jcenter.bintray.com/io/gitlab/arturbosch/detekt/detekt-bom/1.14.1/detekt-bom-1.14.1.pom>

is this version not yet published?

BorzdeG

10/06/2020, 5:56 PM

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':myproject:detekt'.
> Could not resolve all files for configuration ':myproject:detekt'.
   > Could not resolve org.jetbrains.kotlinx:kotlinx-html-jvm.
     Required by:
         project :myproject > io.gitlab.arturbosch.detekt:detekt-cli:1.14.1 > io.gitlab.arturbosch.detekt:detekt-bom:1.14.1
      > Cannot choose between the following variants of org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
          - jvm-api
          - jvm-runtime
          - metadata-api
        All of them match the consumer attributes:
          - Variant 'jvm-api' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-api' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'jvm' but the consumer didn't ask for it
          - Variant 'jvm-runtime' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'jvm' but the consumer didn't ask for it
          - Variant 'metadata-api' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'kotlin-api' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'common' but the consumer didn't ask for it
   > Could not resolve org.jetbrains.kotlinx:kotlinx-html-jvm.
     Required by:
         project :myproject > io.gitlab.arturbosch.detekt:detekt-cli:1.14.1 > io.gitlab.arturbosch.detekt:detekt-core:1.14.1 > io.gitlab.arturbosch.detekt:detekt-report-html:1.14.1
      > Cannot choose between the following variants of org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
          - jvm-api
          - jvm-runtime
          - metadata-api
        All of them match the consumer attributes:
          - Variant 'jvm-api' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-api' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'jvm' but the consumer didn't ask for it
          - Variant 'jvm-runtime' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'jvm' but the consumer didn't ask for it
          - Variant 'metadata-api' capability org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2:
              - Unmatched attributes:
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'kotlin-api' but the consumer didn't ask for it
                  - Provides org.jetbrains.kotlin.platform.type 'common' but the consumer didn't ask for it

Jiddles

10/09/2020, 10:11 AM

Hey! Not sure if this is the best place to ask but does anyone know what happened to the Klones project/repo? (This one btw https://github.com/detekt/klones)

fo2rist

10/14/2020, 10:30 PM

Does anyone know if it's possible to set Detekt threshold in gradle file and keep the configuration in .yml? Use case: I have three projects in one repo and I want to share the config, but the threshold for each project is independent.

sanogueralorenzo

10/28/2020, 11:27 AM

Hello 👋 have a usecase where I want to ignore LongMethod if the method has a specific name. Is that possible?

mjthornton

10/30/2020, 7:05 PM

Is there a way to only enable a few rules without setting each unwanted .yml rule with: active: false?

Lilly

11/02/2020, 1:45 PM

Hi, I have registered the following task in my root build.gradle.kts:

tasks.register<Detekt>("detektAll") {
        setSource(projectDir)
        buildUponDefaultConfig = true
        config.setFrom(configFile)
        parallel = true
        debug = true
        reports {
            xml.enabled = false
            html.enabled = false
            txt.enabled = false
        }
        include("**/*.kt")
        include("**/*.kts")
        exclude("resources/")
        exclude("build/")
    }

I run the task with

gradlew detektAll

. Why does it log the output to console in first run but not in second run? Edit: ok got it. I had set the maxIssues to 30, now it's 0 again. Same code different question: my task does not show the

formatting

rule set from the

formatting

plugin while

detekt

does. Did I miss something. Edit2: ok got second issue too. I had to add

dependencies {
    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.14.2")
}

to my root build.gradle.kts, not to my sub projects build script. Edit3: correction: I have to add it to root build script and sub projects build script aswell

Lilly

11/02/2020, 3:31 PM

When running

detekt

task, it complains about

SpreadOperator

. The docs state:

When type resolution is enabled in detekt this case will not be flagged by the rule since it doesn’t suffer the performance penalty of an array copy.

Does it mean

detekt

shouldn't detect that issue?

mjthornton

11/05/2020, 5:39 PM

I'm currently writing unit tests for my custom rules. Is there a way to supply .lint() an entire file instead or strings? This works for me, but for longer strings, it gets very messy

@Test
fun `TOFUBRuleTest() Test`(){
    TOFUBRule().lint("$kDOCTestString")
}

spand

11/16/2020, 10:35 AM

Can I use detekt to ban usages of certain classes/methods in external modules ? ie. a method from the stdlib ? (And if not does such a tool exists?)

Jakub Chrzanowski

11/22/2020, 10:38 PM

Hi folks! How is that if I run

detekt

Gradle task directly, it prints output with proper colors, but when run via

check

task, I get something like:

> Task :detekt FAILED
formatting - 5min debt
	[33mNoConsecutiveBlankLines - [] at /Users/hsz/Projects/JetBrains/intellij-plugin-template/src/main/kotlin/org/jetbrains/plugins/template/services/MyProjectService.kt:3:1[0m
Overall debt: 5min

Sourabh Rawat

11/25/2020, 9:15 AM

I was trying to use precompiled gradle plugins in buildSrc but it is giving me following error with v1.2.2

Caused by: org.gradle.api.GradleException: Error resolving plugin [id: 'org.jetbrains.kotlin.jvm', version: '1.3.61']
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.resolveToFoundResult(DefaultPluginRequestApplicator.java:207)
	... 155 more
Caused by: org.gradle.plugin.management.internal.InvalidPluginRequestException: Plugin request for plugin already on the classpath must not include a version

~~It works if I upgrade detekt to latest one. But I want to know why it is failing in older version, since upgrading the plugin will require more than a few changes and this is a production project~~ Seems like it is failing on latest one as well

Javier

12/02/2020, 11:31 AM

Has Detekt, in general or the intellij plugin, a strict mode which force the refactor like Dart/Flutter plugin has? For example, if I have a

data class

in a single line which ends with a trailing comma, using the detekt plugin to format it, the format keeps. But it should be changing to multiline (or at least delete the trailing comma, but with a strict mode I think it should be converted to multiline). Another example is can be:

fun something() = "something"
fun something() = 
    "something"

The second one clearly should be reformated to the first one because it fits de space, but like both approach are valid, it doesn't get reformat I love a lot how the reformat works in Dart/Flutter because it forces A LOT how the code should look. Overall about spacing and playing with trailing comma to reformat from single line (or a "broken multiline") to multiline that looks good

Sebastian Schuberth

12/07/2020, 5:03 PM

Hi, since the upgrade of my project to Kotlin 1.4.20 I'm getting very weird excpetions from detekt, like "Collection is empty", "configUrl must not be null", or "io/github/detekt/tooling/api/InvalidConfig". Has anyone else seen these?

themishkun

12/17/2020, 11:06 AM

Hello there. I am having a trouble enabling type resolutions in my projects with detekt 14.2 version. When running

detektMain

command, I keep getting the same error about detekt not being able to choose kotlinx-html dependency. Like that

Cannot choose between the following variants of org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.2

Any tips on this? Full exception message can be found here https://pastebin.com/uPHFNVtB Thank in advance

themishkun

12/17/2020, 3:02 PM

Is there any configuration for disabling type-resolution for

UnusedImport

rule? Since type resolution does not work with kotlin synthetics, and our project is full of them, this rule give me 1k+ false-positives

Brais Gabin

12/24/2020, 9:26 AM

Do you think that an issue for this would be useful? https://twitter.com/Piwai/status/1341695742486953987

:yes: 2

Sebastian Schuberth

01/05/2021, 1:52 PM

Is there an easy way to get the relative path to a file WRT the Gradle root project in a `Rule`'s

visitPackageDirective

function?

taso

01/08/2021, 5:20 PM

Does anyone use "Deprecation" rule under "potential-bugs"? I just enabled it but it did not give me any new error. We have a lot of deprecated usages actually

Marcelo Hernandez

02/04/2021, 12:03 AM

Hello. If I recall correctly, there used to be documentation in the Detekt GitHub repo containing the steps to run for those authoring pull requests. Not sure if it was removed or am I just not seeing it? 🤔

Big Chungus

02/07/2021, 6:44 PM

Is it possible tu use detekt as formatter instead of ktlint?

Javier

02/08/2021, 9:26 AM

I am trying to ignore failures via

ignoreFailures = true

and I tried

isIgnoreFailures = true

too. Nothing works. This was working for me some months ago.

Sebastian Schuberth

02/09/2021, 1:28 PM

Hi there, is there a rule in detekt that generally checks that operators instead of function calls are used? I.e.

+=

instead of

.add()

in

instead of

.contains()

etc? So far I wasn't able to find one.

gammax

02/09/2021, 7:35 PM

x-posting from #multiplatform here: https://kotlinlang.slack.com/archives/C3PQML5NU/p1612899305397200

❤️ 3

Title

gammax

02/09/2021, 7:35 PM

x-posting from #multiplatform here: https://kotlinlang.slack.com/archives/C3PQML5NU/p1612899305397200

❤️ 3

chao

02/09/2021, 8:01 PM

Was

<https://github.com/Kotlin/kmm-sample>

used to evaluate the PR? I can try with the official sample first

gammax

02/09/2021, 8:01 PM

Oh that would be great 👍

I created a sample using the IntelliJ Project Template

chao

02/09/2021, 8:02 PM

We can even try adding detekt to the sample project :)

I recently found that Detekt is applied in the IntelliJ Plugin sample project

:kotlin-intensifies: 2

gammax

02/09/2021, 8:03 PM

Oh really?

chao

02/09/2021, 8:03 PM

https://github.com/JetBrains/intellij-platform-plugin-template/blob/main/detekt-config.yml

Brais Gabin

02/09/2021, 8:07 PM

Nice!!

seb

02/10/2021, 8:40 AM

Maybe @Sebastian Aigner can help with at least some of this 🙂

gammax

02/10/2021, 8:41 AM

That would be great 🙏

chao

02/11/2021, 11:16 PM

It looks like Kotlin official documentation got an upgrade https://kotlinlang.org/docs/mpp-share-on-platforms.html

gammax

02/11/2021, 11:18 PM

You mean #docs-revamped?

chao

02/11/2021, 11:23 PM

Indeed! Didn’t know there was an announcement in that channel

View count: 3