https://kotlinlang.org logo
Channels
Powered by
#eap
  • y

    yole

    02/09/2016, 4:08 PM
    no library updates should be needed
  • a

    abreslav

    02/09/2016, 4:51 PM
    But trying it out on your code would be appreciated simple smile
  • m

    mplatvoet

    02/09/2016, 7:37 PM
    No problems here, everything works. For libraries depending on Kovenant it also can be found on https://bintray.com/mplatvoet/komponents
  • i

    izorin

    02/09/2016, 8:42 PM
    @izorin has left the channel
  • a

    apatrida

    02/09/2016, 8:54 PM
    Jackson-kotlin module compile breaks due to KotlinClass being removed (this was deprecated? didn’t have warning on reference to class before)
  • a

    apatrida

    02/09/2016, 8:55 PM
    so Kotlin classes no longer have this marker annotation
  • a

    apatrida

    02/09/2016, 8:55 PM
    so the best way to check if it is a Kotlin class is to try and get the KClass?
  • a

    apatrida

    02/09/2016, 8:58 PM
    @orangy, @yole, @abreslav … I used it so that I never interfered with decisions made for non Kotlin classes
  • o

    orangy

    02/09/2016, 9:01 PM
    Use KotlinMetadata
  • a

    apatrida

    02/09/2016, 9:02 PM
    from where do I import it
  • v

    vmironov

    02/09/2016, 9:02 PM
    which is internal 😞
  • a

    apatrida

    02/09/2016, 9:02 PM
    which is why it isn’t found when trying to import it
  • v

    vmironov

    02/09/2016, 9:02 PM
    because it is 
    kotlin.Metadata
  • a

    apatrida

    02/09/2016, 9:03 PM
    plan B?
  • a

    apatrida

    02/09/2016, 9:03 PM
    I could check if class has .kotlin.primaryConstructor, or if any constructors can be converted to kotlinFunction
  • a

    apatrida

    02/09/2016, 9:03 PM
    (is true for all primary constructors?)
  • a

    apatrida

    02/09/2016, 9:16 PM
    no, not a good test.
  • a

    apatrida

    02/09/2016, 9:17 PM
    can’t check parameter names on kotlinFunction either because it now seems to imagine names (
    arg0
    for HashMap constructor from its kotlinFunction.parameters)
  • a

    apatrida

    02/09/2016, 9:20 PM
    I can check it the same way that reflection-lite does
  • a

    apatrida

    02/09/2016, 9:20 PM
  • a

    apatrida

    02/09/2016, 9:20 PM
    Copy code
    private val metadataFqName = "kotlin.Metadata"

fun Class<*>.isKotlinClass(): Boolean = this.declaredConstructors.any {
    this.declaredAnnotations.singleOrNull { it.annotationClass.java.name == metadataFqName } != null
}
  • a

    apatrida

    02/09/2016, 9:40 PM
    Jackson Kotlin module breaks with 1050 when used with classes compiled with 1050, need new build: Jackson Kotlin Module 
    2.5.5-RC-1050
    , 
    2.6.5-RC-1050
    , 
    2.7.0-RC-1050
    , 
    2.7.1-RC-1050
    Injekt 
    0.13.0-RC-1050
    Klutter 
    0.14.0-RC-1050
    Kovert 
    0.11.0-RC-1050
    Add this repo to your builds:
    Copy code
    repositories {
    maven {
        url  "<http://dl.bintray.com/jaysonminard/kohesive>" 
    }
}
    (will pin this chat message after update for libraries that I have using the Kotlin module, since it is a breaking issue people should be aware of)
  • a

    apatrida

    02/09/2016, 9:54 PM
    something now seems to cause large stalls after some project changes, focus change to the IDE since the plugin updated to 1050. Using one IDEA 16 EAP back from current, will udpate to the Feb 2 release
  • a

    apatrida

    02/09/2016, 9:55 PM
    could be gradle related too, not Kotlin, a refresh of Klutter with Gradle under IDEA causes it to freeze / lockup and require force quit. But with other projects I was just getting long stalls on focus change, maybe was after gradle refresh too, not sure.
  • a

    andrewoma

    02/10/2016, 12:51 AM
    kwery
    and 
    kommon
    pass their test suites without modification on 1050
  • a

    abreslav

    02/10/2016, 6:09 AM
    @apatrida: Did it work out for you with 
    kotlin.Metadata
    ?
  • a

    apatrida

    02/10/2016, 10:43 AM
    @abreslav: yes, I used the same detection approach as kotlin-reflect-lite. People will need to upgrade the module to work with 1050 or later compiled code. The new verison is backwards and forward compatible.
  • a

    apatrida

    02/10/2016, 10:44 AM
    and the error might be difficult to interpret for users that encounter it. Will be a class not found exception for 
    KotlinClass
    , I’d imagine.
  • a

    apatrida

    02/10/2016, 10:46 AM
    So 
    KotlinClass
    never passed through 
    @Deprecated
    because it is internal? (I view all warnings before releases and don’t remember seeing it). I ask to see if I missed something along the way, not because it matters going forward. A small bump for some users.
  • a

    apatrida

    02/10/2016, 1:50 PM
    Compiler crash for 1050 (probably not new), https://youtrack.jetbrains.com/issue/KT-11000
1...929394...106Latest