feels wrong and clumsy

I was trying a single fun that returns a Pair but I couldn't get the syntax inside my secondary constructor right

Is faking a constructor like this considered hacky?

fun Foo(stringValue: String): Foo {
  // .. do work and return foo
}

class Foo(val first: Int, val second: Int) {
    init {
        if (first !in 1..10) {
            throw IllegalArgumentException("first must be between 1 and 10")
        }
        if (second !in 22..33) {
            throw IllegalArgumentException("second must be between 22 and 33")
        }
    }
}

looks like a normal factory method to me

It is ok. stdlib uses it

so this would be the recommended way to go about it?

Yes. It is better than other ways

feels cleaner to me than trying to jam everything into your call to the primary constructor

if they are in the same module I usually put things like that in the companion object of the class so that the name isn’t as much of an override

so you would have like

fun fromString(stringValue: String): Foo

that gets called as

Foo.fromString(it)

thanks guys 👍

Hey guys, I'm struggling a bit to write a proper singleton that takes in parameters

Specifically, I'm trying to create a singleton class that takes an Android context and every solution I run into feels hacked together

If anyone has an example of a properly configured singleton that takes in parameters I'd love to see it

You want to construct a singleton with some parameters? That's always going to be hacked together, because you're not supposed to be able to construct them.

construct might be the wrong word

I want a singleton that holds a reference to a database, which is constructed with a context (which needs to be passed in)

use your di framework to manage the instance? dagger2 is really good at managing and initializing singletons

sounds like you want a dependency injection framework 😛

Yeah that's the actual answer that I'm avoiding 😛

hack away

Why does it need to be a singleton actually?

Anything that has parameters is not truly a singleton

the creation of the database object is marked as expensive in its documentation

hmm

use

by lazy

I need the passed in parameter to be available

Yeah, but what you are doing here is static dependencies, this is terrible for testing...

and place all expensive operations in that block

i need the parameter to be available though