kotlinlang #gradle

1.1.0 Gradle Kotlin DSL 1.1.0 Release Notes Gradle Kotlin DSL 1.1.0 brings Kotlin 1.3.11, support for Kotlin lambdas in the Gradle APIs, multiple fixes and enhancements for a better behavior in IntelliJ script dependency resolution, bug fixes in the kotlin-dsl plugin for build authors, selected type-safe accessors additions and better build-cache support. In order to benefit from the best user experience, please update IntelliJ IDEA to 2018.3.1, Android Studio to 3.2.1 and their Kotlin Plugin to...

:gradle: 4

:kotlin-flag: 4

🚀 2

christophsturm

12/13/2018, 9:04 AM

it seems in gradle 5.0 a implementation depenendency does not force the same version also in the test classpath, what do in need to do to have the same version in tests and production code?

davidasync

12/13/2018, 2:53 PM

Hello, Anyone know benefit using shadowJar rather than using gradle application plugin to create single executable jar?

xenoterracide

12/14/2018, 5:30 AM

the kotlin plugin for gradle jvm, how do I apply it by class name? I have a java based plugin that I use to manage my other plugins,

project.getPluginManager().apply( kotlin("jvm") );

what do I replace

kotlin("jvm")

with?

xenoterracide

12/15/2018, 1:51 PM

interface Identified<ID extends Serializable> : Persistable<ID> {

    @JsonIgnore
    override fun boolean isNew() {
        return this.getId() == null;
    }
    
    fun sameIdAs( Identified<ID> that ) : Boolean {
        return Objects.equals( this.getId(), that.getId() );
    }
}

what's wrong with the generic definition

dave08

12/17/2018, 10:56 AM

Maybe this is a better place for this question? https://kotlinlang.slack.com/archives/C0B8M7BUY/p1544967850333000

ursus

12/17/2018, 10:42 PM

How do I apply

dataBinding {
   enabled = true
}

android { }

lambda in every module from one place?

Robert

12/18/2018, 8:53 AM

Do I need to provide any further information? Or should I add a bounty? I've been trying forever, but maybe it just won't work

sdeleuze

12/18/2018, 4:28 PM

Hey, does anybody know how to access to

StandardJavadocDocletOptions.links

from

tasks.withType<Javadoc> { }

to specify external Javadoc URL with Kotlin DSL?

ursus

12/18/2018, 5:15 PM

Hi, Ive noticed people not specifing

buildToolsVersion

anymore, any reason for this? Build seems to work without it, but dont I get some randomly changing dependency?

ursus

12/18/2018, 5:35 PM

One more: If I have multiple modules, are multithreaded builds enabled by default? I always thought so, because the tasks interleave during build. But now Ive tried org.gradle.parallel=true, and get 30% speedup, is this parallel a different thing?

ursus

12/18/2018, 5:44 PM

One one more: org.gradle.caching=true, how is this different from compilation avoidance you get from not touching a module in multimodule setup?

ursus

12/18/2018, 5:55 PM

Btw is there something I can see what gradle.properties flags are on by default?

ursus

12/18/2018, 6:16 PM

Last one: In some projects I see people putting modules inside a folder, lets say "features". And then in settings.gradle they have include ":features:feature1", how can this work? I thought ":" meant a module, and looking at file system its just a folder (and therefore in my mind should use the projectDir = new File (..), no?

Robert

12/18/2018, 7:30 PM

Anyone has a clue what this even means?

protoc { 
         ^ Type mismatch: inferred type is () -> Unit but Closure<(raw) Any!>! was expected`

Raw? Any? protoc looks like this:

public void protoc(Closure configureClosure) {

ursus

12/20/2018, 12:43 AM

Guys, in multimodule setup & Dagger, if my AppComponent is created in :app module (and it includes all modules from all modules that wanna be app scoped) so lets say in :core I have NetModule which creates okhttp & retrofit & moshi (edited) now I need to include okhttp and retrofit in :app build.gradle, (obvlously you can see Id have to do that for all such dependencies) which is kind of silly because :app build gradle will be then replicating union of every 3rd party dependency so is

api project(:core)

the solution here? Id like to avoid that or, rather, should I remove `@Provides`˛from

fun okhttp()

fun retrofit()

methods and have only my final

ApiClient

@Provides

? which however then muddies up the params of the dependency which are before more explicit like:

@Singleton @Provides fun apiClient(api: Api): ApiClient {

(edited) to

@Singleton @Provides fun apiClient(context: Context): ApiClient {
        val okHttpClient = okHttpClient(context)
        val moshi = moshi()
        val retrofit = retrofit(okHttpClient, moshi)
        val api = api(retrofit)
        return ApiClient(api)
    }

nikolaymetchev

12/21/2018, 2:08 PM

Any chance of adding multiplatform-project examples to kotlin-gradle-dsl? e.g. DSL version of this: https://kotlinlang.org/docs/reference/building-mpp-with-gradle.html

➕ 2

x80486

12/22/2018, 10:54 PM

🤔 ...why in this world they did that?!

Lucas

12/23/2018, 9:41 PM

How can we split a huge

build.gradle.kts

script into multiple short scripts that configure plugins and tasks? Do

buildSrc

can help while https://github.com/gradle/kotlin-dsl/issues/424 and https://github.com/gradle/kotlin-dsl/issues/427 don't get fixed?

dector

12/28/2018, 12:00 AM

Hi. I'm declaring custom task with

tasks.register("named") {}

build.gradle.kts

. Can I get access to

WorkerExecutor

somehow?

bjonnh

12/30/2018, 2:13 AM

does anybody has a working example of a build.gradle.kts for a library to be published on bintray?

jlleitschuh

01/03/2019, 9:23 PM

Anyone got any ideas what's going on here and how to call

fromPresets

from Kotlin? https://github.com/JetBrains/kotlin/blob/8cec50e6e2b2fb268160144bac1bd9ca40bfafb5/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/KotlinMultiplatformPlugin.kt#L63

ghedeon

01/06/2019, 9:18 PM

Just migrated my pet project to dsl, so far so good. Glad to be in a club 😉 . I keep my dependencies in a separate file in

buildSrc

(good explanation: https://caster.io/lessons/gradle-dependency-management-using-kotlin-and-buildsrc-for-buildgradle-autocomplete-in-android-studio). Obviously, all the checks for updates are gone. How do you deal with it? Any custom plugins that tackle this inconvenience?

jmfayard

01/07/2019, 5:33 AM

Anyone has tried this? https://github.com/bernaferrari/GradleKotlinConverter

zjuhasz

01/09/2019, 6:30 AM

Anyone know how to do this in an Android project with the Kotlin DSL?

sourceSets {
        main.java.srcDirs += 'src/main/kotlin'
        test.java.srcDirs += 'src/test/kotlin'
    }

ikej

01/09/2019, 10:42 AM

I like the provider properties, but it would be really cool if Kotlin supported an assignment operator, so you could write

jar {
    archiveBaseName = "myJar"
}

instead of the

jar {
    archiveBaseName.set("myJar")
}

that is required since Gradle 5.1.

Slackbot

01/12/2019, 6:34 AM

This message was deleted.

Slackbot

01/12/2019, 7:36 PM

This message was deleted.

jrgonzalez

01/12/2019, 10:37 PM

Hi, I am trying to migrate a Gradle Groovy DSL to Kotlin DSL and I am trying to declare dependencies in buildSrc in a way similar to this: https://proandroiddev.com/gradle-dependency-management-with-kotlin-94eed4df9a28). The problem is that I have some dependencies that are not just the simple artifact and version and need some extra configuration. On the Groovy DSL I used code like this:

dep = dependencies.create('com.squareup.retrofit2:converter-simplexml:' + constants.versions.retrofit) {
    // We need to exclude dependencies which are already provided by the Android platform
    exclude module: 'stax-api'
    exclude module: 'stax'
    exclude module: 'xpp3'
  }

But I can't figure out how to convert that to Kotlin DSL and I don't even have access to the "dependencies.create" method on the buildSrc object where I am declaring the dependencies. Is it possible to define a dependency with exclusions like that outside a DependencyHandler scope? Is there a standalone constructor / builder for dependencies that is not an extension method only available at specific places?

Title

jrgonzalez

01/12/2019, 10:37 PM

dep = dependencies.create('com.squareup.retrofit2:converter-simplexml:' + constants.versions.retrofit) {
    // We need to exclude dependencies which are already provided by the Android platform
    exclude module: 'stax-api'
    exclude module: 'stax'
    exclude module: 'xpp3'
  }

gildor

01/12/2019, 10:52 PM

In this case you have not just version, but config snippet also you need dependencies object to do that So possible way just extract it to extension function for dependencies and apply where you need this

But I believe you need this only if you use it multiple times in different modules, otherwise easier just define in it on place

jrgonzalez

01/12/2019, 10:56 PM

Yes, I want it for multi-module projects to declare dependencies with its configuration only once. The problem with the extension function would be that I can not declare it on a big Dependencies object and access it like:

Dependencies.retrofit2ConverterSimpleXML

as the ones that I have with no configuration. Also, don't know how to do the configuration like in Groovy.

gildor

01/12/2019, 10:57 PM

Problem that you need project instance to create dependency

So or it should be extension function, or retrofit2ConverterSimpleXML must be function, not a property

And you pass DependencyHandler or Project instance, you just cannot resolve it statically, you need instance of DependencyHandler to create dependency

jrgonzalez

01/12/2019, 10:58 PM

it does not seem to work if a declare it as

fun DependencyHandler.retrofit2ConverterSimpleXML()

inside the Dependencies object

gildor

01/12/2019, 10:59 PM

Why?

jrgonzalez

01/12/2019, 11:02 PM

If I try to autocomplete in a line like:

implementation(Dependencies.)

I don't get the function appearing at all

neither it works as

implementation(Dependencies.retrofit2ConverterSimpleXML())

or offers anything to import as

implementation(retrofit2ConverterSimpleXML())

gildor

01/12/2019, 11:06 PM

Maybe just some tooling problem, if you have function in buildSrc it must be available on you build.gradle

jrgonzalez

01/12/2019, 11:08 PM

yeah, after several tries now I got the last one

implementation(retrofit2ConverterSimpleXML())

to offer to import it as

import Dependencies.retrofit2ConverterSimpleXML

but that is not ideal either cause I lose autocompletion, so I have to look them up on the object manually and also to add imports, which the other dependencies do not need

Why is a project / DependencyHandler needed for creating a dependency when it is not used on creation?

shouldn't it just be a simple object / model?

gildor

01/12/2019, 11:10 PM

Apparently it used. create is method of DependencyHandler

You shouldn't import Dependencies, not sure what is exactly you problem. If your Dependencies object uses default package it just should work, same for any top level extension

jrgonzalez

01/12/2019, 11:12 PM

yeah, I saw that, but it may be just a convenience extension and it could be possible to create it in some other way that is not scoped to DependencyHandler, but I haven't found any doc about that

gildor

01/12/2019, 11:12 PM

If you have:

object Dependencies {
  fun retrofitSimpleXml(dep: DependencyHandler)
}

Than I don't see any problem

jrgonzalez

01/12/2019, 11:12 PM

Also the config does not work easily, it expects a Closure<Any>

maybe doing:

closureOf<ExternalModuleDependency> { }

? 😅

oh, so no extension function but a function receiving the dependency handler?

How that would be called?:

Dependencies.retrofitSimpleXml(this)

gildor

01/12/2019, 11:14 PM

Yes

Extension function is just an option, it's easier to use, but you right, it's not related anymore to your Dependencies object

Also the config does not work easily, it expects a Closure<Any>

Just create dependency, cast it to ExternalDependency and use apply to configure

jrgonzalez

01/12/2019, 11:19 PM

This seems to compile:

fun retrofit2ConverterSimpleXML(dependencyHandler: DependencyHandler): Dependency =
    dependencyHandler.create(
        "com.squareup.retrofit2:converter:-simplexml${Versions.retrofit}", closureOf<ExternalModuleDependency> {
      exclude(module = "stax-api")
      exclude(module = "stax")
      exclude(module = "xpp3")
    })

but not on usage 😅

does not accept this later:

implementation(Dependencies.retrofitConverterSimplexml(this))

` ^ Type mismatch: inferred type is Dependency? but Any was expected``

gildor

01/12/2019, 11:21 PM

Your dependency is nullable

Not sure why

Looks that your code explicitly defines it as non nullable

jrgonzalez

01/12/2019, 11:23 PM

also tried this based on what you said:

fun retrofit2ConverterSimpleXML(dependencyHandler: DependencyHandler): Dependency =
    (dependencyHandler.create(
        "com.squareup.retrofit2:converter:-simplexml${Versions.retrofit}"
    ) as ExternalDependency).apply {
      exclude(module = "stax-api")
      exclude(module = "stax")
      exclude(module = "xpp3")
    }

gildor

01/12/2019, 11:23 PM

It's the same

jrgonzalez

01/12/2019, 11:23 PM

it also compiles that part, but fails with same error on implementation reference

gildor

01/12/2019, 11:23 PM

Check why dependency is nullable

It just doesn't allow to pass nullable

But I don't see the reason

Just for test add !! To usage

jrgonzalez

01/12/2019, 11:24 PM

it seems not that, but that implementation expects either any or 2 parameters one of which is a Dependency?

so it is going to

fun DependencyHandler.`implementation`(dependencyNotation: Any): Dependency?

instead of:

fun <T : ModuleDependency> DependencyHandler.`implementation`(
    dependency: T,
    dependencyConfiguration: T.() -> Unit
): T

gildor

01/12/2019, 11:25 PM

Ah, I see

Yeah, type safe accessor generated oy for string

You have to use

add("implementation", dependency)

Maybe you can solve this in another way and just globally exclude those dependencies for all modules instead attaching this to your dependency definition

jrgonzalez

01/12/2019, 11:27 PM

same complain 😅

gildor

01/12/2019, 11:28 PM

Sorry, I confused

Where is type mismatch?

jrgonzalez

01/12/2019, 11:29 PM

that one also expects a Any

not a Dependency

gildor

01/12/2019, 11:30 PM

Any is super type of Dependency

So it's fine

Your problem with nullability

Not with class

jrgonzalez

01/12/2019, 11:30 PM

I don't know how to get it to use this one:

fun <T : ModuleDependency> DependencyHandler.`implementation`(
    dependency: T,
    dependencyConfiguration: T.() -> Unit
): T

seem that is the one that allows to pass a Dependency as the created one

gildor

01/12/2019, 11:31 PM

Pass empty lambda

jrgonzalez

01/12/2019, 11:31 PM

but since it expects a second parameter

gildor

01/12/2019, 11:31 PM

Second param just an empty lambda

implementation(dependency, {})

jrgonzalez

01/12/2019, 11:32 PM

like this?:

implementation(Dependencies.retrofitConverterSimplexml(this), {})

also tried, but it then gives this different error:

implementation(Dependencies.retrofitConverterSimplexml(this), {})
              ^ None of the following functions can be called with the arguments supplied: 
                  public fun <T : Dependency> DependencyHandler.implementation(dependency: TypeVariable(T), action: Action<TypeVariable(T)>): TypeVariable(T) defined in org.gradle.kotlin.dsl
                  public fun DependencyHandler.implementation(group: String, name: String, version: String? = ..., configuration: String? = ..., classifier: String? = ..., ext: String? = ..., dependencyConfiguration: Action<ExternalModuleDependency>? = ...): ExternalModuleDependency defined in org.gradle.kotlin.dsl
                  public fun DependencyHandler.implementation(dependencyNotation: String, dependencyConfiguration: Action<ExternalModuleDependency>): ExternalModuleDependency defined in org.gradle.kotlin.dsl

gildor

01/12/2019, 11:35 PM

I'm away from my PC and IDE, just check types that possible to pass to type safe accessors and to dynamic add setters, one of them should allow pass Dependency

Probably your method should return ExternalDependency, not sure

jrgonzalez

01/12/2019, 11:36 PM

ok, thanks!, it has been really helpful, at least looks there is some path this way 🙂. I will keep tinkering..

gildor

01/12/2019, 11:36 PM

Ahh, correct, I see it now in generic, function that you showed above, only for module dependencies, not for external dependency

I still think that global configuration resolution is just better solution

jrgonzalez

01/12/2019, 11:36 PM

but the odd thing is that with Groovy it works

gildor

01/12/2019, 11:37 PM

Exclude those dependencies from all modules in allproject block

This also will work

jrgonzalez

01/12/2019, 11:37 PM

I mean, I can pass a dependency created with the create() method to implementation() and it just takes it

gildor

01/12/2019, 11:37 PM

Because groovy dynamic, try to use

add()

, it probably also will work

It should have compatible overload for this case

But usage of not type safe

add

Imo just destroying all the idea of type safe dependency definition

So global configuration resolution strategy imo the best, keeps your dependency definition and usage simple and obvious

Also solves problem of transitive dependencies which also can bring excluded dependencies

jrgonzalez

01/12/2019, 11:41 PM

yes, it kinda also feels like if somehow the Groovy variant of implementation method allowing what I did before is not accesible through the Kotlin DSL

there are some calls of add with an ExternalModuleDependency but it requires like 3 parameters 😅

oh, not even that, is not an ExternalModuleDependency but its configuration

so I guess, yes, I should go the global route

this also seems to work:

implementation(Dependencies.retrofitConverterSimplexml) {
    exclude(module = "stax-api")
    exclude(module = "stax")
    exclude(module = "xpp3")
  }

which would mean basic unconfigured dependency declaration and duplicated config block per usage

gildor

01/12/2019, 11:53 PM

add("implementation", ...) is the same as "implementation"(...), But in both cases you lose type safety

jrgonzalez

01/12/2019, 11:56 PM

yes, deleted cause I think it was wrong, was trying to trick it to use the groovy version of implementation that supports a dependency as single parameter 😅

it seems to accept several things, but I can not fully compile the project yet to be sure they are valid and doing what I intend. This compiles too:

withGroovyBuilder {   "implementation(${Dependencies.retrofit2ConverterSimpleXML(this@dependencies)})"
  }

but I am only guessing there and it is type unsafe as soon as you add groovy in

The global exclude is also a bit tricky, may work for this one, but on others I am excluding for different reasons, not all versions of a module but only those coming transitively on a specific dependency due to conflicts. The duplicated config section may be better for now to not have several different ways to do the same

Also, luckily I don't have many that need configuration

and it even seems some of those issues are fixed since last time I checked, so maybe I can remove a few more customizations

Thanks for all your help, 1am here, time to sleep 😄

gildor

01/13/2019, 1:19 AM

You don't need groovy builder for this, I will check later today

I agree, global exclude may be not so straight forward, but usually it's more stable and clean solution. To solve version conflict you also can use global configuration resolution, I would still take a look on this solution

jrgonzalez

01/13/2019, 9:36 AM

Also, there is another type of configuration I have on some dependencies, that require

isTransitive = true

which I am not sure if it has a global way.

gildor

01/13/2019, 9:59 AM

Why is your use case for isTransitive = true? This is default behavior of any dependency

jrgonzalez

01/13/2019, 10:30 AM

It fails without it on an old Twitter dependency I have not had time to remove since they discontinued it. I will post when I'm back at home in a bit, I have no idea why it fails without the

isTransitive

either.

I have also seen instructions for several libs that say to include it like that so there may be some differences. Others like glide had it and then seemingly removed the requirement but I'm not sure what changed.

gildor

01/13/2019, 10:38 AM

Could you show this dependency?

jrgonzalez

01/13/2019, 11:06 AM

This is it on "normal" syntax:

implementation("com.twitter.sdk.android:tweet-composer:3.3.0@aar") {
    isTransitive = true
  }

without the isTransitive my build fails with unknown

com.twitter.sdk.android.core

package

gildor

01/13/2019, 11:17 AM

Just remove

<@U27HSU2U9>

and isTransitive

Those guys from Twitter don't know how to use dependencies probably. Because explicit declaration of resources extension obviously disables transitive dependencies (because you cannot get transitive dependencies without pom file)

👌 1

jrgonzalez

01/13/2019, 11:40 AM

Oh, ok, so maybe the others I have with

@aar

also should get rid of it. I thought it was something to distinguish aar vs jar or something like that.

seems to compile now with just

implementation(Dependencies.twitterSdkTweetComposer)

🎉

gildor

01/14/2019, 5:49 AM

👍

Really not sure how they decided to use such config, maybe some super old legacy when they don't have pom, only raw aar. Funny, that Crashlytics used the same strange config in their docs when they owned by Twitter, now Google acquired them and this thing moved also to Firebase docs for Crashlytics 😬

View count: 2