once you get to q-values and levels and stuff it all starts to get a little gnarly,,,

Hello folks, Mr Dave has written a new PR for fun

its maybe a bit weird so im here to wave my hands until you merge it

I'd call it more ... esoteric, rather than weird.

Very outre, very recherche.

(well, pretty out there for checkboxes anyway)

Does

Http4K

uses

coroutines

? Is it

Asynchronous

?

@Narayan Iyer it does not

currently

. It is

blocking

and

currently

outperforms several asynchronous frameworks in the tech empower benchmarks.

😂

😄 ... just curious ... any plans to include

asynchronous

?

We're looking at it.

We need to work or a way to not ruin the API in the meantime.

I understand

@Narayan Iyer the key thing here is to have useful support for other coroutine-based things - for instance DB drivers and http clients to seamlessly interact with. Without those in place, the scope for really taking advantage of the tech is limited - and often results in really ugly APIs where the 2 models meet. Having previously worked on an async web framework (the finagle-based fintrospect), this stuff turns out to be really significant.

tldr; it'll probably come. But experience says: try not to get too carried away because async stuff is actually quite tricky to get right. 🙂

Will http4k be updating to kotlin 1.3 soon?

I'm literally doing it now.

Woo!

MERGE THE PULL REQUEST

(please 😄)

@gypsydave5 3.97.0 on it's way.

(but you owe me a pint)

fair

Hi, is there any example of how to send zipkin traces to a zipkin server?

@Xavier Hanin Unfortunately not at the moment.

I'm actually looking to put together a full example of this stuff, with events (structured logging) , tracing, lens-driven config, health checks, perf metrics etc.

It should be pretty simple to do sending to Zipkin though. Use one of the open tracing clients and then use the RequestTracing filter to feed it.

Ok, such an example would be great! I’ll try to do something simple at the moment.

Would you consider it safe to store per-request data in ThreadLocal storage? As an example, I have an endpoint that receives an auth token as part of the request. I'm currently passing this token along with various other parameters to my business logic, which again passes the token along to the external service client it ends up calling. Below is a crude diagram of what I'm trying to describe. Bracketed items are part of my system:

{browser} ->  [Endpoint] -> [BusinessLogic] -> [ExternalServiceClient] -> {external server}

Having all the methods in [businessLogic] and [ExternalServiceClient] take an additional parameter

token:String

, feels is pretty un-elegant, so I was considering options to be able to set this token "globally" during the start of a request, and then clean it up afterwards. ThreadLocal came to mind, but I'm not sure if my assumption holds 😛 Any suggestions are welcome!