Channels
#intellij
- p
pakoito
11/21/2017, 4:49 PMWe're seeing more and more people who're getting bitten by the interaction between inlined functions + return, specially those from Java background - p
pakoito
11/21/2017, 4:49 PM@pakoito uploaded a file: Untitled - p
pakoito
11/21/2017, 4:49 PMthis doesn't feel unnatural to them, as they're not used to if as an expression - p
pakoito
11/21/2017, 4:50 PMit'd be great to have a warning at IDE level to flag inlined higher order functions (HOF) with return in their blocks - p
pakoito
11/21/2017, 4:51 PMat shallow level, no need to traverse the callgraph if they are function references, or inlines inside inlines - k
karelpeeters
11/21/2017, 4:51 PMOne problem with such a warning is that it isn't always wrong to do this. - p
pakoito
11/21/2017, 4:52 PMyeah, that's why it can be a visual indicator instead of an error 😄 - p
pakoito
11/21/2017, 4:52 PMsame as with tailrec functions without tailrec - p
pakoito
11/21/2017, 4:53 PMbut the expectation is that if you're calling a HOF you should return from its scope, rather than the enclosing one - p
pakoito
11/21/2017, 4:53 PMelse you're trying to be too smart about it 😄 - k
karelpeeters
11/21/2017, 4:56 PMWell
on a function that doesn't actually have any tail recursion is always a mistake, so it deserves a warning. Consider this code though:tailrecCopy code
Thefun foo(list: List<Int>) { list.forEach { if(it == 0) return println(it) } println("done") }
here isn't wrong, so it shouldn't get a warning. How do you separate them?return - p
pakoito
11/21/2017, 5:02 PMbroken underline under return. On hover "Warning: this return exits the enclosing function foo, instead of forEach". A flag at IDE level to disable them. - c
Czar
11/21/2017, 5:06 PMVisual indicator is not a bad idea for this, kinda how variables captured in a closure are shown. - c
christophsturm
11/23/2017, 2:11 PMis it a known problem that idea does no longer inlines variables? i select inline and nothing happens. - y
yole
11/23/2017, 3:17 PMis there an exception when you do this? - c
christophsturm
11/24/2017, 10:58 AMno it does absolutely nothing - c
christophsturm
11/24/2017, 12:33 PMit offers me a quick fix to inline it, and that works - c
christophsturm
11/24/2017, 12:34 PMno error in the error reporter and no entries in idea.log - c
christophsturm
11/24/2017, 12:35 PMbut only on my mac, on my ubuntu desktop the same works - y
yole
11/24/2017, 1:12 PM^ @mglukhikh - c
chansek
11/25/2017, 5:12 AM@chansek uploaded a file: Kotlin plugin gets disabled - c
chansek
11/25/2017, 5:12 AMAny help would be appreciated. - j
jkbbwr
11/25/2017, 3:47 PMCopy codejakob@devtank~> java -version java version "9.0.1" Java(TM) SE Runtime Environment (build 9.0.1+11) Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode) jakob@devtank~> - k
keturn
11/25/2017, 6:19 PMI updated IDEA 2017.3, and when I load my project it saysOutdated Kotlin Runtime
Your version of Kotlin runtime in 'Gradle: org.jetbrains.kotlinkotlin stdlib1.1.51' library is 1.1.51, while plugin version is 1.2.0-rc-39-IJ2017.3-1.
Runtime library should be updated to avoid compatibility problems.
- k
keturn
11/25/2017, 6:21 PMso I updated the version in my gradle file to 1.2.0-rc-39. - k
keturn
11/25/2017, 6:21 PMI'm not up on how versions in dependency resolution get resolved, is it necessary for that
to match exactly?-rc-39 - k
keturn
11/25/2017, 6:22 PMbecause after that I getCould not find org.jetbrains.kotlinkotlin gradle plugin1.2.0-rc-39.
- k
keturn
11/25/2017, 6:39 PMoh, I see, had to add the kotlin-eap-1.2 repository, and make sure I was adding it to the correct repositories section - k
keturn
11/25/2017, 6:46 PMit also looks like if this version of IDEA has me on kotlin-1.2 anyway, I might as well switch the kotlin plugin updates channel - w
wineluis
11/26/2017, 6:31 PMis it normal for intellij to be slow with kotlin?