https://kotlinlang.org logo
Channels
Powered by
#kontributors
  • z

    zeesh49

    09/03/2016, 7:56 AM
    despite jar file exists in dist folder
  • z

    zeesh49

    09/03/2016, 7:57 AM
    yes, i have compiled Kotlin successfully, but I cant run this specific test method
  • z

    zeesh49

    09/03/2016, 7:58 AM
    also, when I debugged the junit test, it turns out that the file.getAbsolutePath() result is wrong and therefore file cannot be found...
  • y

    yole

    09/03/2016, 8:20 AM
    @zeesh49 please make sure that the "Working directory" field in the run configuration settings is set to the Kotlin checkout directory
  • z

    zeesh49

    09/03/2016, 8:48 AM
    @yole thanks, its working now
  • z

    zeesh49

    09/03/2016, 8:51 AM
    @yole my approach is to run the whenTest and see how do I change the underlying grammer to add production to fix the bug
  • y

    yole

    09/03/2016, 4:14 PM
    what grammar do you want to change? the Java to Kotlin converter does not have any grammar
  • z

    zeesh49

    09/03/2016, 7:25 PM
    My mistake, Ill look into the converter to fix.
  • s

    semoro

    09/03/2016, 11:53 PM
    @User uploaded a file:

    Pasted image at 2016 09 04 02 50 AM▾

    and commented: @yole Because it not resolved by 
    PsiFileImpl#calcStubTree
  • u

    user

    09/04/2016, 12:29 AM
    @semoro commented on @semoro’s file

    https://kotlinlang.slack.com/files/U1PRSBLHJ/F280YE6E7/pasted_image_at_2016_09_04_02_50_am.png▾

    : After more debugging, found that problem related to Psi building process, only one KtNamedFunction get created for function foobar in both cases. In second case there should be two KtNamedFunction for it(One static with FqName="foo.Bar.foobar" and second non-static with FqName="foo.Bar.Companion.foobar")?
  • y

    yole

    09/04/2016, 7:54 AM
    no, that behavior is correct. the PSI structure corresponds to what's actually in the source file, so there should be exactly one 
    KtNamedFunction
    for the method in the companion object
  • y

    yole

    09/04/2016, 7:55 AM
    the light classes, on the other hand, are essentially built by decompiling Kotlin-generated bytecode to Java declarations, so the light declarations do not always exactly correspond to the PSI
  • y

    yole

    09/04/2016, 7:55 AM
    you can have multiple `KtLightElement`'s with a single 
    KtElement
    as an origin
  • s

    semoro

    09/04/2016, 10:26 AM
    @yole Aha, I found problem 
    LightClassUtil#getPsiMethodWrappers
    not checking methods of parent if resolving companion object
  • y

    yole

    09/05/2016, 9:34 AM
    @semoro yes, looks like this would be the correct fix
  • s

    semoro

    09/05/2016, 11:21 AM
    @yole Fixed this, but found some strange logic
    Copy code
    package foo

object Bar {
    companion object {
        @JvmField var foobar = "foobar"
    }
}
    Copy code
    import static foo.Bar.Companion.foobar;

public class Foo {
    public void main()
    {
        foobar<caret> = "barfoo";
    }
}
    Why we should import foo.Bar.Companion.foobar, not a foo.Bar.foobar? Cause field in this case located in Companion?
  • y

    yole

    09/05/2016, 11:22 AM
    yes
  • s

    semoro

    09/05/2016, 11:24 AM
    @yole, ok, also another question, assume i have
    Copy code
    object Bar {
  @JvmField var foobar = "foobar"
}
    Why this automatically makes foobar static?
  • y

    yole

    09/05/2016, 11:25 AM
    because it makes no sense to have a non-static field in a 
    object
  • y

    yole

    09/05/2016, 11:27 AM
  • s

    semoro

    09/05/2016, 11:38 AM
    @yole Fixed all problem with tests, so https://github.com/JetBrains/kotlin/pull/942 ready for review
  • y

    yole

    09/05/2016, 11:38 AM
    ok, thanks!
    😊 1
  • z

    zeesh49

    09/05/2016, 5:03 PM
    @yole: for KT-13552, what should the converted kotlin code be?
  • y

    yole

    09/05/2016, 5:20 PM
    there should be two copies of the code
  • y

    yole

    09/05/2016, 5:20 PM
    Copy code
    "fail", "busy", "error" -> return 0xFF660000.toInt()
else -> return return 0xFF660000.toInt()
  • z

    zeesh49

    09/05/2016, 6:53 PM
    @yole
  • z

    zeesh49

    09/05/2016, 6:54 PM
    @yole i executed J2K Tests JUnit configuration and 830/1600 unit tests have failed...
  • z

    zeesh49

    09/05/2016, 6:55 PM
    is this ok?
  • s

    shiraji

    09/05/2016, 8:41 PM
    is there easy way to iterate all child (including grand child) element? Oppose to 
    getStrictParentOfType
    . 
    getChildrenOfType
    does not iterate grand children element.
  • y

    yole

    09/05/2016, 9:16 PM
    @zeesh49 no, it's not. did you run 
    ant dist
    ? did you specify the working directory correctly?
1...333435...80Latest