mitch
09/12/2023, 2:16 PMsam
09/25/2023, 12:15 AMsimon.vergauwen
09/27/2023, 7:56 AMLeoColman
10/09/2023, 2:37 PMsam
10/09/2023, 3:44 PMmitch
10/19/2023, 9:21 PMEmil Kantis
10/31/2023, 11:59 AMLeoColman
11/07/2023, 6:38 PMjcthenerd
11/10/2023, 4:32 PMEmil Kantis
11/20/2023, 10:34 PMsam
11/20/2023, 10:35 PMEmil Kantis
11/20/2023, 10:47 PMjcthenerd
11/27/2023, 2:56 PMOliver.O
12/02/2023, 11:08 PM> Task :kotest-assertions:kotest-assertions-json:compileKotlinJs FAILED
e: file:///home/oliver/Repositories/open-source/Kotlin/kotest/kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/schema/parse.kt:54:44 Unresolved reference: serializer
e: file:///home/oliver/Repositories/open-source/Kotlin/kotest/kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/schema/parse.kt:58:46 Unresolved reference: serializer
e: file:///home/oliver/Repositories/open-source/Kotlin/kotest/kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/schema/parse.kt:59:36 Unresolved reference: serializer
e: file:///home/oliver/Repositories/open-source/Kotlin/kotest/kotest-assertions/kotest-assertions-json/src/commonMain/kotlin/io/kotest/assertions/json/specs.kt:34:41 Unresolved reference: serializer
LeoColman
12/05/2023, 1:58 AMLeoColman
12/05/2023, 1:58 AMLeoColman
12/05/2023, 1:58 AMAJ Alt
12/07/2023, 6:13 PMOliver.O
12/13/2023, 4:26 PMmat
12/14/2023, 6:23 PMshouldBeEqual
as reported in the #kotest channel by me (link to thread ) I believe that I have found the root cause and have made the changes to the related file.
My questions:
1. How do I run the Kotest tests (as in, what is the process I should go through to ensure that my changes have not regressed any existing tests)
2. How do I build and depend on a local version of Kotest (with the fix) so that I can check the changes in the project in which I originally found the issue?
What I've tried:
I've tried using running the tests in ShouldBeEqualTest
using both the "current file" run method, and the gutter icons, in intellij. The gutter icons do not appear, and the current file method reports that the file cannot be run.
I've tried looking in the CONTRIBUTING.md
file to see instructions, but did not see any run or test instructions there. (Link to the CONTRIBUTING file )
I've tried explicitly asking Intellij to reload the build.gradle.kts file in the project that the changed file is in. This does not do anything.
I've tried explicitly asking Intellij to build the project (CTRL+F9). This gives me the console message BUILD SUCCESSFUL in 1s
, but does not appear to do anything.Emil Kantis
12/21/2023, 9:16 PMEmil Kantis
12/21/2023, 9:17 PMOliver.O
12/23/2023, 4:18 PMjsBrowserTest
, jsNodeTest
, wasmJsBrowserTest
, but not wasmJsNodeTest
.
2. For wasmJsNodeTest
with Kotest, I'm using Kotest's own runner via DefaultSpecExecutorDelegate(defaultCoroutineDispatcherFactory, context)
, in conjunction with Kotest's TeamCity reporting, which works well.
3. I also have a solution for https://github.com/kotest/kotest/issues/3329. To fix test reporting for jsNodeTest
, we'd have to use a transformation function of the KGP-provided kotlin-test-js-runner
. While possible, this would tie us to an internal, undocumented Kotlin API.
4. Then there are nested tests, which are not currently supported on JS.
Taking this into account: Do we actually need to use an external test runner? Can't we just make Kotest use its own runners on all platforms, including JS, and drop interfacing with Mocha altogether?sam
02/01/2024, 12:49 AMEmil Kantis
02/04/2024, 5:26 PMEmil Kantis
02/19/2024, 10:12 PMEmil Kantis
02/23/2024, 9:55 PMEmil Kantis
02/24/2024, 12:22 PMsam
03/04/2024, 12:57 AMOliver.O
03/12/2024, 2:45 PMjava.lang.OutOfMemoryError: Java heap space
.
• Re-running that job was successful, but did not make the merge queue add the PR back to the queue.
• Merging had to be re-started manually with the entire PR Test running again in order to complete the merge.
Could the GH infra do better?