kotlinlang #kotlin-fuel

Join the conversation Join Slack

Channels

100daysofcode

100daysofkotlin

androidgithubprojects

cincinnati-user-group

competitive-programming

event21-community-content

java-to-kotlin-refactoring

jvm-ir-backend-feedback

kotlin-multiplatform-contest

kotlinultimatechallenge

myndocs-oauth2-server

naming

navigation-architecture-component

practical-functional-programming

proguard

prozis-android-backup

refactoring-to-kotlin

russian-kotlinasfirst

skia-wasm-interop-temp

stayhungrystayfoolish

swagger-gradle-codegen

tricity-kotlin-user-group

kotlin-fuel

joscha.alisch

12/30/2017, 5:30 PM

Very simplified example:

for (i in 0..70000) {
        “/get/$i”.httpGet().responseString { request, response, result -> 
            // Do Something
        }
    }

kittinunf

02/03/2018, 5:30 AM

I think what you are trying to do is to bundle all the Fuel call into one helper class right

Mark Gilchrist

07/01/2018, 8:22 PM

I really like the Result approach and I would like to use it, if however you all feel that this would not be an advantage I am happy not to do another pr

Mark Gilchrist

10/09/2018, 5:00 PM

I have merged master in to my branch and I can't build 😭

kittinunf

10/13/2018, 4:42 AM

looks interesting!

Nikky

10/18/2018, 9:33 AM

i think fuel-kotlinx-serialization should be renamed to fuel-serialization

Nikky

10/18/2018, 3:12 PM

well i think thats all for today, i am going to go to the #berlin usergroup meetup

sbyrne

10/19/2018, 2:24 PM

I have 2 different approaches to fix it with minimal changes, and one suggestion that would require a largeish refactor. I'll note in the ticket. (https://github.com/kittinunf/Fuel/issues/414)

Nikky

10/21/2018, 10:02 AM

or squash and merge ?

sbyrne

10/25/2018, 3:23 PM

Request

(and

Response

) are final in master.

kittinunf

10/30/2018, 2:20 AM

Shall we merge everything and do 2.0?

Nikky

10/30/2018, 3:48 AM

inline functions are well inlined, quite a lot of things might be in different .class files which jacoco currently cannot handle either

kittinunf

10/30/2018, 2:51 PM

btw i think you replied on the wrong PR lol

kittinunf

10/30/2018, 11:39 PM

But i couldn't upgrade it anyway 😿

kittinunf

10/31/2018, 3:27 PM

😢 haha sorry for the semantic version!!

Nikky

10/31/2018, 5:03 PM

works for me too.. its jsut that simetimes idea likes to swallow the whole line

kittinunf

11/05/2018, 1:27 AM

wanna see how @Derk-Jan Karrenbeld feel about it … I have been working on the replacement of novoda bintray locally

kittinunf

11/09/2018, 3:22 AM

but regarding to the version if we do 1.17 doesn’t it mean it might give a wrong impression that we don’t break anything yet we break a lot of things ?

💯 1

itnoles

11/11/2018, 2:29 AM

Derk, if they uses corountines, they don't need fuel-android at all.

itnoles

11/11/2018, 3:26 AM

How about https://github.com/kittinunf/Fuel/blob/master/fuel-android/src/main/kotlin/com/github/kittinunf/fuel/android/extension/Requests.kt

kittinunf

11/11/2018, 8:04 AM

Finally, i think it is working!!!!!! https://github.com/kittinunf/Fuel/pull/521

kittinunf

11/11/2018, 8:11 AM

@Derk-Jan Karrenbeld I will start looking at your PR, are you talking about #486?

Derk-Jan Karrenbeld

11/12/2018, 1:58 AM

Haha no, it's not. I'm on the spectrum so I don't pick up on those cues anyway lol

kittinunf

11/12/2018, 2:22 AM

then user can do whatever they like in that “debug” mode

kittinunf

11/12/2018, 2:39 AM

i am thinking about just 🔥 the java sample and java support ….

👍 1

itnoles

11/12/2018, 3:18 AM

@Derk-Jan Karrenbeld did you see AutoCloseable link?

kittinunf

11/12/2018, 3:57 AM

my DM is all about feature requests like why didn’t Fuel support this, why didn’t Fuel do that

Nikky

11/12/2018, 10:07 AM

i wish there was better .editorconfig integration.. i'd rather export to that format than deal with xml

kittinunf

11/12/2018, 3:18 PM

i think Fuel 2.0 feels entirely different …. feels like a brand new library to me

🤪 1

kittinunf

11/12/2018, 4:22 PM

please promise me your next PR will be smaller Okay?