Channels
#kotlin-fuel
- k
kittinunf
05/06/2019, 3:38 PMCopy codefun wrap(it: Throwable, response: Response = Response.error()): FuelError = when (it) { is FuelError -> it else -> FuelError(it, response = response) } - k
kittinunf
05/06/2019, 3:38 PMthen the stacktrace becomes simpler - d
Derk-Jan Karrenbeld
05/06/2019, 3:41 PM(can you also post what we currentlý have for wrap) - k
kittinunf
05/06/2019, 3:41 PMthe current implementation is - k
kittinunf
05/06/2019, 3:42 PMCopy codefun wrap(it: Throwable, response: Response = Response.error()): FuelError = when (it) { is FuelError -> BubbleFuelError(it) else -> FuelError(it, response = response) } - k
kittinunf
05/06/2019, 3:42 PMI feel like what you have done for
help a lot alreadystacktrace - d
Derk-Jan Karrenbeld
05/06/2019, 3:49 PMthen the stacktrace becomes simpler (edited)
That's right. Maybe we can put the old bubble behaviour under a flag? We'll lose the full stacktrace if we don't bubble it, but might be nice to still be able to debug it - d
Derk-Jan Karrenbeld
05/06/2019, 3:49 PMFine with removing a lot of the noise by default 😉 - i
itnoles
05/06/2019, 4:11 PM@Derk-Jan Karrenbeld ByteArrayInputStream(exception.message?.toByteArray() ?: ByteArray(0)) < null? - d
Derk-Jan Karrenbeld
05/06/2019, 4:15 PMYah, no message - d
Derk-Jan Karrenbeld
05/06/2019, 4:15 PMWe might want to use a string to bytearray that indicates it - i
itnoles
05/06/2019, 4:21 PMI found one hook method is in wrong place. - i
itnoles
05/06/2019, 6:32 PMDid we have a test for NetworkOnMainThreadException? - k
kittinunf
05/07/2019, 5:37 AMno we don’t ☝️ - k
kittinunf
05/07/2019, 12:40 PMI proposed something … - k
kittinunf
05/07/2019, 12:40 PM - k
kittinunf
05/07/2019, 12:40 PMwhat do you think about this? - d
Derk-Jan Karrenbeld
05/07/2019, 1:20 PMI think that could work - i
itnoles
05/07/2019, 2:34 PMI like how it stopped Double-Wrap - i
itnoles
05/10/2019, 11:43 PM - k
kittinunf
05/11/2019, 12:37 AMSigned up! - i
itnoles
05/12/2019, 7:37 PM@kittinunf you may have random test failure - d
Derk-Jan Karrenbeld
05/12/2019, 10:40 PM:3 - k
kittinunf
05/13/2019, 1:40 AM😅 - i
itnoles
05/13/2019, 1:41 AMdid you look into the test reports for it? - k
kittinunf
05/13/2019, 1:42 AMNot yet - i
itnoles
05/13/2019, 1:43 AMassetThat() doesn't make much sense because it hide a lot of informations - k
kittinunf
05/13/2019, 1:43 AMI will - k
kittinunf
05/13/2019, 1:43 AMWhat would be the alternative then? - i
itnoles
05/13/2019, 1:44 AMassertEquals, assertTrue, and other from junit.