https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    05/13/2019, 3:17 AM
    Okay then, let’s try to move away from it
  • k

    kittinunf

    05/13/2019, 6:45 AM
    It looks like it works now
  • k

    kittinunf

    05/13/2019, 6:45 AM
    if any of you want to approve this, we will release new version
  • i

    itnoles

    05/13/2019, 7:10 AM
    I approved it.
  • d

    Derk-Jan Karrenbeld

    05/13/2019, 9:35 AM
    Wooooh wooop
  • d

    Derk-Jan Karrenbeld

    05/13/2019, 9:35 AM
    New versions
  • k

    kittinunf

    05/13/2019, 11:10 AM
    Thanks!
  • k

    kittinunf

    05/13/2019, 11:15 AM
  • i

    itnoles

    05/16/2019, 2:51 PM
    weird, replace one file with assetTrue, more random test failure. Should it be best to replace whole testing?
  • i

    itnoles

    05/16/2019, 11:01 PM
    @Derk-Jan Karrenbeld what you think?
  • d

    Derk-Jan Karrenbeld

    05/16/2019, 11:14 PM
    Hmmm
  • d

    Derk-Jan Karrenbeld

    05/16/2019, 11:15 PM
    I will look into this properly next week. I don't quite get whý it fails, but I'll figure it out :)
  • i

    itnoles

    05/16/2019, 11:17 PM
    interruptedSemaphore.tryAcquire(5, TimeUnit.SECONDS) this one hit sometimes failure.
  • i

    itnoles

    05/19/2019, 6:02 PM
  • k

    kittinunf

    05/20/2019, 6:09 AM
    oh!
  • k

    kittinunf

    05/20/2019, 6:10 AM
    i have used 
    ?.let { }
    for null check in the past …
  • d

    Derk-Jan Karrenbeld

    05/20/2019, 12:54 PM
    I used a lot of 
    also
    in the fuel code as that article says 🙂
  • i

    itnoles

    05/20/2019, 6:49 PM

    https://cdn-images-1.medium.com/max/800/1*pLNnrvgvmG6Mdi0Yw3mdPQ.png▾

    friendly flow charts 🙂
    👍 1
  • i

    itnoles

    05/20/2019, 7:54 PM
    I am wondering about random test failure
  • i

    itnoles

    05/20/2019, 7:54 PM
    do we need to disconnect each times?
  • i

    itnoles

    05/21/2019, 5:19 AM
    I am thinking about to have httpsurlconnection to be variable, so the developer can set it as they wanted
  • i

    itnoles

    05/22/2019, 4:45 AM
    @kittinunf Fuel's implementation of httpsurlconnection is extremely limited.
  • k

    kittinunf

    05/22/2019, 4:46 AM
    surely it is not perfect, in what aspects you want to improve?
  • i

    itnoles

    05/22/2019, 4:47 AM
    make it as a some kind of function or variable for developers to pass into it.
  • k

    kittinunf

    05/22/2019, 5:10 AM
    still having hard time to imagine that
  • k

    kittinunf

    05/22/2019, 5:10 AM
    you are mentioning something like hooks?
  • i

    itnoles

    05/22/2019, 5:12 AM
    something like var sslManager: (HttpsURLConnection) -> Unit = {}
  • i

    itnoles

    05/22/2019, 5:17 AM
    would that be useful?
  • k

    kittinunf

    05/22/2019, 7:30 AM
    sound like a hook to me?
  • k

    kittinunf

    05/22/2019, 7:31 AM
    yeah, if you need the functionality, sounds useful to me
1...100101102...118Latest