https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    05/30/2019, 8:07 AM
    Then maybe in the next version, we can just return 
    val (response, result) =
    then?
  • d

    Derk-Jan Karrenbeld

    05/30/2019, 9:41 AM
    But response.request MUST always work then
  • i

    itnoles

    05/31/2019, 3:14 AM
    Pair would be interesting.
  • i

    itnoles

    05/31/2019, 3:14 AM
    Pair<Response, Result>
  • i

    itnoles

    05/31/2019, 3:41 AM
    @kittinunf did we already have Pair on RxJava?
  • k

    kittinunf

    05/31/2019, 8:53 AM
    we did?
  • k

    kittinunf

    05/31/2019, 8:53 AM
    But what’s wrong with 
    Kotlin.Pair
    though lol
  • i

    itnoles

    05/31/2019, 5:19 PM
    @kittinunf Nothing, we have to drop Triple for Pair
  • d

    Derk-Jan Karrenbeld

    05/31/2019, 5:45 PM
    What's this discussion about 😅
  • i

    itnoles

    05/31/2019, 8:29 PM
  • i

    itnoles

    06/02/2019, 4:40 PM
    Jacoco really don't like inline functions 🙂
  • i

    itnoles

    06/03/2019, 3:07 AM
    Jacocoo's HTML Report gives more information than codecov
  • i

    itnoles

    06/03/2019, 3:38 AM
    { key, value -> addRequestProperty(key, value) } < Never get Hit, Hmm
  • k

    kittinunf

    06/03/2019, 3:52 AM
    🤔
  • k

    kittinunf

    06/03/2019, 3:52 AM
    i think we do have a lot of tests for that
  • i

    itnoles

    06/03/2019, 3:54 AM
    Turn on Jacoco's HTML, you see
  • i

    itnoles

    06/03/2019, 3:55 AM
    With request.headers, you are setting the Header, right?
  • i

    itnoles

    06/03/2019, 3:56 AM
    oh wait, Android uses addRequestProperty to add the Header.
  • k

    kittinunf

    06/03/2019, 4:26 AM
    I will spend tonight trying to fix this
  • k

    kittinunf

    06/03/2019, 4:26 AM
  • k

    kittinunf

    06/03/2019, 4:26 AM
    it looks like we need to stop using 
    setFixedLengthStreamingMode
    ?
  • i

    itnoles

    06/03/2019, 4:26 AM
    No.
  • i

    itnoles

    06/03/2019, 4:27 AM
    @kittinunf you needed that when you have content-length.
  • i

    itnoles

    06/03/2019, 4:27 AM
    My PR refractors some area of HttpClient.
  • i

    itnoles

    06/03/2019, 4:28 AM
    I don't know it would fix that.
  • k

    kittinunf

    06/03/2019, 4:32 AM
    oh then we can try it out
  • i

    itnoles

    06/03/2019, 4:57 AM
    next version to replace Triple to Pair?
  • i

    itnoles

    06/03/2019, 5:47 AM
    @kittinunf should I do experimental branch for corountines-based Fuel?
  • k

    kittinunf

    06/03/2019, 6:06 AM
    yea
  • k

    kittinunf

    06/03/2019, 6:07 AM
    I think maybe we should start do a huge version like 3.0
1...102103104...118Latest