https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • n

    Nikky

    06/27/2019, 2:35 PM
    i could provide the curl -v output to compare
  • n

    Nikky

    06/27/2019, 2:35 PM
    another thing i noticed
  • n

    Nikky

    06/27/2019, 2:36 PM
    the curlstring for file uploads contains the file.. in textform.. not the file location with a 
    @
  • k

    kittinunf

    06/27/2019, 3:43 PM
    can we somehow replicate this with httpbin, so that it won’t be much of a trouble to try?
  • n

    Nikky

    06/27/2019, 4:12 PM
    what kind of info do you need ? i can give you the ouput of curl -v or so, anything else ?
  • i

    itnoles

    06/28/2019, 2:25 AM
    Intellij IDEA struggled on Kotlin DSL, but Android Studio refused to run it.
  • n

    Nikky

    06/28/2019, 6:31 AM
    i noticed in current master there is 0 tests for 
    httpUpload
  • k

    kittinunf

    06/28/2019, 10:45 AM
    🤯
  • k

    kittinunf

    06/28/2019, 10:45 AM
    lol
  • d

    Derk-Jan Karrenbeld

    06/28/2019, 10:54 AM
    @Nikky yeah, because it delegates to the regular upload request, I think
  • d

    Derk-Jan Karrenbeld

    06/28/2019, 10:54 AM
    I never use those string extensions, must have forgotten 😄
  • i

    itnoles

    06/30/2019, 4:09 AM
    @kittinunf inline fun <reified T : Any> gsonDeserializerOf(clazz: Class<T>) = gsonDeserializer<T>() where is clazz? 😉
  • k

    kittinunf

    06/30/2019, 5:05 AM
    lol
  • k

    kittinunf

    06/30/2019, 5:06 AM
    PR to fix it?
  • i

    itnoles

    06/30/2019, 7:01 PM
    what is your planning to do on that functions?
  • n

    Nikky

    06/30/2019, 7:09 PM
    the clazz there is unused correct ?
  • i

    itnoles

    06/30/2019, 7:09 PM
    right
  • d

    Derk-Jan Karrenbeld

    07/01/2019, 8:01 AM
    I think clazz forces T to be correct
  • d

    Derk-Jan Karrenbeld

    07/01/2019, 8:02 AM
    E.g. it allows you to write gsonDeserializerOf(MyClass) instead.of gsonDeserializer<MyClass.javaclass>
  • d

    Derk-Jan Karrenbeld

    07/01/2019, 8:02 AM
    But not sure
  • n

    Nikky

    07/01/2019, 9:55 AM
    unless there is a usecase for where Class<T> and T might not line up, maybe you want to pass in some subclass ?
  • n

    Nikky

    07/01/2019, 9:55 AM
    would the typesystem even allow that ?
  • i

    itnoles

    07/01/2019, 4:26 PM
  • n

    Nikky

    07/02/2019, 7:49 AM
    i guess this is for the usecase where zou have a clazz but no 
    T
    readilz available ?
  • n

    Nikky

    07/02/2019, 7:50 AM
    but we have typeOf() now right ? that should be able to help out
  • d

    Derk-Jan Karrenbeld

    07/02/2019, 7:51 AM
    Copy code
    val deserializer = gsonDeserializer()
    Now it doesn't know
    Copy code
    val deserializer = gsonDeserializer<MyClass>()
    Now it knows
    Copy code
    val deserializer = gsonDeserializerOf(someInstance.class)
    Now it also knows
  • d

    Derk-Jan Karrenbeld

    07/02/2019, 7:51 AM
    There are plenty of cases where you don't have a 
    T
  • n

    Nikky

    07/02/2019, 7:52 AM
    val deserializer: ResponseDeserializable<MyClass> = gsonDeserializer()
    ✔️ 1
  • n

    Nikky

    07/02/2019, 7:52 AM
    this also works iirc
  • d

    Derk-Jan Karrenbeld

    07/02/2019, 8:00 AM
    Yep. But you can't make that work with generics. 
    gsonDeserializerOf(someInstance.class)
    works with TypeTokens as well
1...105106107...118Latest