https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • d

    Derk-Jan Karrenbeld

    07/02/2019, 8:00 AM
    val deserializer: ResponseDeserializable<List<MyClass>> = gsonDeserializer()
    doesn't do what you might think it does.
  • d

    Derk-Jan Karrenbeld

    07/02/2019, 8:00 AM
    I think we actually have a test for that... 😛
  • i

    itnoles

    07/02/2019, 4:38 PM
    once we moved to multiplatform, we have to switch to https://kotlinlang.org/api/latest/kotlin.test/kotlin.test/index.html 😉
  • i

    itnoles

    07/03/2019, 12:18 AM
  • i

    itnoles

    07/03/2019, 12:19 AM
    @Derk-Jan Karrenbeld some Instanceof or isA tests are very weird.
  • i

    itnoles

    07/03/2019, 12:30 AM
    I put it in TODO 🙂
  • k

    kittinunf

    07/03/2019, 3:45 AM
    yeah, i use kotlin.test in my multiplatform project but I think it is bit broken when run with UI (at least on Android Studio)
  • i

    itnoles

    07/03/2019, 4:04 AM
    Android Studio wouldn't open the Fuel Project because kts
  • k

    kittinunf

    07/03/2019, 7:30 AM
    🤔 really? it works for me!
  • i

    itnoles

    07/03/2019, 2:35 PM
    KTS is just unsupported on latest Android Studio Beta
  • i

    itnoles

    07/04/2019, 3:22 AM
  • k

    kittinunf

    07/04/2019, 3:23 AM
    oh … looks like an Observable alternative …
  • i

    itnoles

    07/04/2019, 3:25 AM
    it is amazing how a lot of project is inspired by Reactive Streams
  • k

    kittinunf

    07/04/2019, 3:26 AM
    do they implement the Reactive Streams’ interface though?
  • k

    kittinunf

    07/04/2019, 3:26 AM
    i wish ….
  • i

    itnoles

    07/04/2019, 3:27 AM
    Copy code
    Flow is Reactive Streams compliant, you can safely interop it with reactive streams using Flow.asPublisher and Publisher.asFlow from kotlinx-coroutines-reactive module.
  • i

    itnoles

    07/04/2019, 3:29 AM
  • k

    kittinunf

    07/04/2019, 5:45 AM
    nice!
  • i

    itnoles

    07/05/2019, 4:53 AM
    215 tests completed, 3 failed 😐
  • k

    kittinunf

    07/05/2019, 1:17 PM
    😄
  • k

    kittinunf

    07/05/2019, 1:18 PM
    rerun?
  • i

    itnoles

    07/05/2019, 5:15 PM
    It is leading for Body with incorrect bytes
  • n

    Nikky

    07/05/2019, 5:43 PM
    got a weird crashreport from somebody:
    Copy code
    18:36:28.155 [pool-2] ERROR voodoo.util.Downloader - Download Failed
com.github.kittinunf.fuel.core.HttpException: HTTP Exception 404 Not Found
    at com.github.kittinunf.fuel.core.requests.SuspendableRequest.prepareResponse(SuspendableRequest.kt:32)
    at com.github.kittinunf.fuel.core.requests.SuspendableRequest.awaitResult(SuspendableRequest.kt:43)
    at com.github.kittinunf.fuel.core.DeserializableKt.awaitResponseResult(Deserializable.kt:250)
    at voodoo.util.DownloadExtensionKt$download$$inlined$awaitByteArrayResponseResult$1.invokeSuspend(Coroutines.kt:68)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:32)
    at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:233)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:742)
    it crashes in awaitResponseResult ... but shouldn't it wrap that in a error and pass it as Result.Failure ? this is the corresponding code: https://github.com/DaemonicLabs/Voodoo/blob/8623e1919bab36c820255d6e133530becc070391/util/src/main/kotlin/voodoo/util/DownloadExtension.kt#L46-L53 its a bit ugly and still got some fix for a earlier fuel version in i think
  • i

    itnoles

    07/07/2019, 5:39 PM
    RequestExecutionOptions is a mess.
  • k

    kittinunf

    07/08/2019, 2:03 AM
    ahh please don’t say like that … i think at certain point in time, we all tried to write the best code that we could. Looking back is always easy … Good or bad … there is always a room to improve
    ❤️ 1
  • k

    kittinunf

    07/08/2019, 2:04 AM
    if it is not good enough, let’s fix it together shall we?
  • i

    itnoles

    07/08/2019, 3:03 AM
    @kittinunf sorry. Multiplatform is going to be sucks for platform configurations.
  • i

    itnoles

    07/08/2019, 3:04 AM
    I just found out that Moshi didn't parse List correctly. 😞
  • i

    itnoles

    07/08/2019, 6:04 AM
    @kittinunf you know Forge's component2() is NOT catching on FuelError.
  • k

    kittinunf

    07/08/2019, 8:16 AM
    ! ! !
1...106107108...118Latest