kotlinlang #kotlin-fuel

07/08/2019, 8:16 AM

07/08/2019, 10:04 AM

can you show me what’s wrong?

07/08/2019, 10:04 AM

it should be captured correctly, no?

07/08/2019, 3:16 PM

Forge.modelFromJson(content, deserializer).component1() when there is an error, it only return null which causes default Errors to throw.

07/09/2019, 2:05 AM

07/09/2019, 4:02 AM

do you need more informations?

07/09/2019, 2:35 PM

let me try to write a test to replicate that

07/10/2019, 1:53 AM

@kittinunf how did that tests go?

07/10/2019, 4:19 AM

@Derk-Jan Karrenbeld ping

07/12/2019, 1:10 AM

@Derk-Jan Karrenbeld Did you fixed the Byte Array issues?

07/14/2019, 3:17 AM

hey @kittinunf?

07/14/2019, 11:37 AM

07/14/2019, 5:21 PM

Did you found a cause of Forge bugs?

07/15/2019, 3:14 AM

I could have to write a test if you want.

07/15/2019, 3:25 AM

Oh that would be awesome, yes, please 🙏

07/15/2019, 3:32 AM

i am noticed that some androidx libraries are moving to JDK 1.8

07/15/2019, 3:55 AM

@kittinunf I just Confirmed.

07/15/2019, 4:02 AM

@kittinunf I found a way to catch com.github.kittinunf.forge.core.MissingAttributeError 🙂

07/15/2019, 4:10 AM

fun <T : Any> forgeDeserializerOf(deserializer: JSON.() -> DeserializedResult<T>) = object : ResponseDeserializable<T> {
    override fun deserialize(content: String): T? {
        val forge =  Forge.modelFromJson(content, deserializer)
        forge.component2()?.let {
            throw it
        }
        return forge.component1()
    }
}

07/15/2019, 4:11 AM

throw it

, FuelError able to catch it.

07/15/2019, 4:58 AM

@kittinunf I just made PR.

07/15/2019, 5:38 AM

07/15/2019, 5:38 AM

I have commented in the PR!

07/15/2019, 6:10 AM

I have to look for return value from when case

07/15/2019, 8:03 AM

return when()

07/15/2019, 3:39 PM

well no if you have throw it

07/15/2019, 4:15 PM

you can get the return value as throw is returning

Nothing

, you can stil fulfill having return statements in every other case

07/15/2019, 6:01 PM

i found other way of doing it with when.

07/15/2019, 6:01 PM

override fun deserialize(content: String): T? {
        when (val result = Forge.modelFromJson(content, deserializer)) {
            is DeserializedResult.Success -> return result.value
            is DeserializedResult.Failure -> throw result.error
        }
    }

07/15/2019, 6:03 PM

it is still passed on Travis CI 🙂