Yes, I would like the option of having a synchronous API that doesn’t require callbacks. I’d like to have both options, sync and async.

@jkwatson: if thats the case, can you try version 0.67? @bmsantos has helped us implementing the sync mode. Basically, if you call

sync()

, it will block until the http call return. It should accommodate your need more or less. :)

It still won’t have a simple (non-callback) way of getting the data out of the response, though, right?

@jkwatson: Why would that be that important? I'm not at the computer right now and can't verify if there's such a simple straight method that just returns the Http Response. But if it doesn't, you can provide your own extension function to do it.

That is true, but I’m not sure that any of this makes an API that is compelling to use. If I have to wrap stuff and provide extension functions, I might as well just do that on top of okhttp, or something. But, hey, I’m just one user. No worries, and good luck!

@jkwatson has left the channel

Uau… @jkwatson This is what I call… “getting rushed conclusions”!

haha simple smile

Surprisingly, a lot of people seems to have a need for “sync” API, which I didn’t foresee at the beginning. I asked question a while back to myself that "who would have want network call to block” but it seems it is useful in some cases.

It would make sense though to have the core of Fuel to be synchronous. As far as I know

URLConnection

does not support any real asynchronous operation and thus will always use a Thread for any network operations. The asynchronous part can be build on top of that so the current API can remain the same.

@kittinunf: It’s very useful in many different situations. Especially during testing… you do not want to make a call to a REST interface just to find out that the test has already failed before the response has been handled! simple smile

@kittinunf: What do you think about add those to `Result`:

Result.success { data ->

}
Result.fail { exception ->

}

it's like

fold

but if you care only about success or failure (maybe for testing)

I'm going to work later on making `Fuel`'s core blocking.

BTW, can I delete all the

/**
 * Created by Kittinun Vantasin on 5/13/15.
 */

headers? IDEA marks it as warning 😕

@yoavst: Ok on both points! Thanks. :)

https://github.com/kittinunf/Fuel/commit/db53a47f217f62114cb6100ee6ac0d8b829fe02f I've removed

public

from most of places

But I can't run tests on Intellij IDEA, it says empty test suite.

Oh did travis run the tests still?

I've made a regular commit and push, not a pull request

since I've just removed redundant modifier.

But i want to run tests on my machine.

How did you do it normally? I use

gradlew test --debug

I tried to run it from GUI

I'll try from command line

do you run it under

fuel

module's folder or the project's folder?

I've run it under the project's folder and it is running for over 5 minutes.

Ok it seems to work now with gui

Is

TaskRequest

by itself blocking?

@kittinunf: Can you check https://github.com/kittinunf/Fuel/tree/blocking Changes: 1. Convert

responseX

to

Request.responseX

extension method. 2.

TaskRequest

now extends

Callable<Response>

instead of

Callable<Unit>

3,

AsyncTaskRequest

wraps

TaskRequest

with support for callbacks. (What does it returns if it fails on async mode? I think it should return

Response?

instead. Currently it is

TODO

and returns

Response()

).

It passes all tests, But I can't be sure it works as intended.