Channels
#kotlin-fuel
- d
Derk-Jan Karrenbeld
07/24/2019, 11:47 PMOther methods already do this! The idea here is if you call curlstring, it will write the memory stream into memory! This is perfectly fine behaviour 🙂 - d
Derk-Jan Karrenbeld
07/24/2019, 11:47 PMI just didn't do it for cUrlString, or so it seems 😄 - d
Derk-Jan Karrenbeld
07/24/2019, 11:47 PMI think upload body has this. If you try to print it, it will store it in memory. - k
kittinunf
07/30/2019, 7:09 AMLet’s do that 🙂 - k
kittinunf
07/30/2019, 7:09 AMcan anyone approve this though? we have some client bugging me on this - k
kittinunf
07/30/2019, 7:10 AM - d
Derk-Jan Karrenbeld
07/30/2019, 12:29 PMMerged! - n
Nikky
07/30/2019, 12:31 PMsomeopne sent me another crash.. wherei t seems like on httpPost because of a error it triggers .cUrlString() and because it cannot read the body.. it crashes and hides the original error - d
Derk-Jan Karrenbeld
07/30/2019, 12:35 PMYes, we need to fix it! 🙂 - d
Derk-Jan Karrenbeld
07/30/2019, 12:35 PMI am super super busy for the next 3 weeks (which is why I have barely written code recently), but afterwards I can do it. - d
Derk-Jan Karrenbeld
07/30/2019, 12:36 PMI can also look up how I did it for the other things, then maybe you can do irt? - d
Derk-Jan Karrenbeld
07/30/2019, 12:37 PM - d
Derk-Jan Karrenbeld
07/30/2019, 12:37 PM* A Repeatable Body wraps a body and on the first [writeTo] it keeps the bytes in memory so it can be written again.
- d
Derk-Jan Karrenbeld
07/30/2019, 12:38 PMhttps://github.com/kittinunf/fuel/blob/4fd0722c90d1cddfed5593fea53f502faadf7a85/fuel/README.md#adding-request-bodyBodies are formed from generic streams, but there are helpers to set it from values that can be turned into streams. It is important to know that, by default, the streams are NOT read into memory until the Request is sent. However, if you pass in an in-memory value such as a ByteArray or String, Fuel uses RepeatableBody, which are kept into memory until the Request is dereferenced.
- d
Derk-Jan Karrenbeld
07/30/2019, 12:38 PMThere is even already a
helper method!asRepeatable - d
Derk-Jan Karrenbeld
07/30/2019, 12:41 PMIf you look at the implementation of
you can see how I did this ontoByteArrayDefaultBody - d
Derk-Jan Karrenbeld
07/30/2019, 12:43 PMIt is weird, because
usescurlString
, so this should work...toByteArray - n
Nikky
07/30/2019, 1:13 PMi do pass in the jsonBody as string though... - n
Nikky
07/30/2019, 1:18 PMwell nevermind, seems liek the .asRepeatable is only on one BOdy type, it should be on Body i think and in RepeatableBody it is just returning itself - n
Nikky
07/30/2019, 1:18 PM@Derk-Jan Karrenbeld mind if i push to your branch ? - n
Nikky
07/30/2019, 1:28 PMand some CI script broke.. travis fails at installing the android sdk - n
Nikky
07/30/2019, 1:28 PM - d
Derk-Jan Karrenbeld
07/30/2019, 1:28 PMwell nevermind, seems liek the .asRepeatable is only on one BOdy type, it should be on Body i think and in RepeatableBody it is just returning itself
ah. my bad. yes, should be everywhere I think - d
Derk-Jan Karrenbeld
07/30/2019, 1:29 PM@Derk-Jan Karrenbeld mind if i push to your branch ?
Do your thing!!! - d
Derk-Jan Karrenbeld
07/30/2019, 1:29 PMi do pass in the jsonBody as string though...
Doesn't matter. We convert everything to a stream 🙂 - n
Nikky
07/30/2019, 1:31 PMso some bits of the docs are wrong then?However, if you pass in an in-memory value such as a ByteArray or String, Fuel uses RepeatableBody, ...
- n
Nikky
07/30/2019, 1:32 PManyways, i just fixed the location of .asRepeatable and it seems to work - d
Derk-Jan Karrenbeld
07/30/2019, 3:26 PMHowever, if you pass in an in-memory value such as a ByteArray or String, Fuel uses RepeatableBody, ...
Let me check