Channels
#kotlin-fuel
- d
Derk-Jan Karrenbeld
07/30/2019, 3:28 PMNo, it should've worked. https://github.com/kittinunf/fuel/blob/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/requests/DefaultRequest.kt#L234 see it sets
torepeatable
, and then this: https://github.com/kittinunf/fuel/blob/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/requests/DefaultRequest.kt#L203-L207true - d
Derk-Jan Karrenbeld
07/30/2019, 3:29 PMI don't understand why this doesnt work. Is it possible that
just doesn't do it correctly?jsonBody - d
Derk-Jan Karrenbeld
07/30/2019, 3:29 PM
seems to do it correctly!body() - d
Derk-Jan Karrenbeld
07/30/2019, 3:32 PMAh. The reason I did NOT add asRepeatable to
is that I envisioned body types that piped from aBody
input stream. But I think this is fine.read-once - i
itnoles
07/30/2019, 4:12 PMTravis remove sdkmanager? - i
itnoles
07/30/2019, 4:15 PMWTH!!!! - s
snowe
07/30/2019, 4:42 PMwhen attempting to download multiple things concurrently but block on all being downloaded, this code is not blocking until everything is downloaded. it seems to continue as soon as it starts all of the downloads. not sure what i'm doing wrong... - s
snowe
07/30/2019, 4:42 PMCopy codeval downloadedArtifacts = mutableListOf<File>() runBlocking { launch { filteredStageComponents.forEach { i -> i.assets.forEach assets@{ val fileType = it.path.split("/").last()//.replace("$artifactId-$version", "").replace("-", "") val path = Paths.get(tempDir.toURI().path, groupId, artifactId, version, fileType) path.parent.toFile().mkdirs() val tempFile = path.toFile() downloadedArtifacts.add(tempFile) Fuel.download(it.downloadUrl) .fileDestination { _, _ -> tempFile } .authentication().basic(extension.stageReadUsername, extension.stageReadPassword) .response { _, _, _ -> } } } } } <http://logger.info|logger.info>("SP: Beginning promotion") System.exit(0) - s
snowe
07/30/2019, 4:42 PMlet me clean that up, sorry. - s
snowe
07/30/2019, 4:43 PMso, the system.exit should occur after everything has downloaded, but it's not, nothing has been downloaded by that point - s
snowe
07/30/2019, 4:54 PMah, i thought just adding fuel-coroutines made this work. apparently i needed.awaitStringResponseResult() - i
itnoles
07/31/2019, 2:26 AM@kittinunf Travis CI broke over sdkmanager 😞 - i
itnoles
07/31/2019, 2:26 AMit seems Travis CI changes something. - i
itnoles
07/31/2019, 2:30 AMlooks like Travis CI forces Ubuntu Trusty update. - i
itnoles
07/31/2019, 2:35 AMTravis CI doesn't want JDK 8 anymore. - k
kittinunf
07/31/2019, 2:36 AM_<
- k
kittinunf
07/31/2019, 2:36 AMmaybe we really need to migrate to somewhere else … - i
itnoles
07/31/2019, 2:38 AMi am going to try to use openjdk8 - i
itnoles
07/31/2019, 2:40 AMI blame Oracle for this mess. - i
itnoles
07/31/2019, 2:41 AMtried openjdk8, same problem. 😞 - i
itnoles
07/31/2019, 2:50 AMremove jdk line advanced the line. - i
itnoles
07/31/2019, 3:00 AM@kittinunf i got build to succeed - i
itnoles
07/31/2019, 3:04 AMyou know Release Build didn't succeed? - k
kittinunf
07/31/2019, 3:24 AMokay i am on it … - i
itnoles
07/31/2019, 3:47 AMyou need my PR to fix the Travis. - k
kittinunf
07/31/2019, 2:50 PMlet’s us start
branch.develop - i
itnoles
08/02/2019, 2:08 AM@Derk-Jan Karrenbeld your PR now passed. 🙂 - n
Nikky
08/03/2019, 7:33 PMwell i approve of the cUrlStringh fix, but someone else should probably still look at it and merge - i
itnoles
08/03/2019, 8:01 PM@Nikky does it solve your problems? - n
Nikky
08/03/2019, 8:01 PMit does