https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    01/18/2016, 5:26 PM
    Check it out already and don’t see any real concerns, you might wanna create a PR for it?
  • k

    kittinunf

    01/18/2016, 5:26 PM
    @yoavst:
  • y

    yoavst

    01/18/2016, 5:28 PM
    What's about number 3 todo?
  • k

    kittinunf

    01/18/2016, 5:36 PM
    Do we have anything better than 
    null
    ?
  • k

    kittinunf

    01/18/2016, 5:37 PM
    If we don’t then we might have to go for it.
  • y

    yoavst

    01/18/2016, 5:55 PM
    I'm afraid some functionality is called twice.
  • y

    yoavst

    01/18/2016, 5:57 PM
    If we could have returned a platform type... simple smile
  • y

    yoavst

    01/18/2016, 6:01 PM
    Also, 
    responseX
    should return the same data as the async version, I'm fixing it now. Is 
    Triple<Request, Response, T>
    OK?
  • k

    kittinunf

    01/18/2016, 6:08 PM
    Why not 
    Result<>
    ?
  • y

    yoavst

    01/18/2016, 6:17 PM
    It doesn't return 
    Result
    because it throws the error
  • k

    kittinunf

    01/18/2016, 6:18 PM
    Result can wrap error as well.
  • k

    kittinunf

    01/18/2016, 6:18 PM
    By error, you mean exception?
  • y

    yoavst

    01/18/2016, 6:19 PM
    Yes.
  • y

    yoavst

    01/18/2016, 6:19 PM
    I think it should throw it in blocking mode.
  • y

    yoavst

    01/18/2016, 7:14 PM
    OK: 1. I fixed the functionality, it passes all tests including new test for blocking mode. 2. 
    responseX
    are now again regular methods so they could be called from Java. I'll make the pull request.
  • y

    yoavst

    01/20/2016, 4:13 PM
    @kittinunf: What's about the pull request?
  • k

    kittinunf

    01/20/2016, 4:14 PM
    Yup I am checking on it now.
  • k

    kittinunf

    01/20/2016, 4:19 PM
    I have commented on it, overall I think it is shiny ✨
  • y

    yoavst

    01/20/2016, 4:47 PM
    Pushed. But IDEA sent the wrong message 😞
  • y

    yoavst

    01/21/2016, 2:52 PM
    @kittinunf: Any plans on releasing a new version?
  • k

    kittinunf

    01/21/2016, 2:54 PM
    Tonight I will
  • y

    yoavst

    01/21/2016, 3:41 PM
    @mplatvoet: Now (after new version is released) you can update https://github.com/mplatvoet/kovenant-android-demo/blob/master/app/src/main/java/http.kt
  • y

    yoavst

    01/21/2016, 3:41 PM
    Request.promise()
    is not needed any more simple smile Just 
    task { request.responseX() }
  • m

    mplatvoet

    01/21/2016, 4:21 PM
    Cool, Will update later today
  • y

    yoavst

    01/21/2016, 4:39 PM
    wait @kittinunf , before publishing update the plugin version to 4589.
  • k

    kittinunf

    01/21/2016, 4:40 PM
    I already published it ...
  • k

    kittinunf

    01/21/2016, 4:40 PM
    version 0.7
  • k

    kittinunf

    01/21/2016, 4:42 PM
    Is there anything interesting in 4589?
  • y

    yoavst

    01/21/2016, 4:43 PM
    Not that I know.
  • y

    yoavst

    01/21/2016, 4:44 PM
    Bugfix update: Gradle Plugin for Android Instant Run support for Android Studio Compatibility with IntelliJ IDEA 16
1...111213...118Latest