I think that we might want to deprecate use of

sync()

? As we have a proper way to enter the

sync

mode

I can think currently on a use case, tests.

I'm using this class on app - https://gitlab.com/yoav-sternberg/ohelshem/blob/portal6/api/src/main/java/com/yoavst/ohelshem/api/controller/implementation/RequestsControllerImpl.kt and this class on tests - https://gitlab.com/yoav-sternberg/ohelshem/blob/portal6/api/src/main/java/com/yoavst/ohelshem/api/controller/implementation/RequestsControllerBlockingImpl.kt

This way the integration tests actually work.

The only difference is

.sync()

Maybe it should be provided like in `Kovenant`: http://kovenant.komponents.nl/api/test_usage/#testmode So we can do:

Fuel.testMode {
    timeout = X // will override timeout for all request
}

Sounds like a good idea ...

implemented, see https://github.com/kittinunf/Fuel/pull/53

So I'm very new to kotlin and I'm trying to make a client library for my api using Fuel, is there anything wrong with how I am wrapping fuel functions?

fun createUser(username: String, password: String, email: String, uuid: UUID, handler: (Boolean) -> Unit) {
        val body = listOf("username" to username, "password" to password, "email" to email, "uuid" to uuid)
        "/users".httpPost(body).response {request, response, result ->
            when(result) {
                is Result.Success -> handler(true)
                is Result.Failure -> handler(false)
            }
        }
    }

@zzn2 has left the channel

@kittinunf: can you check my pull request and update

Result

to 1.0.0 (So

Fuel

could be updated too)?

@cavega has left the channel

Definitely, I am doing it now.

set the channel topic: https://github.com/kittinunf/Fuel

<!here|@here>: version 1.0.0 is out to support Kotlin 1.0.0 😄

@kittinunf: Now my pull request finally works. I need to enable auto-import to git 😕

@Vitalii Dmitriev has left the channel

hey guys, would anyone know of a reason why a fuel post may be executing a request twice despite only being called once?

Can you show us a small example for that?

I have an address

<https://svc.mashov.info/api/mail/messages/$id/files/$id/$name>

. name is not url encoded. If I pass it like that, it fails, if I pre encode it, it encode it twice. idea?

Just only the $name part?

If I encode the full address

That is the method I used for encoding the full address

Uri.parse("<https://svc.mashov.info/api/mail/messages/$id/files/$id/>").buildUpon().appendPath(name).build().toString()

private fun Request.bugFix(url: String): Request {
        this.path = url
        this.url = URL(url)
        return this
    }

If I use this old method it works simple smile

@yoavst: were you able to find out the problem. I really think that we should fix it.

<!channel>: I have updated Fuel to version 1.1.0, add provides RxJava support.

Had a long week, I'll debug it tomorrow.

fun invalidCase() {
    val file = "פרקי לימוד למבחן מספר 3 15 במרץ 2016.docx"
    val path = "<https://svc.mashov.info/api/mail/messages/33967/files/33967/>" + file
    val (request, response, data) = Fuel.get(path).validate(0..1000).responseString()
}

In this case

request.path == path

However it is illegal URL.

the https://github.com/kittinunf/Fuel/blob/master/fuel%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fgithub%2Fkittinunf%2Ffuel%2Fcore%2FEncoding.kt#L50 method doesn't convert it to a valid URL:

<https://svc.mashov.info/api/mail/messages/33967/files/33967/פרקי%20לימוד%20למבחן%20מספר%203%2015%20במרץ%202016.docx>

(should be ASCII only)