Gosh. Encoding is not an easy task.

I'm nominating you for the understatement of the year award, along with some girl doing time zones. ;-)

@kittinunf: https://github.com/kittinunf/Fuel/blob/master/fuel%2Fsrc%2Fmain%2Fkotlin%2Fcom%2Fgithub%2Fkittinunf%2Ffuel%2Fcore%2Frequests%2FTaskRequest.kt#L18 What happens if

FuelError

is thrown during async request? how does it return the Response object?

Oh, empty response, Ok.

@kittinunf: https://github.com/kittinunf/Fuel/pull/60

https://github.com/kittinunf/Fuel/blob/244106c27b456f1ea607a6e94c5bff202a3b2edf/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/Encoding.kt#L37 I think path should be the created URL,

toAsciiString()

I'm a bit confused with this example from readme.md:

//if you have body to post it manually
<http://Fuel.post|Fuel.post>("<http://httpbin.org/post>").body("{ \"foo\" : \"bar\" }").response { request, response, result ->
}

For such a body there should be a correct

Content-Type

specified. Something like

application/json

. But for the case like in the example I getting

Content-Type: application/x-www-form-urlencoded; charset=utf-8

From the library point of view, it gets only plain string so it doesn’t know whether it is json or not. So,

application/json

doesn’t add by default.

client gotta specifically put the

Content-Type

by using

header

method.

@kittinunf: thanks! this is exactly what i did simple smile But I have another issue – Request.cancel do actually nothing 😞 Am I the only one who's using this feature or I'm doing it in a wrong way?..

private var pollingRequest: Request? = null

    private fun cancelPollRequest() {
        val r = pollingRequest
        if (r != null) {
            this.pollingRequest = null
            r.cancel()
        }
    }

pollingRequest

is a long-polling request, which remains active even after this cancel

I took a look into the code, and found just Future.cancel without any handling of this cancellation from HttpUrlConnection or HttpClient

It should be working as Future.cancel will cancel underlying task. There is a chance that cancel of Future doesn’t work such as task is completed or has already been cancelled.

Can you confirm that it doesn’t fall into mentioned cases?

@kittinunf: yes, I'm 99% sure that cancel is calling while task is not completed/cancelled. My request is a Comet – after request is sent the server keeps it for 30 seconds and either respond with array of events if these events has occured, or respond with empty array if there was no events. So my case is this: 1. request sent 2. in 2-5 seconds I perform a cancellation 3. nothing is cancelling (according to the mitmproxy) and after the timeout the success handler is calling

I'll try to make a sample asap

Then, it sounds like a bug to me. I am sorry for that 😢

I am outside right now, I will check tonight and see what I can improve to fix this.

@kittinunf: np) I think that

Future.cancel

is not enough to cancel the execution. It won't terminate neither http-request, nor underlying thread. So it's up to the developer to forward the cancellation intent to the HttpClient/HttpUrlConnection. I'm not quite experienced in this though simple smile

If you know how to fix it by reading the source code, I am more than happy to accept PR. simple smile

I can probably look into this. Let's see if I can make the time this weekend

Filled that as an issue: https://github.com/kittinunf/Fuel/issues/65

@orangy has left the channel

@flamurey has left the channel

Hi anyone?

I've been created a pull request into github can anyone test it?

Yeah. I did comment it in the PR.

Kittinun I don't know how can I do that

please help me

I've made only 2 simple changes