kotlinlang #kotlin-fuel

w: /home/travis/build/[secure]/Fuel/fuel/src/main/kotlin/com/github/[secure]/fuel/core/requests/CancellableRequest.kt: (39, 38): Unnecessary safe call on a non-null receiver of type InterruptCallback /* = (Request) -> Unit */ w: /home/travis/build/[secure]/Fuel/fuel/src/main/kotlin/com/github/[secure]/fuel/core/requests/RequestTask.kt: (13, 72): Elvis operator (?:) always returns the left operand of non-nullable type InterruptCallback /* = (Request) -> Unit */ w: /home/travis/build/[secure]/Fuel/fuel/src/main/kotlin/com/github/[secure]/fuel/core/requests/SuspendableRequest.kt: (12, 72): Elvis operator (?:) always returns the left operand of non-nullable type InterruptCallback /* = (Request) -> Unit */

itnoles

11/13/2018, 3:45 AM

w: /home/travis/build/kittinunf/Fuel/fuel-jackson/src/test/kotlin/com/github/kittinunf/fuel/issues/ResponseLoggingIssue364.kt: (61, 17): Variable 'response' is never used Hmm

itnoles

11/15/2018, 3:11 AM

@Derk-Jan Karrenbeld is @JvmOverloads is needed for corountines?

itnoles

11/16/2018, 3:09 AM

is it me that HttpClient is extremely complex?

Nikky

11/16/2018, 12:15 PM

but each serializer you construct is being constructed with generics and type information for that specific request and expected returned data

itnoles

11/16/2018, 4:47 PM

@Nikkyfuel-core doesn't have corountines-core dependency.

Nikky

11/17/2018, 12:13 PM

running this on master: https://gist.github.com/NikkyAI/3b5bde756e955d5ed951c378c13dae4e

igor.wojda

11/17/2018, 3:08 PM

Does the Fuel supports CertificatePinning? (something like okhttp certificate pinner https://square.github.io/okhttp/3.x/okhttp/okhttp3/CertificatePinner.html) ?

itnoles

11/19/2018, 8:50 PM

@Nikky new version of kotlin serializations

itnoles

11/19/2018, 11:44 PM

@Derk-Jan Karrenbeld is it is best to have 2.0.0-SNAPSHOT?

itnoles

11/21/2018, 12:12 AM

@Derk-Jan Karrenbeld would it be helpful if somebody else created the Hooks?

itnoles

11/27/2018, 11:10 PM

Some Extensions should be separate from the main repo.

itnoles

11/27/2018, 11:40 PM

HttpUrlConnection default Chunk size is 1024 (1 K)

itnoles

12/03/2018, 4:19 AM

since it is very large, I would let @kittinunfto review it.

itnoles

12/03/2018, 4:22 AM

@Derk-Jan Karrenbeld Should we let Sample to Run in Travis CI?

kittinunf

12/09/2018, 1:46 AM

I am reading your branch @Derk-Jan Karrenbeld!

👮‍♂️ 1

kittinunf

12/22/2018, 5:49 AM

@Derk-Jan Karrenbeld it looks like because I change 3xx to be success not failure, it kinda broke the timing, it also try to pass the original request with 3xx status code with deserializer which make it fails

kittinunf

12/22/2018, 5:49 AM

do you have a good idea on how to fix this?

snowe

01/10/2019, 10:54 PM

It appears the issue was the capital

Fuel

in the dependencies block 🤦‍♂️🏽

Nikky

01/11/2019, 2:09 AM

is there any possiblity of renaming the github project name ?

Nikky

01/11/2019, 2:15 AM

i am writing a gist for the jitpack doc

❤️ 1

itnoles

01/21/2019, 7:55 PM

you know weird in HttpUrlConnection with setDoOutput(true), it forces POST Methods.

itnoles

01/23/2019, 7:53 PM

Kotlin 1.3.20 released

Nikky

01/23/2019, 10:59 PM

tests failed with this:

e: /home/nikky/dev/Fuel/sample/src/main/kotlin/com/example/fuel/MainActivity.kt: (22, 34): Unresolved reference: stetho
e: /home/nikky/dev/Fuel/sample/src/main/kotlin/com/example/fuel/MainActivity.kt: (51, 13): Unresolved reference: hook
e: /home/nikky/dev/Fuel/sample/src/main/kotlin/com/example/fuel/MainActivity.kt: (51, 20): Unresolved reference: StethoHook
e: /home/nikky/dev/Fuel/sample/src/main/kotlin/com/example/fuel/SampleApplication.kt: (4, 12): Unresolved reference: facebook
e: /home/nikky/dev/Fuel/sample/src/main/kotlin/com/example/fuel/SampleApplication.kt: (9, 9): Unresolved reference: Stetho

and i am not sure its because of the kotlin version change...

snowe

01/25/2019, 8:47 PM

how do I ‘include’ kotlinx’s repos in by plugin build?

itnoles

01/25/2019, 10:55 PM

jitpack still look for older kotlin serializations

Nikky

01/26/2019, 7:42 AM

do we have any helper methods for setting / adding cookies ? afaik those are all just in one header right ?

itnoles

01/28/2019, 3:29 AM

@Derk-Jan Karrenbeld Did you see about OkHttp is dropping older Android for better TLS 1.2 Support?

itnoles

02/02/2019, 2:22 AM

@Derk-Jan Karrenbeld Proguard could effect the Fuel client?