https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    06/08/2016, 3:19 AM
    result.value
    is able to access after you have checked it is a 
    Result.Success
    👍 2
  • k

    kittinunf

    06/08/2016, 3:20 AM
    Copy code
    when (result) {
  Result.success -> {
    //do something with result.value
  }
}
  • a

    abe

    06/08/2016, 5:13 PM
    Thanks @kittinunf that clears it up.
  • k

    kittinunf

    06/09/2016, 2:46 AM
    you are welcome. Probably my README is not the best thing you could find. I try to find to add more info into it.
  • d

    denis.st

    06/09/2016, 8:31 PM
    hey, guys! is there any good reason to keep 
    Response.url
    as a 
    lateinit
    , as a 
    var
    and out of the primary constructor's parameters?
  • d

    denis.st

    06/09/2016, 8:32 PM
    class Response(val url: URL) {
    looks better for me
  • k

    kittinunf

    06/10/2016, 4:48 AM
    I agree, perhaps you could help me fix that with PR. 😄
    😄 1
  • d

    denis.st

    06/10/2016, 8:49 AM
    actually I'm trying to take a time and sync the changes I've made locally into main repo. with no luck yet, tho 😞
  • d

    denis.st

    07/06/2016, 3:11 PM
  • k

    kittinunf

    07/06/2016, 3:41 PM
    @denis.st: Hey, it was really nice Denis. I am just wondering whether you could use 
    requestInterceptors
    and 
    responseInterceptors
    to help you achieve the same thing without modifying 
    HttpClient
    code?
  • d

    denis.st

    07/06/2016, 7:03 PM
    huh. I didn't update Fuel for a too long time 😅
  • j

    jasper

    07/09/2016, 5:46 AM
    I called FuelManager.instance.basePath = <a path>, also some base headers, however in my Android test they didn’t apply. . is the config bound to a thread or something?
  • k

    kittinunf

    07/09/2016, 5:51 AM
    Hmm, that’s not normal. Can you give me small example to demonstrate that?
  • k

    kittinunf

    07/09/2016, 5:53 AM
    It should look like this;
    Copy code
    //somewhere earlier
FuelManager.instance.basePath = "<https://httpbin.org>"
FuelManager.instance.baseHeaders = mapOf("foo" to "bar")
FuelManager.instance.baseParams = listOf("key" to "value”)

//later
Fuel.get("/get").responseString { req, res, result ->
}
  • y

    yoavst

    07/10/2016, 5:15 PM
    @kittinunf: do we encode the headers? (just thought about it, not at home so I can't check it)
  • k

    kittinunf

    07/10/2016, 5:21 PM
    Only for the basic auth, normal headers, I don’t think we encode them.
  • k

    kittinunf

    07/10/2016, 5:22 PM
    I remember ASCII is guaranteed to work. Is there a case where it should be encoded?
  • y

    yoavst

    07/10/2016, 6:19 PM
    if the header contains newline or something I think
  • y

    yoavst

    07/10/2016, 6:19 PM
    I've started to work at a company, and we use Java and Volley 😞 I was told to start write unit tests. But How can I write unit test if nothing is decoupled and there is android code inside the functional code 😞
  • y

    yoavst

    07/10/2016, 6:26 PM
    Anyway, it crash 🙂
  • y

    yoavst

    07/10/2016, 6:26 PM
    Copy code
    Fuel.get("<https://www.google.com/>").header("sample" to "a\nb\nc").responseString { request, response, result -> 
  // result is Failure
}
  • y

    yoavst

    07/10/2016, 6:27 PM
    Copy code
    Exception : Illegal character(s) in message header value: a
b
c
	at com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:69)
	at com.github.kittinunf.fuel.core.requests.TaskRequest.call(TaskRequest.kt:17)
	at com.github.kittinunf.fuel.core.requests.AsyncTaskRequest.call(AsyncTaskRequest.kt:13)
	at com.github.kittinunf.fuel.core.requests.AsyncTaskRequest.call(AsyncTaskRequest.kt:6)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at com.github.kittinunf.fuel.core.FuelManager$executor$2$1$1.run(FuelManager.kt:43)
	at java.lang.Thread.run(Thread.java:745)
  • k

    kittinunf

    07/11/2016, 3:01 AM
    @yoavst: Too bad for you man, I have to go back and write Java from time to time too. I have no fun writing Java anymore though, feel everything is verbose and clumsy.
  • r

    repa40x

    07/11/2016, 7:04 AM
    @repa40x has left the channel
  • r

    rodly

    07/18/2016, 2:32 AM
    @rodly has left the channel
  • d

    denis.st

    09/02/2016, 10:26 AM
  • k

    kittinunf

    09/02/2016, 11:01 AM
    I experienced throw exception from both of the method once, so I wrapped it in try-catch block. And docs seems to confirm it.
  • k

    kittinunf

    09/02/2016, 11:01 AM
  • d

    denis.st

    09/02/2016, 11:11 AM
    @kittinunf but there's the outer try-catch block around both 
    connection.apply
    and 
    response.apply
    , so it will catch any exception fired inside these apply-s
  • k

    kittinunf

    09/02/2016, 11:12 AM
    Ah true, it is a mistake from my part. /|\
1...202122...118Latest