https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    10/17/2018, 2:18 PM
    @Nikky Thanks a ton!
  • n

    Nikky

    10/17/2018, 2:18 PM
    DeserializationStrategy is the new name
  • n

    Nikky

    10/17/2018, 2:18 PM
    should i also do the fixes for deprecated names in serialization ?
  • k

    kittinunf

    10/17/2018, 2:19 PM
    sounds great!
  • k

    kittinunf

    10/17/2018, 2:19 PM
    but separate PR if possible!
  • n

    Nikky

    10/17/2018, 2:19 PM
    okay sure
  • k

    kittinunf

    10/17/2018, 2:20 PM
    @Mark Gilchrist if you have time, please approve #462
  • k

    kittinunf

    10/17/2018, 2:20 PM
    or anyone else 🙂
  • n

    Nikky

    10/17/2018, 2:24 PM
  • n

    Nikky

    10/17/2018, 2:24 PM
    now well maybe i should go over the PR template
  • k

    kittinunf

    10/17/2018, 2:25 PM
    Looks great to me. But it won’t make it for 1.16 though
  • k

    kittinunf

    10/17/2018, 2:26 PM
    btw @Nikky since you are interacting with kotlinx-serialzation the most
  • k

    kittinunf

    10/17/2018, 2:26 PM
    do you know where do we use 
    Versions.kotlinxSerialization
    ?
  • k

    kittinunf

    10/17/2018, 2:26 PM
    it doesn’t seem to be used anywhere
  • n

    Nikky

    10/17/2018, 2:27 PM
    it should be in the dependencies in the serialization module
  • k

    kittinunf

    10/17/2018, 2:27 PM
    val serialization = "org.jetbrains.kotlinx:kotlinx-serialization-runtime:0.8.2-rc13"
  • n

    Nikky

    10/17/2018, 2:27 PM
    but that dependency is hardcoded
  • k

    kittinunf

    10/17/2018, 2:27 PM
    ah … it is hardcoded here
  • k

    kittinunf

    10/17/2018, 2:27 PM
    haha
  • k

    kittinunf

    10/17/2018, 2:27 PM
    can you help me fix that too?
  • n

    Nikky

    10/17/2018, 2:28 PM
    i will improve that too in the PR #465
  • k

    kittinunf

    10/17/2018, 2:28 PM
    i think in #466 seems to be fine
  • k

    kittinunf

    10/17/2018, 2:28 PM
    oh okay
  • n

    Nikky

    10/17/2018, 2:28 PM
    i think 465 is more about the whole builscript stuff
  • k

    kittinunf

    10/17/2018, 2:28 PM
    yeah you are right
  • k

    kittinunf

    10/17/2018, 2:29 PM
    i kinda want to combine 
    Dependencies
    Plugins
    and 
    Versions
    into one file though
  • k

    kittinunf

    10/17/2018, 2:29 PM
    should have been one file, it would increase visibility …
  • n

    Nikky

    10/17/2018, 2:30 PM
    would you prefer the way i do it now or rather
  • n

    Nikky

    10/17/2018, 2:30 PM
    Copy code
    val PluginDependenciesSpec.androidLib
    get() = id(PluginID.androidLib)
        .version("3.1.3")
        .apply(false)
  • n

    Nikky

    10/17/2018, 2:31 PM
    that can be applied like the builtin plugins then
    Copy code
    plugins {
  androidLib
}
1...272829...118Latest