Channels
#kotlin-fuel
- n
Nikky
10/19/2018, 1:55 PM@sbyrne which bug are you trying to fix ? - n
Nikky
10/19/2018, 1:56 PMor rather.. which bug are you facing.. ? - s
sbyrne
10/19/2018, 2:19 PMI managed to comment out a bunch of stuff in *.gradle.kts to get it to work enough for me. - s
sbyrne
10/19/2018, 2:19 PMI'm trying to fix the fact that even when using
, it tried to load the whole stream into memory.Request.destination❤️ 2 - d
Derk-Jan Karrenbeld
10/19/2018, 2:23 PMYes please. - k
kittinunf
10/19/2018, 3:10 PMHey @sbyrne thanks for trying to fix the issue. Truth to be told, in the past i used AS to develop Fuel and in the beginning
module was started before the core part got refactor and abstracted it out and it becamefuel-android
.fuel - k
kittinunf
10/19/2018, 3:11 PMReally sorry for inconveniences 🙏 - s
sbyrne
10/19/2018, 3:11 PMThat makes sense. Thanks for separating it out though! I am using it in several places. I just started running into problems trying to download 3GB files. - k
kittinunf
10/19/2018, 3:12 PMLately i moved over and using intellij community edition to work on Fuel but obviously i do have Android SDK in my machine. So it got setup, this way - k
kittinunf
10/19/2018, 3:15 PMI also want to hear your opinion on how Fuel can be contributed without pain. If you have a thing or two to suggest or even have it written down in contribution section that would be highly appreciated (optional though) - k
kittinunf
10/19/2018, 3:16 PMAnd thanks for trying to send a PR even though it is a bit of a pain 😅 - s
sbyrne
10/19/2018, 3:21 PMI am generally not a fan of multi-module projects. Separating fuel-core, fuel-android, fuel-coroutines, etc. all out into separate gradle projects (even separate git repos) makes changing just one easier. Although that is at the expense of testing affects on others more difficult. - s
sbyrne
10/19/2018, 3:21 PMIt could be separated out into just 2 - non-android and android. - s
sbyrne
10/19/2018, 3:22 PMOr maybe it would be possible to have the build scripts check a variable set in gradle.properties that disables the android stuff? - s
sbyrne
10/19/2018, 3:22 PMI am just starting to move my stuff from maven to gradle; I do not know gradle well enough to know if that is possible or how to do it. - n
Nikky
10/19/2018, 4:37 PMso i am getting this weird thing when i handle a redirect manually i get statuscode -1 - n
Nikky
10/19/2018, 4:38 PMand the exception thrown iscom.github.kittinunf.fuel.core.HttpException: HTTP Exception 302 Found - d
Derk-Jan Karrenbeld
10/19/2018, 4:45 PMCurrently it is implemented that if you don't catch a redirect usign an interceptor it gives an exception. It's on my backlog to change, but first I want to tackle the headers - d
Derk-Jan Karrenbeld
10/19/2018, 4:45 PMYou can "fix" it, by making 100...399 valid status codes! - d
Derk-Jan Karrenbeld
10/19/2018, 4:45 PM(it's one of the interceptors I think) @Nikky - n
Nikky
10/19/2018, 4:46 PMwell i think the issue is also i nthe api, they do not like my useragent since its not that of a common brwoser - n
Nikky
10/19/2018, 4:46 PMthey started doing that BS recently - d
Derk-Jan Karrenbeld
10/19/2018, 4:47 PMYeah I've seen API's choke on custom User Agents which is super shitty. - d
Derk-Jan Karrenbeld
10/19/2018, 4:47 PMAnyway, if you make validStatusInterceptor or something liek that also include 302, you should be good to go 🙂 - n
Nikky
10/19/2018, 4:48 PMwhat i really need is a way to transform the location returned by the api - n
Nikky
10/19/2018, 4:48 PMsince its broken and i need to encode it properly - n
Nikky
10/19/2018, 4:49 PMcurl / wget/ chrome handle that for you, because people have broken apis - n
Nikky
10/19/2018, 4:51 PMwhere is that
though and how do i use it in a get / download request ?validStatusInterceptor - d
Derk-Jan Karrenbeld
10/19/2018, 4:55 PM - d
Derk-Jan Karrenbeld
10/19/2018, 4:56 PMAnyway, for your use case: