https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:56 PM
    - remove the interceptors there by default (via FuelManager or whatever) - copy this code to a class/file: https://raw.githubusercontent.com/kittinunf/Fuel/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/interceptors/RedirectionInterceptor.kt
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:56 PM
    - add that as an interceptor
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:57 PM
    What do you get back from the API and what do you need to transform it to?>
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:57 PM
    If it's common we can add it!
  • n

    Nikky

    10/19/2018, 4:58 PM
    i think my usecase is rather to replace the redirectResponseInterceptor
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:58 PM
    Yes, so remove the default one and add your own 🙂
  • n

    Nikky

    10/19/2018, 4:58 PM
    did nto find that when i implemented this a few months ago
  • n

    Nikky

    10/19/2018, 4:58 PM
    ahh yes
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 4:58 PM
    I just linked the default one so you have a base to write your own hehe 😄
  • n

    Nikky

    10/19/2018, 5:01 PM
    can you renmove a interceptor for just one request ?
  • n

    Nikky

    10/19/2018, 5:01 PM
    would i make my own FuelManager instance and then reuse that ?
    👍 1
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 5:08 PM
    Instead of 
    FuelManager.instance
    , use:
    Copy code
    val special = FuelManager()
special.removeAllResponseInterceptors()
special.addResponseInterceptor(...)
special.addResponseInterceptor(validatorResponseInterceptor(200..299))
special.request(...)
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 5:10 PM
    you cant use the string extensions etc, you have to use 
    special.request(...)
  • d

    Derk-Jan Karrenbeld

    10/19/2018, 5:10 PM
  • n

    Nikky

    10/19/2018, 5:34 PM
    ow thanks.. this makes everything so clean
  • n

    Nikky

    10/19/2018, 5:34 PM
    well relatively
  • k

    kittinunf

    10/20/2018, 7:42 AM
    if anyone has a bit of time to spare, can you check this https://github.com/kittinunf/Fuel/pull/476
  • k

    kittinunf

    10/20/2018, 7:43 AM
    before it will be flushed by changes to make lint happy 🙂
    👍 1
  • m

    Mark Gilchrist

    10/20/2018, 8:29 AM
    commented
  • k

    kittinunf

    10/20/2018, 9:09 AM
    Ok … I just 💥 the PR …
  • n

    Nikky

    10/20/2018, 9:28 AM
    I added a test to the content-header stuff, i think its gonna be good enough, but its not good enoug if someone adds a different header 
    content-type
    in addition to 
    Content-Type
    i think its fine to not handle that for now, once type insensitive storage is added this will be handled as well
  • m

    Mark Gilchrist

    10/20/2018, 9:44 AM
    Are you adding case insensitive storage?
  • n

    Nikky

    10/20/2018, 9:44 AM
    i hope i can help with it.. its definitly on my list of want to have
  • n

    Nikky

    10/20/2018, 9:46 AM
    another thing i want to add but won't (becuse i never used it) is protobuf support
  • n

    Nikky

    10/20/2018, 9:46 AM
    since i have no idea how to use it, where its usecases are etc.. but it should be easy now that kotlinx-serialization is in
  • n

    Nikky

    10/20/2018, 11:41 AM
    so #474 is done i think, the tests handle the old stuff as failure, could someone merge it ? i am unsure if i am too trigger happy
  • k

    kittinunf

    10/21/2018, 2:30 AM
    I will take the protobuf support
  • k

    kittinunf

    10/21/2018, 2:30 AM
    💪 leave it to me
  • n

    Nikky

    10/21/2018, 10:01 AM
    https://github.com/kittinunf/Fuel/pull/474well, nobodz said anything in the issue or here.. i will merge
  • n

    Nikky

    10/21/2018, 10:01 AM
    whats the preferred way? rebase and merge ?
1...323334...118Latest