squash and merge please

so i just noticed the only examples on the readme are using the callback syntax

some people do not like that and are discarding fuel as a option because they did not see that you can also do

val(request, response, result) = "someUrl".httpGet()
    .awaitObjectResponse<SomeType>()

Documentation is lacking more, like fuel manager methods. We should probably show better examples.

thisa would be much easier if github had a way to embed code snippets from actual code then you do not have to worry as much about documentation rotting

You can link to code, but what are you trying to do?

and not just gists

i do not like having samples in multiple places and making sure to change all of them and not forgetting some thing in some markdown somewhere and then getting issues because people complain at sample code they copied not working this is not my experience with fuel so far but other projects

I understand. People tend to not read JavaDoc tho, and unfortunately it doesn't have "doctests" like rust.

when i look at a project i look first at the readme and samples provided

then maybe one or two links deep if samples are linked there

i just thought that.. the easiest way to implement case insensitive headers would be to take this: https://github.com/kittinunf/Fuel/blob/master/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/Request.kt#L28 and replace with with a inline class that overrides all important operators

like

get

,

set

with versions that normalize the casing of the strings

I'm already doing it

cool

(and yes, I am using a hashmap that overrides the key to be case-insensitive 🙂 )

i would so something like

key.split("-").map { it.lowerCase().capitalize() }.joinToString("-")

but not sure if thats overkill

you can just uppercase/lowercase the entire key, but that's not what I am doing.

data class HeaderName(val name: String) {
        private val normalized = name.toUpperCase()
        override fun hashCode(): Int {
            return normalized.hashCode()
        }

        override fun equals(other: Any?): Boolean {
            return (other is HeaderName) && other.normalized === normalized
        }
    }

HeaderName(key)

can now be used as HashMap accessor and it will JustWork™, because HashMap uses

hashCode

.

i think that could be a inline class no ?

or can that not override equals and hashcode ? nvm ofc it cannot.. stupid me

There is no point in premature optimization IMO*

But I'll fix all this header stuff first like this and then we can all piss on it during PR Review ❤️ 😄

sure

I'm sure together we can optimize it all hehe

also really happy you are doing this.. i got so much to do at once already 😛

👍

I'm also fixing all the multipart stuff / progress not being copied / yadayada

oh i should look into using fuel to receive multipart data again.. last time i ave up and just copied a stupid java implementation