Channels
#kotlin-fuel
- d
Derk-Jan Karrenbeld
10/29/2018, 4:37 PMkotlin 1.3 is out , whats the plan ? finish all existing PRs and then bump ?
I don't mind rewriting if we want an intermediary release - d
Derk-Jan Karrenbeld
10/29/2018, 4:38 PMBut at least 485 would be nice to merge. 486 is much more of a change I want to discuss with @kittinunf and the rest, as it changes request to an interface and I want to know the reasoning it wasn't before, maybe I'm missing something. Or maybe there is a better way to do it 😄 - n
Nikky
10/29/2018, 8:07 PMwell i am working on 1.3.0 .. just so much effort to set this up on a new PC, because android SDK - d
Derk-Jan Karrenbeld
10/29/2018, 8:32 PMYeah, I had installed the android SDK already, and once it is set in local properties everything does work (intellij) - n
Nikky
10/29/2018, 8:34 PMyeah.. but now it seems stuck:https://i.imgur.com/4s3ymHv.png▾
- n
Nikky
10/29/2018, 8:34 PMno idea what it downloads there or why.. this did not happen on my laptop - d
Derk-Jan Karrenbeld
10/29/2018, 9:09 PMYou should go into Android > SDK Manager and make sure that the correct components are isntalled first - d
Derk-Jan Karrenbeld
10/29/2018, 9:09 PMTools > Android > SDK Manager * - d
Derk-Jan Karrenbeld
10/29/2018, 9:10 PMI think at least - API 28 + 27 (including sources) - SDK Build Tools - Android SDK Platform-Tools - Android SDK Tools - n
Nikky
10/29/2018, 9:11 PMyeah that all is there.. the tests ran once already - n
Nikky
10/29/2018, 9:11 PMand then upon changing versions of dependencies that happened - n
Nikky
10/29/2018, 9:11 PManyways it works now and i opened the PR - d
Derk-Jan Karrenbeld
10/29/2018, 9:12 PMOkay sweet - n
Nikky
10/29/2018, 9:12 PM - n
Nikky
10/29/2018, 9:55 PMmaybe it would be better to have README.md in each module and link there from the main README - n
Nikky
10/29/2018, 9:55 PMit is getting a bit long and unorganized - d
Derk-Jan Karrenbeld
10/29/2018, 9:59 PMI think that would be nice to add regardless! - n
Nikky
10/29/2018, 10:19 PMi guess a second PR then, but i cannot really work on it until my current PR is through because that one i did from my own master.. stupid decision - d
Derk-Jan Karrenbeld
10/29/2018, 10:22 PMYou can, just mark it as do not merge and remove it when your old one is merged - n
Nikky
10/29/2018, 10:28 PMhmm well i mean i want to test things with github pages, i guess i could switch the main branch away from master on my fork to experiment with it - d
Derk-Jan Karrenbeld
10/29/2018, 10:40 PMI wouldn't move to gh-pages just yet; adding README.md to the subfolders and relative linking is the way to go as far as I'm concerned - n
Nikky
10/29/2018, 10:46 PMwell relative linking is the problem.. it can only work for one situation, i cannot make links work both locally, when looking at the root folder on github and when looking at the Readme.md on github - n
Nikky
10/29/2018, 10:47 PMi wish there was some feature in relative urls that lets me say.. goi up to level 2 eg: github.com/user/repo/ and then i can slap working relative links on that - d
Derk-Jan Karrenbeld
10/29/2018, 10:51 PMIt works just fine, see here: https://github.com/TrailerVote/trailervote-api-clients/blob/master/README.md - d
Derk-Jan Karrenbeld
10/29/2018, 10:51 PM(I wrote that) - n
Nikky
10/29/2018, 10:52 PMohh i seee - d
Derk-Jan Karrenbeld
10/29/2018, 10:53 PM🙂 - n
Nikky
10/29/2018, 10:58 PMwhat do you say.. 1️⃣ merge now so @kittinunf has a nice surprise to wake up to.. or 2️⃣ wait for feedback ? - d
Derk-Jan Karrenbeld
10/29/2018, 11:35 PMI'd wait so he can comment on https://github.com/kittinunf/Fuel/pull/487#discussion_r229121051 - n
Nikky
10/29/2018, 11:46 PMwe can also create a issue or PR for a next version afterwards well if anybody is being nlocked by this they can merge it👍 1