https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • n

    Nikky

    10/30/2018, 2:25 AM
    yes, its hard to edit it, especially when idea hangs because md support is weird
  • n

    Nikky

    10/30/2018, 2:25 AM
  • n

    Nikky

    10/30/2018, 2:26 AM
    i put READMEs into fuel-kotlinx-serialization and fuel-gson
  • n

    Nikky

    10/30/2018, 2:26 AM
    other stuff like the advanced section could go into 
    docs/advanced/README.md
  • n

    Nikky

    10/30/2018, 2:27 AM
    having folders for each section also allows having code snippets as files there, in case of larger snippets of code
  • n

    Nikky

    10/30/2018, 3:18 AM
    i hope we get that somewhat soon: https://github.com/jacoco/jacoco/pull/764 test coverage is quite unreliable at the moment
    👍 1
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 3:36 AM
    Yeah. It's definitely incorrect in my PRs.
  • k

    kittinunf

    10/30/2018, 3:36 AM
    I wish we have more reliable way for that
  • k

    kittinunf

    10/30/2018, 3:37 AM
    let me add into my chores stuff to do
    ❤️ 1
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 3:39 AM
    I haven't figured out exactly why some things aren't marked correctly
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 3:40 AM
    Anyway. 485 is not very offensive in terms of changes :) 486 just fixes a lot of issues but maybe we want to break it up in smaller changes. I don't mind putting in that work.
  • n

    Nikky

    10/30/2018, 3:50 AM
    given the amount of things it does not show as covered .. 75+% is good coverage
  • n

    Nikky

    10/30/2018, 3:57 AM
    also @kittinunf i had some service crap on me earlier today and i noticed that SocketTImeoutException is not handled by Fuuel and captured in a FuelError
  • n

    Nikky

    10/30/2018, 3:58 AM
    and 🛏️ time for me
  • k

    kittinunf

    10/30/2018, 4:35 AM
    Go to bed sir!
  • k

    kittinunf

    10/30/2018, 2:40 PM
    @Derk-Jan Karrenbeld I finished reviewing bro, mostly those are nits left. If you don’t have time let me know, I am happy to jump in
  • k

    kittinunf

    10/30/2018, 2:40 PM
    I really like what I saw there. Awesome! 👏
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:40 PM
    I got time!
  • k

    kittinunf

    10/30/2018, 2:40 PM
    great job 😉
    😬 1
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:41 PM

    https://media.giphy.com/media/wrBURfbZmqqXu/giphy.gif▾

  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:43 PM
    Anyway. Will look at the nits and fix. Do you want me to break 486 up into smaller PRs? I needed to figure out where it was going but now I know so I could haha. @kittinunf
  • k

    kittinunf

    10/30/2018, 2:44 PM
    yeah … to be honest, I don’t know where to start
  • k

    kittinunf

    10/30/2018, 2:44 PM
    if you can, I think that would be much appreciated
  • k

    kittinunf

    10/30/2018, 2:45 PM
    I think let’s aim to merge 485 first
  • k

    kittinunf

    10/30/2018, 2:45 PM
    then you can have a fresh start
  • k

    kittinunf

    10/30/2018, 2:45 PM
    i am working on the removal of novada/plugin at the moment
    ❤️ 1
  • k

    kittinunf

    10/30/2018, 2:45 PM
    so we can remove the gradle 4.4 blocker
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:46 PM
    Perfect
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:46 PM
    That will do
  • d

    Derk-Jan Karrenbeld

    10/30/2018, 2:46 PM
    A lot of the changes in 486 are actually no longer tied to eachother, so that will be easy
1...404142...118Latest