Channels
#kotlin-fuel
- d
Derk-Jan Karrenbeld
10/30/2018, 5:53 PM@Nikky your change has been merged 😄 - n
Nikky
10/30/2018, 5:53 PMNice - d
Derk-Jan Karrenbeld
10/30/2018, 5:57 PMMight want to merge https://github.com/kittinunf/Fuel/pull/490 before 2.0 - n
Nikky
10/30/2018, 6:13 PMseems like a good idea - d
Derk-Jan Karrenbeld
10/30/2018, 10:45 PMAlso extracted upload + download progress on any request: https://github.com/kittinunf/Fuel/pull/491 (and yeah also allows you to have both) - k
kittinunf
10/30/2018, 11:37 PMMorning - n
Nikky
10/30/2018, 11:38 PMmoin - k
kittinunf
10/30/2018, 11:38 PMThat Rx extension will affect my project ... - n
Nikky
10/31/2018, 12:58 AMmaybe you could keep the old names and annotate them with@Deprecated("renamed", ReplaceWith("newFunctionName(argument)"), DeprecationLevel.Error) - n
Nikky
10/31/2018, 1:07 AM@kittinunf even if this is not part of the api i find this very helpful for making sure a large codebase transitions to a new api properly (at least when its just function renames or argument reordering)👍 1 - k
kittinunf
10/31/2018, 1:21 AMBut now i think we are removing it no? - k
kittinunf
10/31/2018, 1:21 AMNot deprecating - m
Mark Gilchrist
10/31/2018, 7:26 AMit would be nice to have one version with a deprecated and `repalceWith`so all our users have to do it click fix - d
Derk-Jan Karrenbeld
10/31/2018, 1:24 PMI'm fine adding the deprecation! - d
Derk-Jan Karrenbeld
10/31/2018, 1:24 PMI'll implement them as aliases, so it's barely overhead - n
Nikky
10/31/2018, 1:27 PMi keep dragging around deprecation for at least one version usually - n
Nikky
10/31/2018, 1:28 PMjust so people have a appropriate amount of time to fix things - d
Derk-Jan Karrenbeld
10/31/2018, 1:30 PMTe other deprecations have been around for 4 versions. - d
Derk-Jan Karrenbeld
10/31/2018, 1:30 PMFuel does not do semantic versioning right. - d
Derk-Jan Karrenbeld
10/31/2018, 1:31 PMAnywaaaay, let's just add those deprecations 😄 - n
Nikky
10/31/2018, 1:32 PMjust make sure to add it asDeprecationLevel.Error - d
Derk-Jan Karrenbeld
10/31/2018, 1:40 PMOk no problem - d
Derk-Jan Karrenbeld
10/31/2018, 4:23 PMI think it's done - n
Nikky
10/31/2018, 5:01 PMdid you test if the functions properly replace yet ? - d
Derk-Jan Karrenbeld
10/31/2018, 5:02 PMYep - d
Derk-Jan Karrenbeld
10/31/2018, 5:03 PMError message - n
Nikky
10/31/2018, 5:03 PMin some edgecases - d
Derk-Jan Karrenbeld
10/31/2018, 5:03 PMReplace message - d
Derk-Jan Karrenbeld
10/31/2018, 5:04 PMResult 😄 - n
Nikky
10/31/2018, 5:04 PM👏