kotlinlang #kotlin-fuel

https://github.com/kittinunf/Fuel/pull/491 Progress for upload, download, even when using a generic GET/POST/PATCH ánd fix for progress with redirection. Added a new fuelManager variable that allows you to control how often the progress is called.

Nikky

11/01/2018, 1:14 AM

could this be adapted to not only write progress, but write data as it is received ?

Derk-Jan Karrenbeld

11/01/2018, 1:17 AM

What do you mean?

Nikky

11/01/2018, 1:17 AM

usecase is a connection with a long timeout receiving blobs of data

Nikky

11/01/2018, 1:18 AM

i just wish to use the api with a coroutine friendly client and code thats easier to reason about than pure java stdlib

Derk-Jan Karrenbeld

11/01/2018, 1:19 AM

You don't need this change, theoretically, to support that. What you can do is write your own deserializer that takes a stream. Use

.ready

.available

(don't know of the top of my head what it is called) to see if there is data in the stream waiting. Side effect in your deserializer to file.

Derk-Jan Karrenbeld

11/01/2018, 1:19 AM

I would NOT suggest using

.download

Derk-Jan Karrenbeld

11/01/2018, 1:20 AM

Make sure you implement

deserialize(stream: InputStream)

and NOT

deserialize(string: String)

deserialize(bytes: ByteArray)

Nikky

11/01/2018, 1:20 AM

will this work even if the stream is not finished yet ?

Derk-Jan Karrenbeld

11/01/2018, 1:20 AM

Yes

Derk-Jan Karrenbeld

11/01/2018, 1:21 AM

Make sure there is no GZIP or whatever encoding

Derk-Jan Karrenbeld

11/01/2018, 1:21 AM

GZIP requires the entire stream

Nikky

11/01/2018, 1:21 AM

this is the code i was using before: https://github.com/elytra/MatterLink/blob/master/core/src/main/kotlin/matterlink/api/StreamConnection.kt

Nikky

11/01/2018, 1:22 AM

the inability to translate this to coroutines held me back.. now i can continue on my chatbot project

Derk-Jan Karrenbeld

11/01/2018, 1:22 AM

Yes, we do exactly the same!

Derk-Jan Karrenbeld

11/01/2018, 1:23 AM

urlConnection!!.inputStream

is passed to body, and it is NOT being loaded into memory by default

Derk-Jan Karrenbeld

11/01/2018, 1:23 AM

(so it doesn't need to be finished)

Derk-Jan Karrenbeld

11/01/2018, 1:23 AM

called responseString() will try to coerce it to a string, so that will try to consume the entire stream

Derk-Jan Karrenbeld

11/01/2018, 1:23 AM

You basically need line

81 through 104

in a custom

deserializer

Nikky

11/01/2018, 1:25 AM

something else.. what is timeout and what is timeoutRead ?

Nikky

11/01/2018, 1:25 AM

where is the difference ? they are not sufficiently commented

Derk-Jan Karrenbeld

11/01/2018, 1:25 AM

Connection timeouts

Derk-Jan Karrenbeld

11/01/2018, 1:25 AM

Derk-Jan Karrenbeld

11/01/2018, 1:25 AM

I think the first one is total and the second one is until it reads?

Derk-Jan Karrenbeld

11/01/2018, 1:25 AM

I have not written that code

Nikky

11/01/2018, 1:30 AM

so the second one would be fine to have a small timeout as long as the first data comes in fast ?

Nikky

11/01/2018, 1:36 AM

so the deserialization functionms are not suspending.. i could wrape the whole thing in a runBlocking

Nikky

11/01/2018, 1:37 AM

or just every time i need to send() to the channel

Derk-Jan Karrenbeld

11/01/2018, 1:39 AM

or just every time i need to send() to the channel

I would probably do this!

Derk-Jan Karrenbeld

11/01/2018, 1:40 AM

I would suggest you actually spawn a Task or whatever from your custom deserializer and then return instantly with "nothing".