and if there is a way to test that

It is. chunked decoding SHOULD be handled by the HttpURLConnection, but it apparently isn't. Let me see the spec and I will write you an implementation

For your use case, you can probably just do the following @Nikky :

its your PR that broke it

Copy

HttpClient

and change the decode function to

private fun decode(stream: InputStream, encoding: String): InputStream {
        return when (encoding) {
            "gzip" -> GZIPInputStream(stream)
            "deflate" -> InflaterInputStream(stream)
            "identity" -> stream
            "chunked" -> stream
            "" -> stream
            else -> throw UnsupportedOperationException("Decoding $encoding is not supported. $SUPPORTED_DECODING are.")
        }
    }

Yes, I will add support for

chunked

encoding 🙂

(or rather decoding 😛 )

Anyway, for now, if you make this change, it will work for you

so do i have to replace that in the lib ?

Yes

I'll add a PR to handle this correctly

okay well i guess i will use my own fork for a bit

thx

Yes, that would be best

In reality, normally you would want the HttpClient to handle this for you. You don't want a deserializer to take care of "chunks", but for your case, you need the chunks in order to determine how big your message is.

So basically we need an option to: 1. decode "chunked" in the client 2. pass through "chunked" without decoding

tbh we need your use case to be supported out of the box 🙂

i want chunked decoded so i just have to implement a reader

Okay, then we just need to add that

and

"identity", "chunked" -> stream

looks nicer

Sure, you can make it

"identity", "chunked", ""  -> stream

I'll open a ticket and work on it, unless you want to implement it

you could open a ticket.. i can try to work on the code.. i have a simple and a complex reproducer ready

Sure. Checkout this package:

package sun.net.www.http

It has a class called

ChunkedInputStream

.

You basically need to recreate that.

@Nikky done. I would suggest writing a test first that mocks a request and returns a chunked response, so you can inspect if it comes in at

decode

unchunked, but with the errored header, or actually still chunked. (just read the stream there and println or whatever 😛 )

i have no clue how to write that test

but i will try