https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    11/02/2018, 3:10 AM
    Morning everyone!
  • k

    kittinunf

    11/02/2018, 3:11 AM
    oh no seems like i missed the juicy discussion
  • n

    Nikky

    11/02/2018, 3:36 AM
    a little bit
  • n

    Nikky

    11/02/2018, 3:36 AM
    morning.. i am going to bed.. way past bedtime
  • n

    Nikky

    11/02/2018, 3:37 AM
    i have a single line PR that fixes it though.. 😛
  • n

    Nikky

    11/02/2018, 3:38 AM
    well technically 2 lines.. commenting code is important
  • d

    Derk-Jan Karrenbeld

    11/02/2018, 4:03 AM
    Don't forget my progress changes :D @kittinunf
  • k

    kittinunf

    11/02/2018, 5:05 AM
    i will take a look in a bit
  • n

    Nikky

    11/02/2018, 10:51 AM
    @ImplicitReflectionSerializer
    really annoys me. i will add a method to avoid that
  • n

    Nikky

    11/02/2018, 11:10 AM
    i think this should be a fast one too https://github.com/kittinunf/Fuel/pull/497
  • n

    Nikky

    11/02/2018, 11:13 AM
    the coverage will be horrible though.. since its all inlined extension functions not a single line will be hit
  • n

    Nikky

    11/02/2018, 11:18 AM
    i will be able to test it once jitpack builds the branch for me
  • n

    Nikky

    11/02/2018, 11:18 AM
    but i just copied my local fix there, i do not expect things to differ
  • n

    Nikky

    11/02/2018, 1:47 PM
    @Derk-Jan Karrenbeld i seem to be running into Parser Errors on verz long JSON responses, seems to me like the reader and InputStream handlers on 
    kotlinxSerializerOf
    are creating that problem
  • n

    Nikky

    11/02/2018, 1:48 PM
    but i am not sure yet
  • n

    Nikky

    11/02/2018, 1:48 PM
    also this:
    Copy code
    java.lang.ClassCastException: kotlinx.serialization.json.JsonParsingException cannot be cast to com.github.kittinunf.fuel.core.FuelError
	at com.github.kittinunf.fuel.core.DeserializableKt$awaitResponse$res$2.invoke(Deserializable.kt)
	at com.github.kittinunf.result.ResultKt.mapError(Result.kt:42)
	at com.github.kittinunf.fuel.core.DeserializableKt.awaitResponse(Deserializable.kt:117)
	at CoroutinesKt$await$2.invokeSuspend(Coroutines.kt:20)
	at CoroutinesKt$await$2.invoke(Coroutines.kt)
  • d

    Derk-Jan Karrenbeld

    11/02/2018, 1:49 PM
    The last one is easy
  • d

    Derk-Jan Karrenbeld

    11/02/2018, 1:49 PM
    Parser errors must be caught and wrapped in fuelerror
  • n

    Nikky

    11/02/2018, 1:50 PM
    this also happened a few days ago with some SocketExceptions
  • n

    Nikky

    11/02/2018, 1:51 PM
    UnsupportedOperationException iirc.. that was related to the chunked encoding
  • n

    Nikky

    11/02/2018, 1:55 PM
    okay but how do i catch that ? in 
    fuel
    that dependency does not exist, in 
    fuel-kotlinx-serialization
    i cannot return Result
  • n

    Nikky

    11/02/2018, 1:55 PM
    or do i just throw a Fuel Error ?
  • n

    Nikky

    11/02/2018, 2:08 PM
    Copy code
    Response : OK
Length : 1923658
Body : (1923658 bytes of application/octet-stream)
Headers : (9)
Connection : keep-alive
Date : Fri, 02 Nov 2018 14:07:07 GMT
ETag : "5bc9199f-1d5a4a"
Server : nginx
X-Clacks-Overhead : GNU Terry Pratchett
Accept-Ranges : bytes
Content-Type : application/octet-stream
Last-Modified : Thu, 18 Oct 2018 23:39:11 GMT
Content-Length : 1923658
  • n

    Nikky

    11/02/2018, 2:09 PM
    thats the response i get back, but the json coming along with it is chopped off
  • n

    Nikky

    11/02/2018, 2:12 PM
    when i curl i get this:
    Copy code
    < HTTP/1.1 200 OK
< Server: nginx
< Date: Fri, 02 Nov 2018 14:10:21 GMT
< Content-Type: application/octet-stream
< Content-Length: 1923658
< Connection: keep-alive
< Last-Modified: Thu, 18 Oct 2018 23:39:11 GMT
< ETag: "5bc9199f-1d5a4a"
< X-Clacks-Overhead: GNU Terry Pratchett
< Accept-Ranges: bytes
  • n

    Nikky

    11/02/2018, 2:12 PM
    i should check the bytecount of the response string
  • n

    Nikky

    11/02/2018, 2:15 PM
    the length i am getting back is 85016
  • n

    Nikky

    11/02/2018, 2:15 PM
    so it handles it as if it were chunked ?
  • n

    Nikky

    11/02/2018, 2:22 PM
    i know that at some point Fuel returns the response too fast and does not wait for the whole content-length to be available
  • n

    Nikky

    11/02/2018, 2:22 PM
    but thats about it
1...495051...118Latest