I just stumbled upon a LOT of issues with our tests and some with our code. Basically anything that uses handler is not actually being tested. The gson deserializer<T> implicit type deserializer doesn't work, and rx is implemented incorrectly (never uses the error pipe, cancelation will never work like this).

I've fixed the cancellation issues and working on the async tests, but oh boi I hope this doesn't actually show us other issues 😓

see the stuff i fixed where it used FuelError in the pipline and implicitly casted any exceptions to FuelErrors and failed that way

icould not believe no test picked that up

Yeah now I do

The fix is pretty straightforward, but ha

Basically instead of relying on the old

testMode

with blocking = true, which doesn't alllow us to test asynchronousliness, my refactor where only async requests are cancellable can now "wait" inline:

@Test
    fun gsonTestResponseObjectAsync() {
        var isAsync = false
        val running = reflectedRequest(Method.GET, "user-agent")
            .responseObject(gsonDeserializerOf(HttpBinUserAgentModel::class.java)) { _, _, result ->
                val (data, error) = result
                assertThat("Expected data, actual error $error", data, notNullValue())
                assertThat("Expected data to have a user agent", data!!.userAgent, notNullValue())
                assertThat("Expected isAsync to be true, actual false", isAsync, equalTo(true))
            }

        isAsync = true
        running.join()

        assertThat(running.isDone, equalTo(true))
        assertThat(running.isCancelled, equalTo(false))
    }

Lol

I understand why the gson test fails

Someone tried to deserialize List<IssueInfo>, but of course that generic type is lost.

FYI, I did just fix 505 through 511, except 509 but am working on test updates for 509 and documentation changes. Then I'll open the PR. dataparts etc will be done on top of this and that will be (for now) my final PR for 2.0.

https://github.com/kittinunf/Fuel/pull/512 ha. Complexity

-60

XD

nice

beh. I don't understand why one of the two tests is failing 😮

fixed it 😄

That's someone is probably me xD

Hahaha

Well it figuredit out

Now doing the cancellation tests, documentation and then it's review time, again

I have 3 hr layover

I will try to work on Fuel as much as I can

Sweet

Where you flying to?

Oh @kittinunf most important is that bintray I think

I am working on it!

i am flying back to Tokyo

… kotlin-dsl is not really that easy to work with

not really sure that it was a good idea that we migrated …

are you trying to do the migration to the other plugin ?

i have used it pretty successfully with maven-publish at least