but yeah it does NOT like any sort of dynamic registration by name or so .. that requires some more code

That's was not the hard part

I felt like i don't even know what class to configure

you mean with configure<SomeClass> {} ?

What is the equivalent version of this for that in kotlin dsl

mostly its the same now in 4.10.2

are we using that yet ?

Yes ... I couldn't make the Android artifact to work ...

No ... I am trying to migrate it on my locals now

can you push your changes to a feature / fix branch and i can take a look at it ? once you give up or try to work on smth else

i barely did android before myself but .. i will try

Haha

So I'm doing cancellations as part of that big ass pr which refractors a lot.

Guess what, currently things can't really be cancelled in flight

(fixed it, ha)

feels like the amount of bugs and fixes for 2.0.0 just keeps growing

😛

how dare you uncover all the broken code

^_^

Sorry 😛

Alright. Pretty confident now that I'm nearing the end of the PR. Just more tests and documentation, but not more implementation changes, I think.

Feel free to check it out and let me know if you're all onboard: https://github.com/kittinunf/Fuel/pull/512 cc @kittinunf @Mark Gilchrist @itnoles @Nikky In a next PR I want to extract the MultiPart changes, but this PR shouldn't grow any bigger. I think it's easier to grasp than the other big one, couldn't really make these changes individually, as I figured out the bugs as I went. In the PR description you can see what exactly has been changes feature/fix wise.

(and yes, this does allow you to have a request that is both uploading a file AND downloading a file)

Also I hope that no-one really minds me taking on this bunch. I just felt like it's important we solidify it before 2.0.0 since this is a breaking change 😄. I'm slowly more confident in using

Fuel

in production -- currently mostly use it for quick sample apps 😄

I am here.

I am thinking to create issues that take 1.16.0 tag into a new tag 1.16.1 with Kotlin 1.3 release that requires change on corountines and serializations.

We're moving to 2.0.0, if I understood correctly, breaking it all.

I know that, 1.16.0 has Kotlin 1.3 RC versions. I am not too sure about to mix RC and Release versions.

Oh yeah, I agree. 2.0.0 / 1.17.0 / 1.16.1 should just have kotlin 1.3. Completely agreed with you

🛬