https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • i

    itnoles

    11/10/2018, 3:42 PM
    About fuel-android, I noticed old JSONObject. Is that is really Android related?
  • d

    Derk-Jan Karrenbeld

    11/10/2018, 5:01 PM
    No. I am using org.json in fuel-test as well
  • d

    Derk-Jan Karrenbeld

    11/10/2018, 5:01 PM
    Only really androidy thing is the looper integration for callbacks
  • d

    Derk-Jan Karrenbeld

    11/10/2018, 7:25 PM
    @kittinunf when you have time let me know your thoughts on that big ass PR. Working on the documentation changes
  • k

    kittinunf

    11/11/2018, 8:05 AM
    I feel stupid every time I am working on build gradle thingy
  • i

    itnoles

    11/11/2018, 5:16 PM
    It is not easy to merge all build.gradle together.
  • i

    itnoles

    11/11/2018, 10:21 PM
    I like how Android API 28 is like "Did you forget to close the response body?" by using Fuel 1.16.0 😞
  • i

    itnoles

    11/11/2018, 10:33 PM
    it wouldn't be easy Fix with Derk's PR.
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 10:41 PM
    Because? I close the response body after reading it in the 
    Deserializer
    now, or do you mean something else?
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 10:41 PM
    (Also how is it more difficult with the PR? If so, I should work on it to make it easier 😄 )
  • i

    itnoles

    11/11/2018, 11:39 PM
    InputStream should be closed in the finally block
  • i

    itnoles

    11/11/2018, 11:41 PM
    try { inputstream } catch (IOException) { errorInputStream } finally { inputstream.close() }
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:43 PM
    No, it should not. In kotlin you should use 
    stream.use
    , which I do.
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:44 PM
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:45 PM
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:45 PM
    This is why I've added this comment if someone overwrites that method 😄 : https://github.com/kittinunf/Fuel/pull/512/files#diff-fececc99239d4e844c4cce8342aa7668R17
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:46 PM
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:47 PM
    I will also check current master for you on API 28 @itnoles! 😄
  • i

    itnoles

    11/11/2018, 11:54 PM
    use is very odd function because it just throw exceptions and close inputstream
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:54 PM
    I don't know what you are talking about. 
    use
    is implemented exactly like 
    try { } finally { }
  • i

    itnoles

    11/11/2018, 11:56 PM
    try {} catch (IOException ioe) { throw ioe } finally {}
  • d

    Derk-Jan Karrenbeld

    11/11/2018, 11:57 PM
    I still don't understand what you mean. Can you please try to explain to me what's wrong with use because your example does not make any sense to me or what the issue is here. Your earlier example with returning errorStream is wrong, because it won't close the errorStream 😕
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 12:14 AM
    I've just made a change in case that's what you meant. I don't think there is anything wrong with 
    use
    , but at least what I just pushed now always makes sense 🙂
  • k

    kittinunf

    11/12/2018, 1:56 AM
    @Derk-Jan Karrenbeld regarding to the indentation, i think we should use a code style file to make it consistent
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 1:56 AM
    Agreed 100%
  • k

    kittinunf

    11/12/2018, 1:57 AM
    Can you export yours and put it in the project?
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 1:57 AM
    Yes sir 👮‍♂️
  • k

    kittinunf

    11/12/2018, 1:57 AM
    I think we all can import them and viola, we don't discuss this anymore.
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 1:57 AM
    That would be great. I'm even struggling with it across machines
  • k

    kittinunf

    11/12/2018, 1:57 AM
    Oh no ... Was that too demanding sorry? I couldn't tell
1...575859...118Latest